ansible/hetzner.hcloud
1
0
Fork 0
mirror of https://github.com/ansible-collections/hetzner.hcloud.git synced 2026-02-04 08:01:49 +00:00
Code Activity

fix(server): only show force_upgrade warning if actually set (#214)

Browse source 
Make sure that we only log the deprecation warning if force_upgrade was actually
set. Right now it also logs because a default value for the field is set.
This commit is contained in:
Julian Tölle 2023-05-16 11:29:41 +02:00 • committed by GitHub
parent 1cf7be0486
commit 90451c22e3
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 2 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

5
plugins/modules/hcloud_server.py
View file

@ -110,7 +110,6 @@ options:
- Force the upgrade of the server. - Force the upgrade of the server.
- Power off the server if it is running on upgrade. - Power off the server if it is running on upgrade.
type: bool type: bool
default: no
force: force:
description: description:
- Force the update of the server. - Force the update of the server.
@ -571,7 +570,7 @@ class AnsibleHcloudServer(Hcloud):
return primary_ip return primary_ip
def _update_server(self): def _update_server(self):
if "force_upgrade" in self.module.params: if "force_upgrade" in self.module.params and self.module.params.get("force_upgrade") is not None:
self.module.warn("force_upgrade is deprecated, use force instead") self.module.warn("force_upgrade is deprecated, use force instead")
try: try:
@ -879,7 +878,7 @@ class AnsibleHcloudServer(Hcloud):
ipv6={"type": "str"}, ipv6={"type": "str"},
private_networks={"type": "list", "elements": "str", "default": None}, private_networks={"type": "list", "elements": "str", "default": None},
force={"type": "bool", "default": False}, force={"type": "bool", "default": False},
force_upgrade={"type": "bool", "default": False}, force_upgrade={"type": "bool"},
allow_deprecated_image={"type": "bool", "default": False}, allow_deprecated_image={"type": "bool", "default": False},
rescue_mode={"type": "str"}, rescue_mode={"type": "str"},
delete_protection={"type": "bool"}, delete_protection={"type": "bool"},