From 90451c22e32b659ca49dbcafbf82974bd45eaa7d Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Julian=20T=C3=B6lle?= Date: Tue, 16 May 2023 11:29:41 +0200 Subject: [PATCH] fix(server): only show force_upgrade warning if actually set (#214) Make sure that we only log the deprecation warning if force_upgrade was actually set. Right now it also logs because a default value for the field is set. --- plugins/modules/hcloud_server.py | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/plugins/modules/hcloud_server.py b/plugins/modules/hcloud_server.py index 3a77da6..5f966e6 100644 --- a/plugins/modules/hcloud_server.py +++ b/plugins/modules/hcloud_server.py @@ -110,7 +110,6 @@ options: - Force the upgrade of the server. - Power off the server if it is running on upgrade. type: bool - default: no force: description: - Force the update of the server. @@ -571,7 +570,7 @@ class AnsibleHcloudServer(Hcloud): return primary_ip def _update_server(self): - if "force_upgrade" in self.module.params: + if "force_upgrade" in self.module.params and self.module.params.get("force_upgrade") is not None: self.module.warn("force_upgrade is deprecated, use force instead") try: @@ -879,7 +878,7 @@ class AnsibleHcloudServer(Hcloud): ipv6={"type": "str"}, private_networks={"type": "list", "elements": "str", "default": None}, force={"type": "bool", "default": False}, - force_upgrade={"type": "bool", "default": False}, + force_upgrade={"type": "bool"}, allow_deprecated_image={"type": "bool", "default": False}, rescue_mode={"type": "str"}, delete_protection={"type": "bool"},