ansible/hetzner.hcloud
1
0
Fork 0
mirror of https://github.com/ansible-collections/hetzner.hcloud.git synced 2026-02-04 08:01:49 +00:00
Code Activity

fix: string formatting error on deprecated server type warning (#309)

Browse source 
##### SUMMARY
after deprecating "server type" warning should be shown but due to error
in string message there is crash.
```
 File "/tmp/ansible_hcloud_server_payload__bgoim7j/ansible_hcloud_server_payload.zip/ansible_collections/hetzner/hcloud/plugins/modules/hcloud_server.py", line 942, in <module>
  File "/tmp/ansible_hcloud_server_payload__bgoim7j/ansible_hcloud_server_payload.zip/ansible_collections/hetzner/hcloud/plugins/modules/hcloud_server.py", line 925, in main
  File "/tmp/ansible_hcloud_server_payload__bgoim7j/ansible_hcloud_server_payload.zip/ansible_collections/hetzner/hcloud/plugins/modules/hcloud_server.py", line 858, in present_server
  File "/tmp/ansible_hcloud_server_payload__bgoim7j/ansible_hcloud_server_payload.zip/ansible_collections/hetzner/hcloud/plugins/modules/hcloud_server.py", line 405, in _create_server
  File "/tmp/ansible_hcloud_server_payload__bgoim7j/ansible_hcloud_server_payload.zip/ansible_collections/hetzner/hcloud/plugins/modules/hcloud_server.py", line 541, in _get_server_type
  File "/tmp/ansible_hcloud_server_payload__bgoim7j/ansible_hcloud_server_payload.zip/ansible_collections/hetzner/hcloud/plugins/modules/hcloud_server.py", line 558, in _check_and_warn_deprecated_server
TypeError: %i format: a real number is required, not str
```

##### ISSUE TYPE
- Bugfix Pull Request

##### COMPONENT NAME
hcloud_server

---------

Co-authored-by: jo <ljonas@riseup.net>
This commit is contained in:
urbanekpj 2023-08-23 14:08:06 +02:00 • committed by GitHub
parent b7869608f2
commit 8f42c4d950
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 3 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

2
changelogs/fragments/fix-string-formatting-error-on-deprecated-server-type-warning.yml Normal file
View file

@ -0,0 +1,2 @@
bugfixes:
- hcloud_server - Fix string formatting error on deprecated server type warning

2
plugins/modules/hcloud_server.py
View file

@ -548,7 +548,7 @@ class AnsibleHCloudServer(AnsibleHCloud):
) )
else: else:
self.module.warn( self.module.warn(
"Attention: The server plan % is deprecated and will no longer be available for order as of " "Attention: The server plan %s is deprecated and will no longer be available for order as of "
% server_type.name % server_type.name
+ "%s. Existing servers of that plan will continue to work as before " + "%s. Existing servers of that plan will continue to work as before "
% server_type.deprecation.unavailable_after.strftime("%Y-%m-%d") % server_type.deprecation.unavailable_after.strftime("%Y-%m-%d")