From 8f42c4d9502c844f4e86d110a2cfb0f86eb3f8be Mon Sep 17 00:00:00 2001 From: urbanekpj <34157776+urbanekpj@users.noreply.github.com> Date: Wed, 23 Aug 2023 14:08:06 +0200 Subject: [PATCH] fix: string formatting error on deprecated server type warning (#309) ##### SUMMARY after deprecating "server type" warning should be shown but due to error in string message there is crash. ``` File "/tmp/ansible_hcloud_server_payload__bgoim7j/ansible_hcloud_server_payload.zip/ansible_collections/hetzner/hcloud/plugins/modules/hcloud_server.py", line 942, in File "/tmp/ansible_hcloud_server_payload__bgoim7j/ansible_hcloud_server_payload.zip/ansible_collections/hetzner/hcloud/plugins/modules/hcloud_server.py", line 925, in main File "/tmp/ansible_hcloud_server_payload__bgoim7j/ansible_hcloud_server_payload.zip/ansible_collections/hetzner/hcloud/plugins/modules/hcloud_server.py", line 858, in present_server File "/tmp/ansible_hcloud_server_payload__bgoim7j/ansible_hcloud_server_payload.zip/ansible_collections/hetzner/hcloud/plugins/modules/hcloud_server.py", line 405, in _create_server File "/tmp/ansible_hcloud_server_payload__bgoim7j/ansible_hcloud_server_payload.zip/ansible_collections/hetzner/hcloud/plugins/modules/hcloud_server.py", line 541, in _get_server_type File "/tmp/ansible_hcloud_server_payload__bgoim7j/ansible_hcloud_server_payload.zip/ansible_collections/hetzner/hcloud/plugins/modules/hcloud_server.py", line 558, in _check_and_warn_deprecated_server TypeError: %i format: a real number is required, not str ``` ##### ISSUE TYPE - Bugfix Pull Request ##### COMPONENT NAME hcloud_server --------- Co-authored-by: jo --- ...tring-formatting-error-on-deprecated-server-type-warning.yml | 2 ++ plugins/modules/hcloud_server.py | 2 +- 2 files changed, 3 insertions(+), 1 deletion(-) create mode 100644 changelogs/fragments/fix-string-formatting-error-on-deprecated-server-type-warning.yml diff --git a/changelogs/fragments/fix-string-formatting-error-on-deprecated-server-type-warning.yml b/changelogs/fragments/fix-string-formatting-error-on-deprecated-server-type-warning.yml new file mode 100644 index 0000000..ce2b9da --- /dev/null +++ b/changelogs/fragments/fix-string-formatting-error-on-deprecated-server-type-warning.yml @@ -0,0 +1,2 @@ +bugfixes: + - hcloud_server - Fix string formatting error on deprecated server type warning diff --git a/plugins/modules/hcloud_server.py b/plugins/modules/hcloud_server.py index 81cba32..eceb4f7 100644 --- a/plugins/modules/hcloud_server.py +++ b/plugins/modules/hcloud_server.py @@ -548,7 +548,7 @@ class AnsibleHCloudServer(AnsibleHCloud): ) else: self.module.warn( - "Attention: The server plan % is deprecated and will no longer be available for order as of " + "Attention: The server plan %s is deprecated and will no longer be available for order as of " % server_type.name + "%s. Existing servers of that plan will continue to work as before " % server_type.deprecation.unavailable_after.strftime("%Y-%m-%d")