docs: add notes that dnf_* modules do not work with dnf5 (#10238)
* Add notes that dnf_* modules do not work with dnf5.
* Apply suggestions from code review.
---------
(cherry picked from commit 1956815884)
Co-authored-by: Alexei Znamensky <103110+russoz@users.noreply.github.com>
yaml callback: use new util introduced in ansible-core 2.19.0b2 (#10242)
* Avoid repeating some code.
* Use new utility added for ansible-core 2.19.0b2.
* Lint.
* Add changelog fragment.
* transform_to_native_types() does not convert map keys.
To catch all tagged strings, we have to recursively walk the data structure then.
* Add test with vaulted string.
(cherry picked from commit 66cb9aefb5)
Tests: adjust to ansible-core devel changes (#10209)
Apparently the error message returned by AnsibleModule.run_command() when trying to execute a non-existing executable changed.
Ref: 600c1e67b4
(cherry picked from commit 63add288dc)
Co-authored-by: Felix Fontein <felix@fontein.de>
Fix TypeError caused by giving more than 2 positional arguments to CobblerXMLRPCInterface.get_system_handle() (#10145)
* Update cobbler system module to also use new get_system_handle method definition
* Add changelog for bug fix for cobbler system module
(cherry picked from commit 3daa1dec0c)
Co-authored-by: umiruka <211638667+umiruka@users.noreply.github.com>
kdeconfig: mark end of options before sending value (#10128)
* mark end of options before sending value
* fix linting issue
* fragment update
(cherry picked from commit 626ee3115d)
Co-authored-by: Bob Mroczka <bob@mroczka.com>
rundeck_acl_policy: fix project acls are put/posted to the wrong endpoint (#10097)
* Fix project acls are put/posted to the wrong endpoint
* Add changelog fragment.
* Fix 2.7 sanity errors in github
* Fix fragment extension and use 2.7 syntax in test
* Update changelogs/fragments/10097-fix-rundeck_acl_policy-project-endpoint.yml
* Fix pep8 formatting
* Add licensing to unit test
---------
(cherry picked from commit ff0ed6f912)
Co-authored-by: kjoyce77 <kevin.joyce@outlook.com>
Co-authored-by: Felix Fontein <felix@fontein.de>
Allow running sanity and unit tests with antsibull-nox; impove testing documentation (#10104)
* Whitespace fixes.
* Allow to run unit and sanity tests with antsibull-nox.
* Document installation of needed collections for tests.
* Also mention other sanity tests.
(cherry picked from commit 6008e6e1a7)
Co-authored-by: Felix Fontein <felix@fontein.de>
Fix#10120. Split key=value where value may comprise = (#10121)
* Fix#10120. Split key=value where value may comprise =
* Added fragment.
* Update plugins/modules/sysrc.py
* Update changelogs/fragments/10121-sysrc-fix-split-first-separator.yml
---------
(cherry picked from commit de60ea1da4)
Co-authored-by: Vladimir Botka <vbotka@gmail.com>
Co-authored-by: Felix Fontein <felix@fontein.de>
lxc: fix unit tests (#10115)
Don't compare strings passed through set_option()/get_option() with 'is'.
(cherry picked from commit 86507e8aca)
Co-authored-by: Felix Fontein <felix@fontein.de>
CI: Use community.crypto 2.x.y for ansible-core 2.16 and before (#10086)
* Use community.crypto 2.x.y for ansible-core 2.16 and before.
* Also use stable-2 for ubuntu2004 tests.
(cherry picked from commit 60f1169d42)
Co-authored-by: Felix Fontein <felix@fontein.de>
crypttab: removes jijna delimiters from example using when (#10079)
The current example includes extra jinja delimiters which
result in double-interpretation of the statement.
Fixes: #10078
(cherry picked from commit 1936fe5181)
Signed-off-by: Abhijeet Kasurde <Akasurde@redhat.com>
Co-authored-by: Abhijeet Kasurde <akasurde@redhat.com>
Mark supervisorctl tests as unstable (#10057)
Mark supervisorctl tests as unstable.
(cherry picked from commit a720e99482)
Co-authored-by: Felix Fontein <felix@fontein.de>
Remove FreeBSD 14.0 from CI (#10051)
Remove FreeBSD 14.0 from CI.
In ansible-core it has been replaced with 14.1, but we're already testing against that.
Ref: 3546111f2d
(cherry picked from commit 4a2920b0fd)
Co-authored-by: Felix Fontein <felix@fontein.de>
* Remove blanket skips for Python 3 in CI (#10043)
* Remove blanket skips for Python 3 in CI.
* Try to fix hg tests.
* Disable hg tests.
* Drop restriction of supervisor to <4.0.0.
This was introduced in https://github.com/ansible/ansible/pull/54935.
* Make tests work with supervisorctl 4.0.0.
According to https://supervisord.org/changes.html#id12,
"supervisorctl will now set its exit code to a non-zero value when an error condition occurs."
I'm not sure why a stopped service in 'status' constitutes an error condition,
but whatever 🤷...
* Use correct Python executable.
* Skip RHEL/macOS; diff on config write.
* Skip CentOS 7 and OpenSuSE on ansible-core 2.16.
(cherry picked from commit 2a5abab738)
* Skip OpenSuSE 15/Python 2 on ansible-core 2.13.
---------
Co-authored-by: Felix Fontein <felix@fontein.de>
* Use antsibull-nox instead of extra sanity test runner and extra workflows (#10022)
* Use antsibull-nox instead of extra sanity test runner and extra workflows.
* Avoid sys.argv[0].
(cherry picked from commit 3ee55c6828)
* Action group keycloak does not exist in 9.x.y.
fix: github_deploy_key check key exists on 422 (#10011)
* fix: github_deploy_key check key exists on 422
If we get a 422 response code as we add a key, check if it's because the key already exists or for another reason.
fixes: #6718
* chore: add changelog 10011-github_deploy_key-check-key-present
* chore: fix changelog fragment
* chore: fix changelog fragment
* Update changelog fragment.
---------
Co-authored-by: Felix Fontein <felix@fontein.de>
(cherry picked from commit c248073079)
Co-authored-by: Alex Garel <alex@garel.org>
improve ansible_host in proxmox inventory plugin (#9952)
* improve ansible_host in proxmox inventory plugin
I had this issue myself and found out there was already an issue thread:
https://github.com/ansible-collections/community.general/issues/5906
this fixes the issue for hope we can all benefit after this gets merged
* f string styling
* add log line for the successful address selection
* remove white space
* add changelog: 9952-proxmox-inventory-plugin-improve-ansible_host.yml
* Update changelogs/fragments/9952-proxmox-inventory-plugin-improve-ansible_host.yml
Co-authored-by: Felix Fontein <felix@fontein.de>
---------
Co-authored-by: Felix Fontein <felix@fontein.de>
(cherry picked from commit 1243846c3a)
Co-authored-by: Stein van Broekhoven <stein@aapjeisbaas.nl>
Make ready for data tagging (#9833)
* Fix dependent lookup.
* Fix ansible_type plugin utils and adjust documentation of reveal_ansible_type filter and ansible_type test.
* Fix diy callback plugin.
* Adjust to Data Tagging.
* Vendor and use internal code from ansible-core to fix YAML callback.
Ref: https://github.com/ansible/ansible/issues/84781
(cherry picked from commit 04cfce78ea)
proxmox_disk: fail gracefully if storage hasn't been provided by the user (#9963)
Fail gracefully if storage hasn't been provided by the user.
(cherry picked from commit 34b6fb74eb)
Co-authored-by: Felix Fontein <felix@fontein.de>
