From f4b336a4444651731fe300142ff7d59baeb79046 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Lukas=20K=C3=A4mmerling?= Date: Fri, 16 Jul 2021 10:55:08 +0200 Subject: [PATCH] hcloud_volume: Force detaching volume on deletion (#95) Force detaching of volumes before deleting when they are still attached to a server. This makes it easier for tools like molecule to see the correct state. --- .../fragments/hcloud_volume-force-detach-before-deletion.yml | 2 ++ plugins/modules/hcloud_volume.py | 2 ++ 2 files changed, 4 insertions(+) create mode 100644 changelogs/fragments/hcloud_volume-force-detach-before-deletion.yml diff --git a/changelogs/fragments/hcloud_volume-force-detach-before-deletion.yml b/changelogs/fragments/hcloud_volume-force-detach-before-deletion.yml new file mode 100644 index 0000000..5a6b64e --- /dev/null +++ b/changelogs/fragments/hcloud_volume-force-detach-before-deletion.yml @@ -0,0 +1,2 @@ +bugfixes: + - hcloud_volume Force detaching of volumes on servers before deletion diff --git a/plugins/modules/hcloud_volume.py b/plugins/modules/hcloud_volume.py index a43fdbb..7cd796c 100644 --- a/plugins/modules/hcloud_volume.py +++ b/plugins/modules/hcloud_volume.py @@ -294,6 +294,8 @@ class AnsibleHcloudVolume(Hcloud): self._get_volume() if self.hcloud_volume is not None: if not self.module.check_mode: + if self.hcloud_volume.server is not None: + self.hcloud_volume.detach().wait_until_finished() self.client.volumes.delete(self.hcloud_volume) self._mark_as_changed() self.hcloud_volume = None