From e7f37fdece8d57fe27cf0c8cb48843c61e49259d Mon Sep 17 00:00:00 2001 From: jo Date: Tue, 3 Jun 2025 13:39:00 +0200 Subject: [PATCH] refactor: improve ssh_public_key_md5_fingerprint --- plugins/module_utils/ssh.py | 3 +++ tests/unit/module_utils/test_ssh.py | 4 ++++ 2 files changed, 7 insertions(+) diff --git a/plugins/module_utils/ssh.py b/plugins/module_utils/ssh.py index a38b570..c52d1eb 100644 --- a/plugins/module_utils/ssh.py +++ b/plugins/module_utils/ssh.py @@ -5,6 +5,9 @@ from hashlib import md5 def ssh_public_key_md5_fingerprint(value: str) -> str: + """ + Compute the md5 fingerprint of a SSH public key. + """ parts = value.strip().split() if len(parts) < 2: raise ValueError("invalid ssh public key") diff --git a/tests/unit/module_utils/test_ssh.py b/tests/unit/module_utils/test_ssh.py index 1954b82..2b3c8c5 100644 --- a/tests/unit/module_utils/test_ssh.py +++ b/tests/unit/module_utils/test_ssh.py @@ -13,6 +13,10 @@ from ansible_collections.hetzner.hcloud.plugins.module_utils.ssh import ( "ssh-ed25519 AAAAC3NzaC1lZDI1NTE5AAAAILNWUEdTk1oxrjUZ5erbKUmJM3VxQ9DLocgt/HFohCf6 comment", "ce:cf:37:b9:38:40:ad:80:b2:8b:2c:5c:83:b5:af:0b", ), + ( + "ssh-ed25519 AAAAC3NzaC1lZDI1NTE5AAAAILNWUEdTk1oxrjUZ5erbKUmJM3VxQ9DLocgt/HFohCf6", # No comment + "ce:cf:37:b9:38:40:ad:80:b2:8b:2c:5c:83:b5:af:0b", + ), ( "ecdsa-sha2-nistp521 AAAAE2VjZHNhLXNoYTItbmlzdHA1MjEAAAAIbmlzdHA1MjEAAACFBABOUmmgxbhhauMg97GMwHcjWXM35MwFmlSKx7klWpPr3jMbabGQzINFVXexgf6Tru0D5a7NU/Hkx9t2yOtqKHJOIQB5/NKktqYelul4X56WYV/64RSm6xIjcolNao9fUbawnIwh9mvaQQg5v1BiJfPJ6p6LcWPunzfm6DztU1tHwLtjTw== comment", # noqa: E501 "bf:61:7b:7f:ab:c7:af:25:aa:d7:d5:e8:5f:87:5c:66",