feat: Storage Box support no longer experimental (#793)

##### SUMMARY

Storage Box support is no longer experimental and the warnings can be
removed.


Closes #756

---------

Co-authored-by: jo <ljonas@riseup.net>

changelogs/fragments/storage-box-generally-available.yml

@@ -0,0 +1,11 @@
+release_summary: |
+  The experimental phase for Storage Boxes is over, and Storage Boxes support is now generally available.
+
+minor_changes:
+  - storage_box - The module is no longer marked as experimental.
+  - storage_box_info - The module is no longer marked as experimental.
+  - storage_box_snapshot - The module is no longer marked as experimental.
+  - storage_box_snapshot_info - The module is no longer marked as experimental.
+  - storage_box_subaccount - The module is no longer marked as experimental.
+  - storage_box_subaccount_info - The module is no longer marked as experimental.
+  - storage_box_type_info - The module is no longer marked as experimental.

plugins/module_utils/_experimental.py

@@ -35,10 +35,3 @@ def experimental_warning_function(product: str, maturity: str, url: str):
         module.warn(message)
 
     return fn
-
-
-storage_box_experimental_warning = experimental_warning_function(
-    "Storage Box support",
-    "experimental",
-    "https://github.com/ansible-collections/hetzner.hcloud/issues/756",
-)

plugins/modules/storage_box.py

@@ -15,8 +15,6 @@ short_description: Create and manage Storage Boxes in Hetzner.
 description:
     - Create, update and delete Storage Boxes in Hetzner.
     - See the L(Storage Boxes API documentation,https://docs.hetzner.cloud/reference/hetzner#storage-boxes) for more details.
-    - B(Experimental:) Storage Box support is experimental, breaking changes may occur within minor releases.
-      See https://github.com/ansible-collections/hetzner.hcloud/issues/756 for more details.
 
 author:
     - Jonas Lammler (@jooola)
@@ -346,7 +344,6 @@ hcloud_storage_box:
 from ..module_utils import _storage_box
 from ..module_utils._base import AnsibleHCloud, AnsibleModule
 from ..module_utils._client import client_resource_not_found
-from ..module_utils._experimental import storage_box_experimental_warning
 from ..module_utils._vendor.hcloud import HCloudException
 from ..module_utils._vendor.hcloud.locations import Location
 from ..module_utils._vendor.hcloud.storage_box_types import StorageBoxType
@@ -363,10 +360,6 @@ class AnsibleStorageBox(AnsibleHCloud):
 
     storage_box: BoundStorageBox | None = None
 
-    def __init__(self, module: AnsibleModule):
-        storage_box_experimental_warning(module)
-        super().__init__(module)
-
     def _prepare_result(self):
         if self.storage_box is not None:
             return _storage_box.prepare_result(self.storage_box)

plugins/modules/storage_box_info.py

@@ -15,8 +15,6 @@ short_description: Gather infos about Hetzner Storage Boxes.
 description:
     - Gather infos about Hetzner Storage Boxes.
     - See the L(Storage Boxes API documentation,https://docs.hetzner.cloud/reference/hetzner#storage-boxes) for more details.
-    - B(Experimental:) Storage Box support is experimental, breaking changes may occur within minor releases.
-      See https://github.com/ansible-collections/hetzner.hcloud/issues/756 for more details.
 
 author:
     - Jonas Lammler (@jooola)
@@ -187,7 +185,6 @@ from ansible.module_utils.basic import AnsibleModule
 
 from ..module_utils import _storage_box
 from ..module_utils._base import AnsibleHCloud
-from ..module_utils._experimental import storage_box_experimental_warning
 from ..module_utils._vendor.hcloud import HCloudException
 from ..module_utils._vendor.hcloud.storage_boxes import (
     BoundStorageBox,
@@ -199,10 +196,6 @@ class AnsibleStorageBox(AnsibleHCloud):
 
     storage_box: list[BoundStorageBox] | None = None
 
-    def __init__(self, module: AnsibleModule):
-        storage_box_experimental_warning(module)
-        super().__init__(module)
-
     def _prepare_result(self):
         result = []
         for o in self.storage_box or []:

plugins/modules/storage_box_snapshot.py

@@ -15,8 +15,6 @@ short_description: Create and manage Storage Box Snapshots in Hetzner.
 description:
     - Create, update and delete Storage Box Snapshots in Hetzner.
     - See the L(Storage Box Snapshots API documentation,https://docs.hetzner.cloud/reference/hetzner#storage-box-snapshots) for more details.
-    - B(Experimental:) Storage Box support is experimental, breaking changes may occur within minor releases.
-      See https://github.com/ansible-collections/hetzner.hcloud/issues/756 for more details.
 
 author:
     - Jonas Lammler (@jooola)
@@ -142,7 +140,6 @@ hcloud_storage_box_snapshot:
 
 from ..module_utils import _storage_box, _storage_box_snapshot
 from ..module_utils._base import AnsibleHCloud, AnsibleModule
-from ..module_utils._experimental import storage_box_experimental_warning
 from ..module_utils._vendor.hcloud import HCloudException
 from ..module_utils._vendor.hcloud.storage_boxes import (
     BoundStorageBox,
@@ -156,10 +153,6 @@ class AnsibleStorageBoxSnapshot(AnsibleHCloud):
     storage_box: BoundStorageBox | None = None
     storage_box_snapshot: BoundStorageBoxSnapshot | None = None
 
-    def __init__(self, module: AnsibleModule):
-        storage_box_experimental_warning(module)
-        super().__init__(module)
-
     def _prepare_result(self):
         if self.storage_box_snapshot is None:
             return {}

plugins/modules/storage_box_snapshot_info.py

@@ -15,8 +15,6 @@ short_description: Gather infos about Hetzner Storage Box Snapshots.
 description:
     - Gather infos about Hetzner Storage Box Snapshots.
     - See the L(Storage Boxes API documentation,https://docs.hetzner.cloud/reference/hetzner#storage-boxes) for more details.
-    - B(Experimental:) Storage Box support is experimental, breaking changes may occur within minor releases.
-      See https://github.com/ansible-collections/hetzner.hcloud/issues/756 for more details.
 
 author:
     - Jonas Lammler (@jooola)
@@ -136,7 +134,6 @@ hcloud_storage_box_snapshot_info:
 
 from ..module_utils import _storage_box, _storage_box_snapshot
 from ..module_utils._base import AnsibleHCloud, AnsibleModule
-from ..module_utils._experimental import storage_box_experimental_warning
 from ..module_utils._vendor.hcloud import HCloudException
 from ..module_utils._vendor.hcloud.storage_boxes import (
     BoundStorageBox,
@@ -150,10 +147,6 @@ class AnsibleStorageBoxSnapshotInfo(AnsibleHCloud):
     storage_box: BoundStorageBox | None = None
     storage_box_snapshots: list[BoundStorageBoxSnapshot] | None = None
 
-    def __init__(self, module: AnsibleModule):
-        storage_box_experimental_warning(module)
-        super().__init__(module)
-
     def _prepare_result(self):
         result = []
 

plugins/modules/storage_box_subaccount.py

@@ -15,8 +15,6 @@ short_description: Create and manage Storage Box Subaccounts in Hetzner.
 description:
     - Create, update and delete Storage Box Subaccounts in Hetzner.
     - See the L(Storage Box Subaccounts API documentation,https://docs.hetzner.cloud/reference/hetzner#storage-box-subaccounts) for more details.
-    - B(Experimental:) Storage Box support is experimental, breaking changes may occur within minor releases.
-      See https://github.com/ansible-collections/hetzner.hcloud/issues/756 for more details.
 
 author:
     - Jonas Lammler (@jooola)
@@ -225,7 +223,6 @@ hcloud_storage_box_subaccount:
 from ..module_utils import _storage_box, _storage_box_subaccount
 from ..module_utils._base import AnsibleHCloud, AnsibleModule
 from ..module_utils._client import client_resource_not_found
-from ..module_utils._experimental import storage_box_experimental_warning
 from ..module_utils._vendor.hcloud import HCloudException
 from ..module_utils._vendor.hcloud.storage_boxes import (
     BoundStorageBox,
@@ -240,10 +237,6 @@ class AnsibleStorageBoxSubaccount(AnsibleHCloud):
     storage_box: BoundStorageBox | None = None
     storage_box_subaccount: BoundStorageBoxSubaccount | None = None
 
-    def __init__(self, module: AnsibleModule):
-        storage_box_experimental_warning(module)
-        super().__init__(module)
-
     def _prepare_result(self):
         if self.storage_box_subaccount is None:
             return {}

plugins/modules/storage_box_subaccount_info.py

@@ -15,8 +15,6 @@ short_description: Gather infos about Hetzner Storage Box Subaccounts.
 description:
     - Gather infos about Hetzner Storage Box Subaccounts.
     - See the L(Storage Box Subaccounts API documentation,https://docs.hetzner.cloud/reference/hetzner#storage-box-subaccounts) for more details.
-    - B(Experimental:) Storage Box support is experimental, breaking changes may occur within minor releases.
-      See https://github.com/ansible-collections/hetzner.hcloud/issues/756 for more details.
 
 author:
     - Jonas Lammler (@jooola)
@@ -160,7 +158,6 @@ from ansible.module_utils.basic import AnsibleModule
 
 from ..module_utils import _storage_box, _storage_box_subaccount
 from ..module_utils._base import AnsibleHCloud
-from ..module_utils._experimental import storage_box_experimental_warning
 from ..module_utils._vendor.hcloud import HCloudException
 from ..module_utils._vendor.hcloud.storage_boxes import (
     BoundStorageBox,
@@ -174,10 +171,6 @@ class AnsibleStorageBoxSubaccountInfo(AnsibleHCloud):
     storage_box: BoundStorageBox | None = None
     storage_box_subaccounts: list[BoundStorageBoxSubaccount] | None = None
 
-    def __init__(self, module: AnsibleModule):
-        storage_box_experimental_warning(module)
-        super().__init__(module)
-
     def _prepare_result(self):
         result = []
 

plugins/modules/storage_box_type_info.py

@@ -15,8 +15,6 @@ short_description: Gather infos about Hetzner Storage Box Types.
 description:
     - Gather infos about available Hetzner Storage Box Types.
     - See the L(Storage Box Types documentation,https://docs.hetzner.cloud/reference/hetzner#storage-box-types) for more details.
-    - B(Experimental:) Storage Box support is experimental, breaking changes may occur within minor releases.
-      See https://github.com/ansible-collections/hetzner.hcloud/issues/756 for more details.
 
 author:
     - Jonas Lammler (@jooola)
@@ -111,7 +109,6 @@ hcloud_storage_box_type_info:
 from ansible.module_utils.basic import AnsibleModule
 
 from ..module_utils._base import AnsibleHCloud
-from ..module_utils._experimental import storage_box_experimental_warning
 from ..module_utils._vendor.hcloud import HCloudException
 from ..module_utils._vendor.hcloud.storage_box_types import BoundStorageBoxType
 
@@ -121,10 +118,6 @@ class AnsibleStorageBoxTypeInfo(AnsibleHCloud):
 
     storage_box_types: list[BoundStorageBoxType] | None = None
 
-    def __init__(self, module: AnsibleModule):
-        storage_box_experimental_warning(module)
-        super().__init__(module)
-
     def _prepare_result(self):
         result = []