ansible/hetzner.hcloud
1
0
Fork 0
mirror of https://github.com/ansible-collections/hetzner.hcloud.git synced 2026-02-04 08:01:49 +00:00
Code Activity

fix: zone rrset idempotency (#737)

Browse source 
##### SUMMARY

- The order of dns records is not guaranteed, this ensure the module is
idempotent.
- The API defaults to an empty string when comments are not set, ensure
the module is idempotent when no comments are given.

##### ISSUE TYPE

- Bugfix

Closes #740
This commit is contained in:
Jonas L. 2025-11-17 14:45:04 +01:00 • committed by GitHub
parent f87c23629b
commit 79f78fae28
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
4 changed files with 20 additions and 9 deletions
Download patch file Download diff file Expand all files Collapse all files

19
tests/integration/targets/zone_rrset/tasks/test.yml
View file

@ -91,6 +91,7 @@
key: changed
new: value
records:
- value: 201.118.10.10 # No comment
- value: 201.118.10.11
comment: web server 1
- value: 201.118.10.13
@ -107,11 +108,13 @@
- result.hcloud_zone_rrset.labels.key == "changed"
- result.hcloud_zone_rrset.labels.new == "value"
- result.hcloud_zone_rrset.change_protection == true
- result.hcloud_zone_rrset.records | count == 2
- result.hcloud_zone_rrset.records[0].value == "201.118.10.11"
- result.hcloud_zone_rrset.records[0].comment == "web server 1"
- result.hcloud_zone_rrset.records[1].value == "201.118.10.13"
- result.hcloud_zone_rrset.records[1].comment == "web server 3"
- result.hcloud_zone_rrset.records | count == 3
- result.hcloud_zone_rrset.records[0].value == "201.118.10.10"
- result.hcloud_zone_rrset.records[0].comment == ""
- result.hcloud_zone_rrset.records[1].value == "201.118.10.11"
- result.hcloud_zone_rrset.records[1].comment == "web server 1"
- result.hcloud_zone_rrset.records[2].value == "201.118.10.13"
- result.hcloud_zone_rrset.records[2].comment == "web server 3"
- name: Test update idempotency
hetzner.hcloud.zone_rrset:
@ -123,10 +126,12 @@
key: changed
new: value
records:
- value: 201.118.10.11
comment: web server 1
- value: 201.118.10.10 # No comment
# Order is not guaranteed, should still be idempotent
- value: 201.118.10.13
comment: web server 3
- value: 201.118.10.11
comment: web server 1
change_protection: true
register: result
- name: Verify update idempotency