From 60d9cf74a6d39c85e8e54f39cd0d9c04fa44d2a6 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Julian=20T=C3=B6lle?= Date: Wed, 8 Feb 2023 10:07:46 +0100 Subject: [PATCH] fix(server): server still locked after placement_group attach (#192) In some cases the server was still marked as locked after attaching it to a placement_group. This caused potential follow up tasks that use the server to fail. This happened because the action returned by `add_to_placement_group()` was not waited upon. For the detach case this is handled correctly. --- changelogs/fragments/server-race-condition-pg-attach.yml | 2 ++ plugins/modules/hcloud_server.py | 2 +- 2 files changed, 3 insertions(+), 1 deletion(-) create mode 100644 changelogs/fragments/server-race-condition-pg-attach.yml diff --git a/changelogs/fragments/server-race-condition-pg-attach.yml b/changelogs/fragments/server-race-condition-pg-attach.yml new file mode 100644 index 0000000..1c7ac87 --- /dev/null +++ b/changelogs/fragments/server-race-condition-pg-attach.yml @@ -0,0 +1,2 @@ +bugfixes: + - hcloud_server - Server locked after attaching to placement group diff --git a/plugins/modules/hcloud_server.py b/plugins/modules/hcloud_server.py index 247dd3a..246c624 100644 --- a/plugins/modules/hcloud_server.py +++ b/plugins/modules/hcloud_server.py @@ -652,7 +652,7 @@ class AnsibleHcloudServer(Hcloud): ): self.stop_server_if_forced() if not self.module.check_mode: - self.hcloud_server.add_to_placement_group(placement_group) + self.hcloud_server.add_to_placement_group(placement_group).wait_until_finished() self._mark_as_changed() if "ipv4" in self.module.params: