ansible/hetzner.hcloud
1
0
Fork 0
mirror of https://github.com/ansible-collections/hetzner.hcloud.git synced 2026-02-04 08:01:49 +00:00
Code Activity

feat: allow forcing the deletion of firewalls that are still in use (#447)

Browse source 
##### SUMMARY

  - Do not silence 'firewall still in use' deletions errors.
  - Allow forcing the deletion of a firewall that is still in use.

Fixes #380

##### ISSUE TYPE

- Feature Pull Request


##### COMPONENT NAME

firewall
This commit is contained in:
Jonas L 2024-02-02 09:48:56 +01:00 • committed by GitHub
parent 2757fe745f
commit 559d31561a
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
6 changed files with 62 additions and 7 deletions
Download patch file Download diff file Expand all files Collapse all files

31
plugins/modules/firewall.py
View file

@ -74,6 +74,11 @@ options:
type: list
elements: str
default: []
force:
description:
- Force the deletion of the Firewall when still in use.
type: bool
default: false
state:
description:
- State of the firewall.
@ -350,19 +355,32 @@ class AnsibleHCloudFirewall(AnsibleHCloud):
self._get_firewall()
if self.hcloud_firewall is not None:
if not self.module.check_mode:
if self.hcloud_firewall.applied_to:
if self.module.params.get("force"):
actions = self.hcloud_firewall.remove_from_resources(self.hcloud_firewall.applied_to)
for action in actions:
action.wait_until_finished()
else:
self.module.warn(
f"Firewall {self.hcloud_firewall.name} is currently used by "
"other resources. You need to unassign the resources before "
"deleting the Firewall or use force=true."
)
retry_count = 0
while retry_count < 10:
while True:
try:
self.client.firewalls.delete(self.hcloud_firewall)
self.hcloud_firewall.delete()
break
except APIException as exception:
if "is still in use" in exception.message:
retry_count = retry_count + 1
if "is still in use" in exception.message and retry_count < 10:
retry_count += 1
time.sleep(0.5 * retry_count)
else:
self.fail_json_hcloud(exception)
continue
self.fail_json_hcloud(exception)
except HCloudException as exception:
self.fail_json_hcloud(exception)
self._mark_as_changed()
self.hcloud_firewall = None
@ -390,6 +408,7 @@ class AnsibleHCloudFirewall(AnsibleHCloud):
["protocol", "tcp", ["port"]],
],
),
force={"type": "bool", "default": False},
state={
"choices": ["absent", "present"],
"default": "present",