From 25797122807a6273e957430f4acb7e4111fff2bf Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Lukas=20K=C3=A4mmerling?= Date: Mon, 7 Sep 2020 14:39:11 +0200 Subject: [PATCH] Allow setting Floating IP RDNS entries with hcloud_rdns MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Signed-off-by: Lukas Kämmerling --- plugins/modules/hcloud_rdns.py | 1 + tests/integration/targets/hcloud_rdns/tasks/main.yml | 8 ++++---- 2 files changed, 5 insertions(+), 4 deletions(-) diff --git a/plugins/modules/hcloud_rdns.py b/plugins/modules/hcloud_rdns.py index c288dc0..a419e02 100644 --- a/plugins/modules/hcloud_rdns.py +++ b/plugins/modules/hcloud_rdns.py @@ -200,6 +200,7 @@ class AnsibleHcloudReverseDNS(Hcloud): if not self.module.check_mode: self.hcloud_resource.change_dns_ptr(**params).wait_until_finished() + self.log("created rdns", type(self.hcloud_resource)) self._mark_as_changed() self._get_resource() self._get_rdns() diff --git a/tests/integration/targets/hcloud_rdns/tasks/main.yml b/tests/integration/targets/hcloud_rdns/tasks/main.yml index 12339ec..cfbe7c7 100644 --- a/tests/integration/targets/hcloud_rdns/tasks/main.yml +++ b/tests/integration/targets/hcloud_rdns/tasks/main.yml @@ -40,7 +40,7 @@ - name: test create rdns hcloud_rdns: server: "{{ hcloud_server_name }}" - ip_address: "{{ setup.hcloud_server.ipv6 | ansible.netcommon.ipaddr('next_usable') }}" + ip_address: "{{ setup.hcloud_server.ipv4_address }}" dns_ptr: "example.com" state: present register: rdns @@ -49,13 +49,13 @@ that: - rdns is changed - rdns.hcloud_rdns.server == "{{ hcloud_server_name }}" - - rdns.hcloud_rdns.ip_address == "{{ setup.hcloud_server.ipv6 | ansible.netcommon.ipaddr('next_usable') }}" + - rdns.hcloud_rdns.ip_address == "{{ setup.hcloud_server.ipv4_address }}" - rdns.hcloud_rdns.dns_ptr == "example.com" - name: test create rdns idempotency hcloud_rdns: server: "{{ hcloud_server_name }}" - ip_address: "{{ setup.hcloud_server.ipv6 | ansible.netcommon.ipaddr('next_usable') }}" + ip_address: "{{ setup.hcloud_server.ipv4_address }}" dns_ptr: "example.com" state: present register: result @@ -67,7 +67,7 @@ - name: test absent rdns hcloud_rdns: server: "{{ hcloud_server_name }}" - ip_address: "{{ setup.hcloud_server.ipv6 | ansible.netcommon.ipaddr('next_usable') }}" + ip_address: "{{ setup.hcloud_server.ipv4_address }}" state: absent register: result - name: verify test absent rdns