From 140d1508ccb8adb1d8fc2f64e446e993bfc02336 Mon Sep 17 00:00:00 2001
From: "Jonas L." <jooola@users.noreply.github.com>
Date: Fri, 21 Mar 2025 14:51:58 +0100
Subject: [PATCH] feat!: drop support for ansible-core 2.16 (#612)

##### SUMMARY

ansible-core 2.16 will be EOL in May 2025.


https://docs.ansible.com/ansible/devel/reference_appendices/release_and_maintenance.html#ansible-core-support-matrix

We are dropping support for ansible-core 2.16 alongside ansible-core
2.15 to prevent cutting another major release in the next month.
---
 .azure-pipelines/azure-pipelines.yml          | 34 -------------------
 .pre-commit-config.yaml                       |  2 +-
 .../drop-support-for-ansible-2.16.yml         |  2 ++
 meta/runtime.yml                              |  2 +-
 requirements.txt                              |  2 +-
 tests/sanity/ignore-2.16.txt                  |  1 -
 6 files changed, 5 insertions(+), 38 deletions(-)
 create mode 100644 changelogs/fragments/drop-support-for-ansible-2.16.yml
 delete mode 100644 tests/sanity/ignore-2.16.txt

diff --git a/.azure-pipelines/azure-pipelines.yml b/.azure-pipelines/azure-pipelines.yml
index 2805a6b..088282c 100644
--- a/.azure-pipelines/azure-pipelines.yml
+++ b/.azure-pipelines/azure-pipelines.yml
@@ -67,16 +67,6 @@ stages:
             - name: Sanity
               test: 2.17/sanity
 
-  - stage: Sanity_2_16
-    displayName: Sanity 2.16
-    dependsOn: []
-    jobs:
-      - template: templates/matrix.yml
-        parameters:
-          targets:
-            - name: Sanity
-              test: 2.16/sanity
-
   ### Units
   - stage: Units_devel
     displayName: Units devel
@@ -108,16 +98,6 @@ stages:
             - name: (py3.10)
               test: 2.17/units/3.10
 
-  - stage: Units_2_16
-    displayName: Units 2.16
-    dependsOn: []
-    jobs:
-      - template: templates/matrix.yml
-        parameters:
-          targets:
-            - name: (py3.10)
-              test: 2.16/units/3.10
-
   ## Integration
   - stage: Integration_devel
     displayName: Integration devel
@@ -152,29 +132,15 @@ stages:
             - name: (py3.10)
               test: 2.17/integration/3.10
 
-  - stage: Integration_2_16
-    displayName: Integration 2.16
-    dependsOn: []
-    jobs:
-      - template: templates/matrix.yml
-        parameters:
-          groups: [1, 2, 3]
-          targets:
-            - name: (py3.10)
-              test: 2.16/integration/3.10
-
   ### Finally
   - stage: Summary
     condition: succeededOrFailed()
     dependsOn:
       - Sanity_devel
       - Sanity_2_17
-      - Sanity_2_16
       - Units_devel
       - Units_2_17
-      - Units_2_16
       - Integration_devel
       - Integration_2_17
-      - Integration_2_16
     jobs:
       - template: templates/coverage.yml
diff --git a/.pre-commit-config.yaml b/.pre-commit-config.yaml
index 8e7d2bf..092a2d3 100644
--- a/.pre-commit-config.yaml
+++ b/.pre-commit-config.yaml
@@ -57,7 +57,7 @@ repos:
         entry: env HCLOUD_TOKEN= python3 -m ansiblelint -v --force-color
         args: [--offline]
         additional_dependencies:
-          - ansible-core>=2.16
+          - ansible-core>=2.17
           - netaddr
 
   - repo: local
diff --git a/changelogs/fragments/drop-support-for-ansible-2.16.yml b/changelogs/fragments/drop-support-for-ansible-2.16.yml
new file mode 100644
index 0000000..ac64a4b
--- /dev/null
+++ b/changelogs/fragments/drop-support-for-ansible-2.16.yml
@@ -0,0 +1,2 @@
+breaking_changes:
+  - Drop support for ansible-core 2.16.
diff --git a/meta/runtime.yml b/meta/runtime.yml
index 8b18444..b2dfe58 100644
--- a/meta/runtime.yml
+++ b/meta/runtime.yml
@@ -1,4 +1,4 @@
-requires_ansible: ">=2.16.0"
+requires_ansible: ">=2.17.0"
 
 action_groups:
   all:
diff --git a/requirements.txt b/requirements.txt
index 9b481d2..b9f41b0 100644
--- a/requirements.txt
+++ b/requirements.txt
@@ -1,4 +1,4 @@
-ansible-core>=2.16
+ansible-core>=2.17
 
 # Collections requirements
 netaddr
diff --git a/tests/sanity/ignore-2.16.txt b/tests/sanity/ignore-2.16.txt
deleted file mode 100644
index d6cabf4..0000000
--- a/tests/sanity/ignore-2.16.txt
+++ /dev/null
@@ -1 +0,0 @@
-plugins/inventory/hcloud.py yamllint:unparsable-with-libyaml # bug in ansible-test - https://github.com/ansible/ansible/issues/82353