fix: only rebuild existing servers, skip rebuild if it was just created (#581)

##### SUMMARY

Fixes #580

A freshly created server must not be rebuild.

##### ISSUE TYPE

- Bugfix Pull Request


##### COMPONENT NAME

server

changelogs/fragments/only-rebuild-existing-servers.yml

@@ -0,0 +1,2 @@
+bugfixes:
+  - hcloud_server - Only rebuild existing servers, skip rebuild if the server was just created.

plugins/modules/server.py

@@ -869,18 +869,25 @@ class AnsibleHCloudServer(AnsibleHCloud):
         return None
 
     def rebuild_server(self):
-        self.module.fail_on_missing_params(required_params=["image"])
+        self._get_server()
-        try:
+        if self.hcloud_server is None:
-            if not self.module.check_mode:
+            self._create_server()
-                image = self._get_image(self.hcloud_server.server_type)
+        else:
-                resp = self.client.servers.rebuild(self.hcloud_server, image)
+            self._update_server()
-                # When we rebuild the server progress takes some more time.
-                resp.action.wait_until_finished(max_retries=202)  # 202 retries >= 1002 seconds
-            self._mark_as_changed()
 
-            self._get_server()
+            # Only rebuild the server if it already existed.
-        except HCloudException as exception:
+            self.module.fail_on_missing_params(required_params=["image"])
-            self.fail_json_hcloud(exception)
+            try:
+                if not self.module.check_mode:
+                    image = self._get_image(self.hcloud_server.server_type)
+                    resp = self.client.servers.rebuild(self.hcloud_server, image)
+                    # When we rebuild the server progress takes some more time.
+                    resp.action.wait_until_finished(max_retries=202)  # 202 retries >= 1002 seconds
+                self._mark_as_changed()
+
+                self._get_server()
+            except HCloudException as exception:
+                self.fail_json_hcloud(exception)
 
     def present_server(self):
         self._get_server()
@@ -969,7 +976,6 @@ def main():
         hcloud.stop_server()
         hcloud.start_server()
     elif state == "rebuild":
-        hcloud.present_server()
         hcloud.rebuild_server()
 
     module.exit_json(**hcloud.get_result())