1
0
Fork 0
mirror of https://github.com/ansible-collections/community.general.git synced 2026-04-21 11:19:00 +00:00
community.general/plugins
Alexei Znamensky f8869af65f
homebrew_cask: fix sudo_password failing with special characters (#11850)
* homebrew_cask: fix sudo_password with special characters in password

The SUDO_ASKPASS script embedded the password inside single quotes, which
breaks shell parsing whenever the password contains a single quote. Use a
quoted heredoc (cat <<'SUDO_PASS') instead, which treats the content
completely literally regardless of special characters.

Also replace .file.close() with .flush() (correct semantics — flushes
the write buffer without leaving the NamedTemporaryFile in a half-closed
state) and remove the redundant add_cleanup_file() call (the context
manager already deletes the file on exit).

Fixes #4957

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

* homebrew_cask: add changelog fragment for #11850

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

* homebrew_cask: fix sudo_password example and clarify ansible_become_password

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

* homebrew_cask: use shlex.quote() for sudo_password instead of heredoc

shlex.quote() is the standard Python approach for shell-safe quoting
and handles all special characters without the edge cases of heredocs.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

---------

Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
2026-04-17 23:51:45 +12:00
..
action Sort imports with ruff check --fix (#11400) 2026-01-09 07:40:58 +01:00
become incus, machinectl, run0 - fix become over pty connections (#11771) 2026-04-15 17:47:09 +02:00
cache Sort imports with ruff check --fix (#11400) 2026-01-09 07:40:58 +01:00
callback counter_enabled callback: honor display_ok_hosts setting (#11656) 2026-03-23 19:57:48 +01:00
connection incus, machinectl, run0 - fix become over pty connections (#11771) 2026-04-15 17:47:09 +02:00
doc_fragments New module icinga2_downtime (#11462) 2026-02-23 05:38:54 +01:00
filter Add missing __future__ imports (#11567) 2026-03-11 06:42:08 +01:00
inventory fix: remove HTTPStatus constructs introduced in Python 3.11 (#11573) 2026-03-12 20:46:55 +01:00
lookup consul_kv: add ca_path option for custom CA certificate (#11817) 2026-04-17 08:40:59 +02:00
module_utils lvg - migrate to CmdRunner (#11835) 2026-04-17 08:54:11 +02:00
modules homebrew_cask: fix sudo_password failing with special characters (#11850) 2026-04-17 23:51:45 +12:00
plugin_utils Add missing __future__ imports (#11567) 2026-03-11 06:42:08 +01:00
test Sort imports with ruff check --fix (#11400) 2026-01-09 07:40:58 +01:00