mirror of
https://github.com/ansible-collections/community.general.git
synced 2026-02-04 16:01:55 +00:00
16f1d07509
Address issues reported by ruff check (#11043)
* Resolve E713 and E714 (not in/is tests).
* Address UP018 (unnecessary str call).
* UP045 requires Python 3.10+.
* Address UP007 (X | Y for type annotations).
* Address UP035 (import Callable from collections.abc).
* Address UP006 (t.Dict -> dict).
* Address UP009 (UTF-8 encoding comment).
* Address UP034 (extraneous parantheses).
* Address SIM910 (dict.get() with None default).
* Address F401 (unused import).
* Address UP020 (use builtin open).
* Address B009 and B010 (getattr/setattr with constant name).
* Address SIM300 (Yoda conditions).
* UP029 isn't in use anyway.
* Address FLY002 (static join).
* Address B034 (re.sub positional args).
* Address B020 (loop variable overrides input).
* Address B017 (assert raise Exception).
* Address SIM211 (if expression with false/true).
* Address SIM113 (enumerate for loop).
* Address UP036 (sys.version_info checks).
* Remove unnecessary UP039.
* Address SIM201 (not ==).
* Address SIM212 (if expr with twisted arms).
* Add changelog fragment.
* Reformat.
(cherry picked from commit 3478863ef0)
Co-authored-by: Felix Fontein <felix@fontein.de>
52 lines
2 KiB
Python
52 lines
2 KiB
Python
# (c) 2020, Alexei Znamensky <russoz@gmail.com>
|
|
# Copyright (c) 2020 Ansible Project
|
|
# GNU General Public License v3.0+ (see LICENSES/GPL-3.0-or-later.txt or https://www.gnu.org/licenses/gpl-3.0.txt)
|
|
# SPDX-License-Identifier: GPL-3.0-or-later
|
|
|
|
from __future__ import annotations
|
|
|
|
import pytest
|
|
|
|
from ansible_collections.community.general.plugins.module_utils.module_helper import cause_changes
|
|
|
|
|
|
#
|
|
# DEPRECATION NOTICE
|
|
# Parameters on_success and on_failure are deprecated and will be removed in community.general 12.0.0
|
|
# Remove testcases with those params when releasing 12.0.0
|
|
#
|
|
CAUSE_CHG_DECO_PARAMS = ["deco_args", "expect_exception", "expect_changed"]
|
|
CAUSE_CHG_DECO = dict(
|
|
none_succ=dict(deco_args={}, expect_exception=False, expect_changed=None),
|
|
none_fail=dict(deco_args={}, expect_exception=True, expect_changed=None),
|
|
whensucc_succ=dict(deco_args=dict(when="success"), expect_exception=False, expect_changed=True),
|
|
whensucc_fail=dict(deco_args=dict(when="success"), expect_exception=True, expect_changed=None),
|
|
whenfail_succ=dict(deco_args=dict(when="failure"), expect_exception=False, expect_changed=None),
|
|
whenfail_fail=dict(deco_args=dict(when="failure"), expect_exception=True, expect_changed=True),
|
|
whenalways_succ=dict(deco_args=dict(when="always"), expect_exception=False, expect_changed=True),
|
|
whenalways_fail=dict(deco_args=dict(when="always"), expect_exception=True, expect_changed=True),
|
|
)
|
|
CAUSE_CHG_DECO_IDS = sorted(CAUSE_CHG_DECO.keys())
|
|
|
|
|
|
@pytest.mark.parametrize(
|
|
CAUSE_CHG_DECO_PARAMS,
|
|
[[CAUSE_CHG_DECO[tc][param] for param in CAUSE_CHG_DECO_PARAMS] for tc in CAUSE_CHG_DECO_IDS],
|
|
ids=CAUSE_CHG_DECO_IDS,
|
|
)
|
|
def test_cause_changes_deco(deco_args, expect_exception, expect_changed):
|
|
class MockMH:
|
|
changed = None
|
|
|
|
@cause_changes(**deco_args)
|
|
def div_(self, x, y):
|
|
return x / y
|
|
|
|
mh = MockMH()
|
|
if expect_exception:
|
|
with pytest.raises(ZeroDivisionError):
|
|
mh.div_(1, 0)
|
|
else:
|
|
mh.div_(9, 3)
|
|
|
|
assert mh.changed == expect_changed
|