mirror of
https://github.com/ansible-collections/community.general.git
synced 2026-06-05 15:57:05 +00:00
f074ca9b05
snap: enforce hold when installing at a specific revision (#12097)
* snap: enforce hold when installing at a specific revision
When `revision` is specified, run `snap refresh --hold` after install/refresh
to actually pin the snap and prevent automatic updates from overriding it.
Detects hold-mismatch idempotently via the Notes column of `snap list`.
Fixes #12088
* feat(changelog): add fragment for snap hold fix (#12097)
* test(snap): remove incorrect manual-refresh assertion from hold test
snap refresh --hold only blocks the snapd auto-refresh daemon; a manual
snap refresh bypasses the hold. Remove the block that ran snap refresh
manually and asserted the revision was unchanged.
* snap: add bare-refresh hold test and docs warning for manual refresh bypass
---------
(cherry picked from commit 850ef03fe7)
Co-authored-by: Alexei Znamensky <103110+russoz@users.noreply.github.com>
Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
69 lines
2.5 KiB
Python
69 lines
2.5 KiB
Python
# Copyright (c) 2023, Alexei Znamensky <russoz@gmail.com>
|
|
# GNU General Public License v3.0+ (see LICENSES/GPL-3.0-or-later.txt or https://www.gnu.org/licenses/gpl-3.0.txt)
|
|
# SPDX-License-Identifier: GPL-3.0-or-later
|
|
|
|
# Note that this module util is **PRIVATE** to the collection. It can have breaking changes at any time.
|
|
# Do not use this from other collections or standalone plugins/modules!
|
|
|
|
from __future__ import annotations
|
|
|
|
import typing as t
|
|
|
|
from ansible_collections.community.general.plugins.module_utils._cmd_runner import CmdRunner, cmd_runner_fmt
|
|
|
|
if t.TYPE_CHECKING:
|
|
from ansible.module_utils.basic import AnsibleModule
|
|
|
|
|
|
_alias_state_map = dict(
|
|
present="alias",
|
|
absent="unalias",
|
|
info="aliases",
|
|
)
|
|
|
|
_state_map = dict(
|
|
present="install",
|
|
absent="remove",
|
|
enabled="enable",
|
|
disabled="disable",
|
|
refresh="refresh",
|
|
)
|
|
|
|
|
|
def snap_runner(module: AnsibleModule, **kwargs) -> CmdRunner:
|
|
runner = CmdRunner(
|
|
module,
|
|
"snap",
|
|
arg_formats=dict(
|
|
state_alias=cmd_runner_fmt.as_map(_alias_state_map), # snap_alias only
|
|
name=cmd_runner_fmt.as_list(),
|
|
alias=cmd_runner_fmt.as_list(), # snap_alias only
|
|
state=cmd_runner_fmt.as_map(_state_map),
|
|
_list=cmd_runner_fmt.as_fixed("list"),
|
|
_set=cmd_runner_fmt.as_fixed("set"),
|
|
get=cmd_runner_fmt.as_fixed(["get", "-d"]),
|
|
classic=cmd_runner_fmt.as_bool("--classic"),
|
|
channel=cmd_runner_fmt.as_func(lambda v: [] if v == "stable" else ["--channel", f"{v}"]),
|
|
options=cmd_runner_fmt.as_list(),
|
|
info=cmd_runner_fmt.as_fixed("info"),
|
|
revision=cmd_runner_fmt.as_opt_val("--revision"),
|
|
hold=cmd_runner_fmt.as_bool("--hold"),
|
|
unhold=cmd_runner_fmt.as_bool("--unhold"),
|
|
dangerous=cmd_runner_fmt.as_bool("--dangerous"),
|
|
devmode=cmd_runner_fmt.as_bool("--devmode"),
|
|
version=cmd_runner_fmt.as_fixed("version"),
|
|
_connect=cmd_runner_fmt.as_func(lambda v: ["connect", v]),
|
|
_disconnect=cmd_runner_fmt.as_func(lambda v: ["disconnect", v]),
|
|
_connections=cmd_runner_fmt.as_fixed("connections"),
|
|
slot=cmd_runner_fmt.as_list(),
|
|
),
|
|
check_rc=False,
|
|
**kwargs,
|
|
)
|
|
return runner
|
|
|
|
|
|
def get_version(runner: CmdRunner) -> dict[str, list[str]]:
|
|
with runner("version") as ctx:
|
|
rc, out, err = ctx.run()
|
|
return dict(x.split() for x in out.splitlines() if len(x.split()) == 2)
|