1
0
Fork 0
mirror of https://github.com/ansible-collections/community.general.git synced 2026-04-21 11:19:00 +00:00
community.general/plugins
Alexei Znamensky c4ed3467b6
homebrew_tap: fix None in command, redundant brew tap calls, format strings, and drop no-op locale vars (#11848)
* homebrew_tap: fix None in command list, redundant brew tap calls, and bad format strings

- Fix None being injected into the run_command list when url is not
  provided to add_tap (filter with [opt for opt in [...] if opt])
- Reduce redundant `brew tap` calls: add_taps and remove_taps now
  fetch the tap list once upfront and pass it to the per-tap functions;
  already_tapped accepts an optional pre-fetched list to avoid re-running
  brew for every tap in a batch
- Fix mixed f-string/%-formatting in error messages in add_taps and
  remove_taps, replaced with plain f-strings

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

* homebrew_tap: simplify command construction in add_tap

Replace the opaque list comprehension filter with an explicit conditional
append — only url is ever optional, so testing the known-present items
was misleading.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

* homebrew_tap: remove unnecessary locale env vars

Homebrew has no i18n/l10n support — all output is hardcoded English.
LANGUAGE=C and LC_ALL=C have no effect on brew output.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

* homebrew_tap: add changelog fragment for #11848

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

* remove hombrew_tap from PR #11783 changelog - change reverted here

---------

Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
2026-04-17 23:49:46 +12:00
..
action Sort imports with ruff check --fix (#11400) 2026-01-09 07:40:58 +01:00
become incus, machinectl, run0 - fix become over pty connections (#11771) 2026-04-15 17:47:09 +02:00
cache Sort imports with ruff check --fix (#11400) 2026-01-09 07:40:58 +01:00
callback counter_enabled callback: honor display_ok_hosts setting (#11656) 2026-03-23 19:57:48 +01:00
connection incus, machinectl, run0 - fix become over pty connections (#11771) 2026-04-15 17:47:09 +02:00
doc_fragments New module icinga2_downtime (#11462) 2026-02-23 05:38:54 +01:00
filter Add missing __future__ imports (#11567) 2026-03-11 06:42:08 +01:00
inventory fix: remove HTTPStatus constructs introduced in Python 3.11 (#11573) 2026-03-12 20:46:55 +01:00
lookup consul_kv: add ca_path option for custom CA certificate (#11817) 2026-04-17 08:40:59 +02:00
module_utils lvg - migrate to CmdRunner (#11835) 2026-04-17 08:54:11 +02:00
modules homebrew_tap: fix None in command, redundant brew tap calls, format strings, and drop no-op locale vars (#11848) 2026-04-17 23:49:46 +12:00
plugin_utils Add missing __future__ imports (#11567) 2026-03-11 06:42:08 +01:00
test Sort imports with ruff check --fix (#11400) 2026-01-09 07:40:58 +01:00