mirror of
https://github.com/ansible-collections/community.general.git
synced 2026-04-21 11:19:00 +00:00
2873d439c3
logrotate: fix parameter and config file validation and more (#11764)
* fix(logrotate): add missing defaults and parameter validation declarations
- Add default="present" to state parameter
- Add default="/etc/logrotate.d" to config_dir parameter
- Add required_by declarations for shred and compression parameters
* fix(logrotate): fix runtime validation bugs, remove duplicate checks
- Fix shred_cycles TypeError when value is None
- Fix enabled=None handling in get_config_path
- Remove duplicate runtime mutually_exclusive checks
- Add runtime boolean truthiness checks
- Add 'create' parameter format validation
- Remove stale test method
* fix(logrotate): restructure file operations, validate before write
- Write content to tmpdir temp file, validate, then atomic move to destination.
- Wrap all os.remove() calls in try/except with fail_json on error
- Wrap all module.atomic_move() calls in try/except with fail_json on error
- Also add self.mock_module.tmpdir = self.test_dir to test setUp for new code path
* docs(logrotate): update DOCUMENTATION block
- Add 'default: present' to state option
- Add 'default: /etc/logrotate.d' to config_dir option
* feat(logrotate): add optional backup parameter
* chore: add logrotate fixes changelog fragment
* chore(changelog/logrotate): use present tense singular
* fix(logrotate): handle trailing spaces in create param
* refactor(logrotate): remove redundant checks
These are already handled by `required_if` statements in the module spec
* refactor(logrotate): use tempfile to create temporary file
* refactor(logrotate): remove redundant `bool()` casts on `target_enabled`
`target_enabled` is guaranteed to be bool by this point. It's either the module param (typed bool) or falls back to `current_enabled` (also bool). The `bool()` wraps are no-ops.
* refactor(logrotate): remove unused `self.config_file` attribute
* refactor(logrotate): remove dead `any_state` parameter from `read_existing_config`
* fix(logrotate): raise error instead of falling through on enabled-state rename failures
* refactor(logrotate): tighten `get_config_path` sig to bool
`None` callers are removed now so this is safe
* test(logrotate): remove stale open mock assertion after tempfile refactor
* style(logrotate): format file
* chore(logrotate): add missing `version_added` attribute
* fix(logrotate): clean up temp file
* fix(logrotate): remove redundant temp file cleanup
* refactor(logrotate): Use dict subscript to access required backup param
* fix(logrotate): fix: only remove old config file when path differs from target
* fix(logrotate): update logrotate_bin type hint to str
* feat(logrotate): add backup file handling when removing old config
* style(logrotate): format file
* test(logrotate): add missing backup default to `_setup_module_params`
* test(logrotate): fix incorrect `os.remove` assertion in update test
* refactor(logrotate): remove unnecessary `to_native()` call
* refactor(logrotate): replace str quotes with !r
* fix(logrotate): change backup default back to true
* fix(logrotate): raise error when `shred_cycle`s is set with `shred=false`
* docs(logrotate): clarify `shred_cycles` behaviour
* fix(logrotate): remove to_native calls for exception messages
* docs(logrotate): improve `config_dir` param description
* refactor(logrotate): simplify backup file assignment logic
* style(logrotate): format file
* docs(logrotate): improve config_map description
---------
(cherry picked from commit
|
||
|---|---|---|
| .. | ||
| .keep | ||
| 12.6.0.yml | ||
| 8852-snmp-facts-pysnmp7.yml | ||
| 10786-jira-cloud-search.yml | ||
| 11487-ipa-host-fix-disable.yml | ||
| 11664-mssql-named-instance-port.yml | ||
| 11681-pacman-root-cachedir-config.yml | ||
| 11688-flatpak-fix-runtime-removal.yml | ||
| 11689-composer-create-project-idempotent.yml | ||
| 11698-ipa-failed-response.yml | ||
| 11717-fix-error-dnsttl.yml | ||
| 11721-xenserver-guest-codeqa.yml | ||
| 11728-opendj_backendprop-cmdrunner.yml | ||
| 11733-gem-cmd-runner.yml | ||
| 11738-run-command-locale-group3-batch1.yml | ||
| 11740-run-command-locale-group3-batch2.yml | ||
| 11741-run-command-locale-group3-batch3.yml | ||
| 11742-run-command-locale-nmcli.yml | ||
| 11748-flatpak-from-url.yml | ||
| 11753-java-cert-proxy-auth.yml | ||
| 11754-mssql-script-params-substitution.yml | ||
| 11764-logrotate-fixes.yml | ||
| 11765-group4-locale.yml | ||
| 11767-group4-batch2-locale.yml | ||
| 11768-group5-batch1-locale.yml | ||
| 11771-incus-machinectl-run0-become-pty.yml | ||
| 11772-dconf-dbus-broker.yml | ||
| 11773-group5-batch2-locale.yml | ||
| 11774-group5-batch3-locale.yml | ||
| 11775-group5-batch4-locale.yml | ||
| 11776-group5-batch5-locale.yml | ||
| 11777-group5-batch6-locale.yml | ||
| 11778-group5-batch7-locale.yml | ||
| 11779-group5-batch8-locale.yml | ||
| 11780-group5-batch9-locale.yml | ||
| 11781-group5-batch10-locale.yml | ||
| 11782-group5-batch11-locale.yml | ||
| 11783-group5-batch12-locale.yml | ||
| 11784-group5-batch13-locale.yml | ||
| 11785-group5-batch14-locale.yml | ||
| 11786-group5-batch15-locale.yml | ||
| 11787-group5-batch16-locale.yml | ||
| 11811-lvm_pv-use-cmdrunner.yml | ||
| 11823-lvol-lvm-version-regex.yml | ||
| 11825-iso-extract-leading-slash.yml | ||
| 11836-fixes.yml | ||
| 11837-iso-extract-umount-retry.yml | ||
| 11848-homebrew-tap-fixes.yml | ||
| 11850-homebrew-cask-sudo-password.yml | ||
| 11851-gitlab-project-members-ambiguous.yml | ||
| 11859-udm_user-param-name-fix.yml | ||
| 11861-etcd3-lookup-https.yml | ||
| fix-nsupdate-gss-tsig.yml | ||