Felix Fontein
396f467bbb
Improve Python code: address unused variables ( #11049 )
...
* Address F841 (unused variable).
* Reformat.
* Add changelog fragment.
* More cleanup.
* Remove trailing whitespace.
* Readd removed code as a comment with TODO.
2025-11-09 08:14:35 +01:00
Felix Fontein
3478863ef0
Address issues reported by ruff check ( #11043 )
...
* Resolve E713 and E714 (not in/is tests).
* Address UP018 (unnecessary str call).
* UP045 requires Python 3.10+.
* Address UP007 (X | Y for type annotations).
* Address UP035 (import Callable from collections.abc).
* Address UP006 (t.Dict -> dict).
* Address UP009 (UTF-8 encoding comment).
* Address UP034 (extraneous parantheses).
* Address SIM910 (dict.get() with None default).
* Address F401 (unused import).
* Address UP020 (use builtin open).
* Address B009 and B010 (getattr/setattr with constant name).
* Address SIM300 (Yoda conditions).
* UP029 isn't in use anyway.
* Address FLY002 (static join).
* Address B034 (re.sub positional args).
* Address B020 (loop variable overrides input).
* Address B017 (assert raise Exception).
* Address SIM211 (if expression with false/true).
* Address SIM113 (enumerate for loop).
* Address UP036 (sys.version_info checks).
* Remove unnecessary UP039.
* Address SIM201 (not ==).
* Address SIM212 (if expr with twisted arms).
* Add changelog fragment.
* Reformat.
2025-11-08 17:05:21 +13:00
Felix Fontein
340ff8586d
Reformat everything.
2025-11-01 13:46:53 +01:00
Alexei Znamensky
749c06cd01
modules [no]*: use f-strings ( #10973 )
...
* modules [no]*: use f-strings
* add changelog frag
2025-10-26 07:48:10 +01:00
Felix Fontein
8f8a0e1d7c
Fix __future__ imports, __metaclass__ = type, and remove explicit UTF-8 encoding statement for Python files ( #10886 )
...
* Adjust all __future__ imports:
for i in $(grep -REl "__future__.*absolute_import" plugins/ tests/); do
sed -e 's/from __future__ import .*/from __future__ import annotations/g' -i $i;
done
* Remove all UTF-8 encoding specifications for Python source files:
for i in $(grep -REl '[-][*]- coding: utf-8 -[*]-' plugins/ tests/); do
sed -e '/^# -\*- coding: utf-8 -\*-/d' -i $i;
done
* Remove __metaclass__ = type:
for i in $(grep -REl '__metaclass__ = type' plugins/ tests/); do
sed -e '/^__metaclass__ = type/d' -i $i;
done
2025-10-10 19:52:04 +02:00
Alexei Znamensky
cb84fa740a
remove extra brackets when params are a given by a comprehension ( #10712 )
...
* remove extra brackets when function params are a given by a comprehension
* add changelog frag
2025-08-23 19:14:39 +02:00
Alexei Znamensky
6d67546902
doc style adjustments: modules [no]* ( #10443 )
...
* doc style adjustments: modules n*
* doc style adjustments: modules o*
* Apply suggestions from code review
* Apply suggestions from code review
Co-authored-by: Felix Fontein <felix@fontein.de>
---------
Co-authored-by: Felix Fontein <felix@fontein.de>
2025-07-25 08:52:01 +02:00
Tom Paine
5ef6f1ebd2
Update one_vm.py ( #9959 )
...
* Update one_vm.py
Update updateconf attributes to match latest acceptable values.
* Add changelog fragment
* Update plugins/modules/one_vm.py
Co-authored-by: Nicola Soranzo <nicola.soranzo@gmail.com>
* Update plugins/modules/one_vm.py
Co-authored-by: Felix Fontein <felix@fontein.de>
* Update changelogs/fragments/9959-update-opennebula-onevm-updateconf-params.yml
Co-authored-by: Felix Fontein <felix@fontein.de>
* Update one_vm.py
Add updateconf values to documentation
* Update one_vm.py
* Update one_vm.py
* Update one_vm.py
* Update one_vm.py
Fix doc formatting
* Update plugins/modules/one_vm.py
Co-authored-by: Felix Fontein <felix@fontein.de>
* Update one_vm.py
Colon causing test failure
* Add colon.
---------
Co-authored-by: Nicola Soranzo <nicola.soranzo@gmail.com>
Co-authored-by: Felix Fontein <felix@fontein.de>
2025-04-19 09:26:06 +02:00
Alexei Znamensky
d325cfc343
o*: style adjustments ( #9526 )
...
* o*: style adjustments
* apply recommendations from review
* Update plugins/modules/one_vm.py
* fix example
* adjustment from review
* Update plugins/modules/one_vm.py
Co-authored-by: Felix Fontein <felix@fontein.de>
---------
Co-authored-by: Felix Fontein <felix@fontein.de>
2025-01-12 13:03:26 +01:00
Felix Fontein
ec585392e5
Docs: fix its vs. it's ( #9442 )
...
* Fix its vs. it's.
* Improvements from review.
Co-authored-by: Alexei Znamensky <103110+russoz@users.noreply.github.com>
* Improve formulations.
Co-authored-by: Alexei Znamensky <103110+russoz@users.noreply.github.com>
---------
Co-authored-by: Alexei Znamensky <103110+russoz@users.noreply.github.com>
2024-12-29 13:29:58 +01:00
Alexei Znamensky
88330575ff
[oc ... onep]*.py: normalize docs ( #9382 )
...
* [oc ... onep]*.py: normalize docs
* Apply suggestions from code review
Co-authored-by: Felix Fontein <felix@fontein.de>
---------
Co-authored-by: Felix Fontein <felix@fontein.de>
2024-12-26 13:44:29 +01:00
Alexei Znamensky
ecc048bc12
Use dict comprehension in plugins ( #8814 )
...
* use dict comprehension in plugins
* Apply suggestions from code review
* add changelog frag
* fix references in changelog frag
2024-09-01 20:22:53 +02:00
Alex
e556abb56b
Many typo fixes ( #7429 )
2023-10-25 23:01:32 +02:00
Felix Fontein
45eb1e3915
Use semantic markup (modules o-p) ( #6681 )
...
* Use semantic markup.
* Use real option, not alias.
* E() now works better.
2023-06-15 15:48:17 +02:00
Felix Fontein
ed79a68553
Add attributes to atomic, memset, one, oneview, packet, proxmox, and xenserver modules ( #5958 )
...
Add attributes to atomic, memset, one, oneview, packet, proxmox, and xenserver modules.
2023-02-20 17:27:38 +01:00
Michal Opala
8818a6f242
OpenNebula/one_vm implement the one.vm.updateconf API call ( #5812 )
...
* opennebula: Add template manipulation helpers
* one_vm: Use 'updateconf' API call to modify running VMs
* one_vm: Emulate 'updateconf' API call for newly created VMs
* opennebula/one_vm: Satisfy linter checks
* opennebula/one_vm: Apply suggestions from code review
Co-authored-by: Alexei Znamensky <103110+russoz@users.noreply.github.com>
* opennebula/one_vm: Drop 'extend' function, use 'dict_merge' instead
* Add changelog fragment
* one_vm: Refactor 'parse_updateconf' function
* opennebula/one_vm: Apply suggestions from code review
Co-authored-by: Felix Fontein <felix@fontein.de>
* one_vm: Allow for using updateconf in all scenarios
---------
Co-authored-by: Alexei Znamensky <103110+russoz@users.noreply.github.com>
Co-authored-by: Felix Fontein <felix@fontein.de>
2023-01-28 11:29:00 +01:00
wh1t3 r4bb1t
621fb6a619
one_vm: fix for 'NoneType' object has no attribute 'split' in get_vm_labels_and_attributes_dict ( #5489 )
...
* Fix for 'NoneType' object has no attribute 'split'
* Added changelog to fix
* Update changelogs/fragments/5489-nonetype-in-get-vm-by-label.yml
Co-authored-by: Felix Fontein <felix@fontein.de>
* Fix line ending in changelog
Co-authored-by: Felix Fontein <felix@fontein.de>
2022-11-08 23:00:05 +01:00
Felix Fontein
8de0221ae6
Convert copyright docstings to proper copyright comments ( #5480 )
...
* Drop stable-3 from weekly CI; migrate stable-4 from nightly to weekly.
* Convert copyright docstings to proper copyright comments.
2022-11-06 20:28:56 +01:00
Felix Fontein
b531ecdc9b
Unflatmap community.general ( #5461 )
...
* Move files.
* Update imports and references.
* Move wrongly placed files.
* Reverse redirects, deprecate long → short name redirects.
* Simplify contribution guidelines for new modules.
* Rewrite BOTMETA.
* Add changelog fragment.
* Fix ignore.txt files.
2022-11-02 20:42:29 +00:00
Felix Fontein
7743ecd776
Replace symlinks with meta/runtime.yml redirects. ( #4562 )
2022-04-26 20:33:13 +02:00
Brian Coca
8f90360d49
make collection usable with current ansible vers ( #9 )
2020-03-11 14:10:38 +00:00
