Properly handle proxmox_snap timeout parameter (#10176)
* fix: issue #10175
There is some code to handle timeout, but due to an erroneous while
test, it was never called. Use timeout >= 0 instead of timeout, so the
timeout code can be called, and properly handle timeout.
* add changelog
* Adjust changelog fragment.
---------
(cherry picked from commit 41f8e0bad6)
Co-authored-by: GuillaumeV-cemea <101114641+GuillaumeV-cemea@users.noreply.github.com>
Co-authored-by: Felix Fontein <felix@fontein.de>
Tests: adjust to ansible-core devel changes (#10209)
Apparently the error message returned by AnsibleModule.run_command() when trying to execute a non-existing executable changed.
Ref: 600c1e67b4
(cherry picked from commit 63add288dc)
Co-authored-by: Felix Fontein <felix@fontein.de>
gitlab_*_access_token: handle `revoked` field in group and project access tokens (#10196)
fix(gitlab): handle `revoked` field in group and project access tokens
(cherry picked from commit b86e4af103)
Co-authored-by: Massimo Gengarelli <massimo.gengarelli@proton.me>
* Use StrictVersion class to avoid wrong version comparisons that happen in some cases using LooseVersion class
* Refactor code
* Add changelog for PR number 10178
* Update changelog to be more precise
* Use LooseVersion instead of StrictVersion to check cobbler's version in cobbler system module
* Update PR 10178 changelog description to be more accurate
Feat: Add callback plugin print_task (#10087)
* Feat: Add callback plugin print_task
Prints task snippet to job output.
* Fix for failing tests
* Fix some pep8 formatting issues
* Updating DOCUMENTATION variable with version_added
* Set correct CALLBACK_NAME and fix warning with gather_facts
* Fix formatting again
* Update plugins/callback/print_task.py
* Update plugins/callback/print_task.py
* Add entry to BOTMETA.yml
* Use CSafeLoader and fallback to SafeLoader
* Change output function to self._display.display()
* Adding tests for community.general.print_task
* Adding EXAMPLES
* Apply suggestions from code review
---------
(cherry picked from commit b861850e1a)
Co-authored-by: Max Mitschke <demonpig@fastmail.com>
Co-authored-by: Felix Fontein <felix@fontein.de>
Fix TypeError caused by giving more than 2 positional arguments to CobblerXMLRPCInterface.get_system_handle() (#10145)
* Update cobbler system module to also use new get_system_handle method definition
* Add changelog for bug fix for cobbler system module
(cherry picked from commit 3daa1dec0c)
Co-authored-by: umiruka <211638667+umiruka@users.noreply.github.com>
proxmox: fix: cannot access local variable 'identifier' where it is not associated with a value (#10155)
* fix: cannot access local variable 'identifier' where it is not associated with a value
* Add changelog fragment.
---------
(cherry picked from commit 786be88f43)
Co-authored-by: Felix Fontein <felix@fontein.de>
Co-authored-by: Louis Jannett <louisjannett@icloud.com>
Allow running sanity and unit tests with antsibull-nox; impove testing documentation (#10104)
* Whitespace fixes.
* Allow to run unit and sanity tests with antsibull-nox.
* Document installation of needed collections for tests.
* Also mention other sanity tests.
(cherry picked from commit 6008e6e1a7)
Co-authored-by: Felix Fontein <felix@fontein.de>
rundeck_acl_policy: fix project acls are put/posted to the wrong endpoint (#10097)
* Fix project acls are put/posted to the wrong endpoint
* Add changelog fragment.
* Fix 2.7 sanity errors in github
* Fix fragment extension and use 2.7 syntax in test
* Update changelogs/fragments/10097-fix-rundeck_acl_policy-project-endpoint.yml
* Fix pep8 formatting
* Add licensing to unit test
---------
(cherry picked from commit ff0ed6f912)
Co-authored-by: kjoyce77 <kevin.joyce@outlook.com>
Co-authored-by: Felix Fontein <felix@fontein.de>
kdeconfig: mark end of options before sending value (#10128)
* mark end of options before sending value
* fix linting issue
* fragment update
(cherry picked from commit 626ee3115d)
Co-authored-by: Bob Mroczka <bob@mroczka.com>
pipx: accept python version specs in parameter `name` (#10031)
* pipx: accept python version specs in parameter "name"
* pipx_info: adjustment for backward compatibility
* remove unnecessary comprehension
* remove f-str
* no shebang for module utils
* remove f-str
* fix syntax error
* fix pipx_info
* rollback adjustments in existing tests
* docs & test update
* add debugging tasks to int test
* integration test checks for version of packaging
* move assertion to block
* fix idempotency when using version specifier
* add changelog frag
* fix docs
* dial down the version of tox used in tests
To accommodate old Pythons
* Update plugins/modules/pipx.py
* Apply suggestions from code review
* refactor/rename package requirements code
* fix filename in BOTMETA
* Update plugins/modules/pipx.py
* Update plugins/modules/pipx.py
* pipx mod utils: create make_process_dict and deprecate make_process_list
* pkg_req: make method private
* make_process_dict is simpler and more specialized
* ensure version specifiers are honored when state=install
* fix insanity
* pipx: reformat yaml blocks
* pipx: doc wordsmithing
---------
(cherry picked from commit 2b4cb6dabc)
Co-authored-by: Alexei Znamensky <103110+russoz@users.noreply.github.com>
Co-authored-by: Felix Fontein <felix@fontein.de>
Fix#10120. Split key=value where value may comprise = (#10121)
* Fix#10120. Split key=value where value may comprise =
* Added fragment.
* Update plugins/modules/sysrc.py
* Update changelogs/fragments/10121-sysrc-fix-split-first-separator.yml
---------
(cherry picked from commit de60ea1da4)
Co-authored-by: Vladimir Botka <vbotka@gmail.com>
Co-authored-by: Felix Fontein <felix@fontein.de>
lxc: fix unit tests (#10115)
Don't compare strings passed through set_option()/get_option() with 'is'.
(cherry picked from commit 86507e8aca)
Co-authored-by: Felix Fontein <felix@fontein.de>
antsibull-nox: use community.crypto 2.x.y for ansible-core < 2.17 (#10106)
Use community.crypto 2.x.y for ansible-core < 2.17.
(cherry picked from commit 94acd18052)
Co-authored-by: Felix Fontein <felix@fontein.de>
CI: Use community.crypto 2.x.y for ansible-core 2.16 and before (#10086)
* Use community.crypto 2.x.y for ansible-core 2.16 and before.
* Also use stable-2 for ubuntu2004 tests.
(cherry picked from commit 60f1169d42)
Co-authored-by: Felix Fontein <felix@fontein.de>
nmcli: fix misspelled option in example (#10075)
Fix misspelled option.
(cherry picked from commit d89a0bbc0e)
Co-authored-by: Felix Fontein <felix@fontein.de>
crypttab: removes jijna delimiters from example using when (#10079)
The current example includes extra jinja delimiters which
result in double-interpretation of the statement.
Fixes: #10078
(cherry picked from commit 1936fe5181)
Signed-off-by: Abhijeet Kasurde <Akasurde@redhat.com>
Co-authored-by: Abhijeet Kasurde <akasurde@redhat.com>
cobbler.inventory: Allow collecting fully rendered facts (#9975)
Add facts_level option to cobbler inventory plugin, cleanpu
Initialize connection in parse()
Handle rendered system data in _get_systems() so it can be cached
(cherry picked from commit 7524e74bb7)
Signed-off-by: Orion Poplawski <orion@nwra.com>
Co-authored-by: Orion Poplawski <orion@nwra.com>
Co-authored-by: Tyler Phillippe <tylerphillippe@tutamail.com>
Add xdg_mime module (#10007)
* Add version of xdg_mime module
* Fix xdg_mime_get since the command is different
* Add query parameter
* Fix order of parameters
* Add myself to BOTMETA
* Add unit tests
* Fix the way we deal when there is no handler set
* Improve documentation
* Remove unused import
* Fix documentation
* Strip xdg-mime from version string
* Fix information about version
* Add error message sample
* Add test to invalid handler
* Add support to multiple mime-types
* Change the output parameter from handlers to handler
* Change tests related to multiple mime-type support
* Small fixes
* Stop using constant to enable changed state
* Add before_handlers and after_handlers
* Change tests to use before and after structures
* Add a stronger message about using a non-installed handler
* Manage some edge cases
* Change error message to match the new value
* Add some fixes
* Change some tests
* Update plugins/modules/xdg_mime.py
* Remove a blank line
* Remove single quote
* Add xdg-mime to the version in the mocks
* Remove after_handlers and make code simpler
* Update tests to work without after_handlers
* Remove diff_params and clean output_params
* Make mime_type plural since it supports multiple items
* Move the handler check to module init
* Use anchors in the test to make yaml simpler
* Update plugins/modules/xdg_mime.py
* Update plugins/modules/xdg_mime.py
* Update plugins/modules/xdg_mime.py
* Update plugins/modules/xdg_mime.py
* Update plugins/modules/xdg_mime.py
* Update plugins/modules/xdg_mime.py
* Update plugins/modules/xdg_mime.py
* Update plugins/modules/xdg_mime.py
* Update plugins/modules/xdg_mime.py
* Update plugins/modules/xdg_mime.py
* Add blank line to separe examples
* Update plugins/modules/xdg_mime.py
* Add a small homage to my late grandma
* Update plugins/modules/xdg_mime.py
* Fix pep8 problem with the homage
* Remove trailing whitespace
* Update plugins/modules/xdg_mime.py
---------
(cherry picked from commit 373334d668)
Co-authored-by: Marcos Alano <mhalano@users.noreply.github.com>
Co-authored-by: Alexei Znamensky <103110+russoz@users.noreply.github.com>
Co-authored-by: Felix Fontein <felix@fontein.de>
Mark supervisorctl tests as unstable (#10057)
Mark supervisorctl tests as unstable.
(cherry picked from commit a720e99482)
Co-authored-by: Felix Fontein <felix@fontein.de>
Remove FreeBSD 14.0 from CI (#10051)
Remove FreeBSD 14.0 from CI.
In ansible-core it has been replaced with 14.1, but we're already testing against that.
Ref: 3546111f2d
(cherry picked from commit 4a2920b0fd)
Co-authored-by: Felix Fontein <felix@fontein.de>
