ansible/community.general
1
0
Fork 0
mirror of https://github.com/ansible-collections/community.general.git synced 2026-02-04 07:51:50 +00:00
Code Activity
3983 commits 14 branches 222 tags 315 MiB
Commit graph

2309 commits

Author SHA1 Message Date
Alexei Znamensky
862fe79a22
fix ruff case SIM110 (#11215) 
* fix ruff case SIM110

* Update plugins/module_utils/xenserver.py

Co-authored-by: Felix Fontein <felix@fontein.de>

* add changelog frag

---------

Co-authored-by: Felix Fontein <felix@fontein.de>
 2025-11-26 09:47:50 +13:00
Michael Galati
ebb534166e
mas: Fix parsing on mas 3.0.0+. (#11179) 
* mas: Fix parsing on mas 3.0.0+.

`mas` changed the formatting of `mas list` with version 3, which breaks
the parsing this module uses to determine which apps are installed.  In
particular, app IDs may now have leading space, which causes us to split
the string too early.

* Changelog fragment.

* Better format examples and changlog fragment.
 2025-11-24 21:32:16 +01:00
Alexei Znamensky
f2731e1dac
onepassword_info: replace subprocess.Popen() with run_command() (#11193) 
* onepassword_info: replace subprocess.Popen() with run_command()

* add changelog frag

* Update plugins/modules/onepassword_info.py

Co-authored-by: Felix Fontein <felix@fontein.de>

---------

Co-authored-by: Felix Fontein <felix@fontein.de>
 2025-11-25 09:11:24 +13:00
Alexei Znamensky
64dc009ea7
solaris_zone: replace os.system() with run_command() (#11192) 
* solaris_zone: replace os.system() with run_command()

* add changelog frag
 2025-11-25 09:07:25 +13:00
Alexei Znamensky
7321ba4990
snmp_facts: improvements (#11148) 
* snmp_facts: improvements

* require level if vesion=v3
 2025-11-23 13:17:11 +01:00
Alexei Znamensky
1c678f5c07
fix ruff case UP030 (#11189) 
* fix ruff case UP030

* add changelog frag

* formatting

* suggestion from review
 2025-11-23 08:37:41 +01:00
Alexei Znamensky
4517b86ed4
snmp_facts: update docs with dependency constraint (#11185) 2025-11-22 18:46:58 +13:00
Shahar Golshani
af99cc7deb
Add New Module file_remove (#11032) 
* Add New Module file_remove

* Add fixes from code review

* Change file_type documentation

* Remove python to_native from the module

* Remove redundant block/always cleanup

* Update plugins/modules/file_remove.py

Co-authored-by: Felix Fontein <felix@fontein.de>

* Update plugins/modules/file_remove.py

Co-authored-by: Felix Fontein <felix@fontein.de>

* Update plugins/modules/file_remove.py

Co-authored-by: Felix Fontein <felix@fontein.de>

* Update plugins/modules/file_remove.py

Co-authored-by: Felix Fontein <felix@fontein.de>

* Update plugins/modules/file_remove.py

Co-authored-by: Felix Fontein <felix@fontein.de>

* Update plugins/modules/file_remove.py

Co-authored-by: Felix Fontein <felix@fontein.de>

* Update plugins/modules/file_remove.py

Co-authored-by: Felix Fontein <felix@fontein.de>

* Update plugins/modules/file_remove.py

Co-authored-by: Felix Fontein <felix@fontein.de>

* Add more nox fixes to latest review

* Update plugins/modules/file_remove.py

LGTM

Co-authored-by: Felix Fontein <felix@fontein.de>

* Update tests/integration/targets/file_remove/tasks/main.yml

Right, that's better.

Co-authored-by: Felix Fontein <felix@fontein.de>

* Fix EXAMPLES regex pattern

* Add warning when listed file was removed by other process during
playbook execution

* remove raise exception from find_matching_files;

* Update plugins/modules/file_remove.py

Co-authored-by: Felix Fontein <felix@fontein.de>

* Update plugins/modules/file_remove.py

Co-authored-by: Felix Fontein <felix@fontein.de>

---------

Co-authored-by: Felix Fontein <felix@fontein.de>
 2025-11-21 18:26:30 +01:00
Felix Fontein
e57de70c2a
Address UP014: use NamedTuple class syntax (#11168) 
* Address UP014: use NamedTuple class syntax.

* Convert type comments to type hints.
 2025-11-21 18:19:36 +01:00
John Barker
d98df2d3a5
docs: migrate RTD URLs to docs.ansible.com (#11109) 
* docs: update readthedocs.io URLs to docs.ansible.com equivalents

🤖 Generated with Claude Code
https://claude.ai/code

Co-Authored-By: Claude <noreply@anthropic.com>

* Adjust favicon URL.

Co-authored-by: Don Naro <dnaro@redhat.com>

---------

Co-authored-by: Claude <noreply@anthropic.com>
Co-authored-by: Felix Fontein <felix@fontein.de>
Co-authored-by: Don Naro <dnaro@redhat.com>
 2025-11-19 07:00:51 +01:00
Alexei Znamensky
79b16d9ca5
fix return value exception (#11149) 
* fix return value `exception`

* add changelog frag

* adjustments after review

* typo

* adjust changelog frag

* vmadm: send rc, stdout, and stderr to fail_json()

* rundeck: pass tracebacks

* Update changelogs/fragments/11149-rv-exception.yml

Co-authored-by: Felix Fontein <felix@fontein.de>

* Update changelogs/fragments/11149-rv-exception.yml

Co-authored-by: Felix Fontein <felix@fontein.de>

---------

Co-authored-by: Felix Fontein <felix@fontein.de>
 2025-11-18 20:07:26 +13:00
Alexei Znamensky
a986d81c3d
dconf: doc typo (#11169) 2025-11-17 06:46:04 +01:00
Alexei Znamensky
23e81b8d30
replace redundant to_native()/to_text() occurrences, batch 8 (#11143) 
* replace redundant to_native()/to_text() occurrences, batch 8

* add changelog frag

* Update plugins/modules/jira.py

Co-authored-by: Felix Fontein <felix@fontein.de>

---------

Co-authored-by: Felix Fontein <felix@fontein.de>
 2025-11-16 11:18:17 +13:00
Alexei Znamensky
98aca27a8b
locale_gen: search for available locales in /usr/local as well (#11046) 
* locale_gen: search for available locales in /usr/local as well

* better var name

* add test for /usr/local

* Apply suggestions from code review

Co-authored-by: Felix Fontein <felix@fontein.de>

* skip /usr/local/ for Archlinux

* improve/update documentation

* add license file for the custom locale

* add changelog frag

* Update plugins/modules/locale_gen.py

Co-authored-by: Felix Fontein <felix@fontein.de>

* Update changelogs/fragments/11046-locale-gen-usrlocal.yml

Co-authored-by: Felix Fontein <felix@fontein.de>

---------

Co-authored-by: Felix Fontein <felix@fontein.de>
 2025-11-16 11:17:08 +13:00
Alexei Znamensky
5617d57c8c
xcc_redfish_command: fix messages showing dict keys (#11144) 
* xcc_redfish_command: fix messages showing dict keys

* add changelog frag

* Update plugins/modules/xcc_redfish_command.py

Co-authored-by: Felix Fontein <felix@fontein.de>

* Update plugins/modules/xcc_redfish_command.py

Co-authored-by: Felix Fontein <felix@fontein.de>

* Apply suggestions from code review

* Update plugins/modules/xcc_redfish_command.py

---------

Co-authored-by: Felix Fontein <felix@fontein.de>
 2025-11-16 11:07:56 +13:00
Alexei Znamensky
6bf0780d23
xfconf: update state=absent doc (#11159) 2025-11-16 09:02:52 +13:00
Felix Fontein
53c62e7a43
Fix snmp_facts return value docs (#11154) 
Fix snmp_facts return value docs.
 2025-11-14 18:19:50 +01:00
Thomas Löhr
32f0ad2f97
Fixed typo in decompress example documentation (#11150) 2025-11-13 19:35:12 +01:00
Alexei Znamensky
183aa6ed6b
fix markup (#11147) 
* fix markup for common return values

* Apply suggestion from review
 2025-11-13 23:47:08 +13:00
Alexei Znamensky
255059f7b3
fix ruff case B015 (#11145) 
* fix ruff case B015

* add changelog frag
 2025-11-13 06:23:30 +01:00
Alexei Znamensky
996d9a7f63
replace batch 6 of redundant to_native()/to_text() occurrences (#11110) 
* replace batch 6 of redundant to_native()/to_text() occurrences

* add changelog frag
 2025-11-12 21:43:39 +01:00
Alexei Znamensky
f785e9c780
replace batch of redundant to_native()/to_text() occurrences (#11106) 
* replace batch of redundant to_native()/to_text() occurrences

* add changelog frag

* snap sanity

* rolling back snap for now

* more cases in redhat_subscription
 2025-11-12 21:43:14 +01:00
Alexei Znamensky
9b8867399e
replace batch of redundant to_native()/to_text() occurrences (#11105) 
* replace batch of redundant to_native()/to_text() occurrences

* add changelog frag
 2025-11-12 21:42:52 +01:00
Alexei Znamensky
4171b8a9ab
replace batch of redundant to_native()/to_text() occurrences (#11104) 
* replace batch of redundant to_native()/to_text() occurrences

* add changelog frag
 2025-11-12 21:42:37 +01:00
Alexei Znamensky
e5ee3eb88b
replace batch of redundant to_native() occurrences (#11102) 
* replace batch of redundant to_native() occurrences

* add changelog frag

* Update plugins/modules/idrac_redfish_config.py

Co-authored-by: Felix Fontein <felix@fontein.de>

* reformat

* Apply suggestions from code review

Co-authored-by: Felix Fontein <felix@fontein.de>

* Update plugins/modules/dimensiondata_network.py

Co-authored-by: Felix Fontein <felix@fontein.de>

---------

Co-authored-by: Felix Fontein <felix@fontein.de>
 2025-11-12 21:42:19 +01:00
Alexei Znamensky
c45fba549f
fix ruff case E721 (#11121) 
* fix ruff case E721

* add changelog frag
 2025-11-12 21:14:04 +01:00
Alexei Znamensky
41923e43bd
fix ruff case SIM103 (#11119) 
* fix ruff case SIM103

* add changelog frag
 2025-11-12 21:12:47 +01:00
Alexei Znamensky
58bb1e7c04
fix ruff case B007 (#11115) 
* fix ruff case B007

* rollback inventory/iocage

* re-do the fix in inventory/iocage

* add cases in tests/unit/plugins

* rollback plugins/module_utils/memset.py

* rollback extraneous changes in plugins/modules/xcc_redfish_command.py

* add changelog frag
 2025-11-12 21:06:14 +01:00
Felix Fontein
40aea793ee
Use raise from in modules (#11097) 
* Use raise from.

* Add changelog fragment.

* Add comment.
 2025-11-12 21:00:17 +01:00
Bruno Travouillon
6f11d75047
Use Cobbler API version format to check version (#11045) 
* Use Cobbler API version format to check version

Cobbler use the formula below to return the version:

float(format(int(elems[0]) + 0.1 * int(elems[1]) + 0.001 * int(elems[2]), '.3f'))

Which means that 3.3.7 is changed to 3.307 which is > 3.4.

* Compare Cobbler version as a float

* Remove LooseVersion import
 2025-11-12 06:47:07 +01:00
Alexei Znamensky
6c1676fcbb
spotinst_aws_elastigroup: deprecation (#11069) 
* spotinst_aws_elastigroup: deprecation

* add changelog frag

* add missing URL to chglog

* Update changelogs/fragments/11069-deprecate-spotinst.yml

Co-authored-by: Felix Fontein <felix@fontein.de>

* Update meta/runtime.yml

Co-authored-by: Felix Fontein <felix@fontein.de>

* Update plugins/modules/spotinst_aws_elastigroup.py

Co-authored-by: Felix Fontein <felix@fontein.de>

---------

Co-authored-by: Felix Fontein <felix@fontein.de>
 2025-11-11 19:21:51 +13:00
Alexei Znamensky
3b700f0998
yum_versionlock: remove to_native() around command output (#11093) 
* yum_versionlock: remove redundant use of to_native() around command output

* reformat

* add changelog frag
 2025-11-11 19:10:10 +13:00
Alexei Znamensky
634be713bb
replace batch of redundant to_native() occurrences (#11098) 
* replace batch of redundant to_native() occurrences

* add changelog frag
 2025-11-11 19:10:00 +13:00
Alexei Znamensky
6e1cc3eafd
swupd: deprecation (#11087) 
* swupd: deprecation

* add changelog frag

* Update changelogs/fragments/11087-deprecate-swupd.yml

Co-authored-by: Felix Fontein <felix@fontein.de>

* Update meta/runtime.yml

Co-authored-by: Felix Fontein <felix@fontein.de>

* Update plugins/modules/swupd.py

Co-authored-by: Felix Fontein <felix@fontein.de>

---------

Co-authored-by: Felix Fontein <felix@fontein.de>
 2025-11-11 18:48:42 +13:00
Alexei Znamensky
37297f38ae
layman: deprecation (#11070) 
* layman: deprecation

* add changelog frag

* Update changelogs/fragments/11070-deprecate-layman.yml

Co-authored-by: Felix Fontein <felix@fontein.de>

---------

Co-authored-by: Felix Fontein <felix@fontein.de>
 2025-11-11 18:12:22 +13:00
Alexei Znamensky
7f47deed64
dconf: deprecate fallback mechanism (#11088) 
* dconf: deprecate fallback mechanism

* add changelog frag
 2025-11-11 18:03:59 +13:00
Alexei Znamensky
c26a4e613b
consul_kv: adjust RV in docs (#11089) 2025-11-11 05:49:25 +01:00
Alexei Znamensky
dcb580c41d
discard Python 2 ssl handling (#11078) 
* discard Python 2 ssl handling

* add changelog frag

* Apply suggestion

Co-authored-by: Felix Fontein <felix@fontein.de>

---------

Co-authored-by: Felix Fontein <felix@fontein.de>
 2025-11-10 21:12:17 +01:00
Alexei Znamensky
b5157b68ba
opendj_backendprop: use check_rc (#11072) 
* opendj_backendprop: use check_rc

* add changelog frag
 2025-11-10 19:36:21 +13:00
Alexei Znamensky
8b1d725fb2
irc: use True instead of 1 (#11076) 
* irc: use True instead of 1

* add changelog frag
 2025-11-10 19:29:06 +13:00
Alexei Znamensky
60828e82a4
smartos imgadm man page reference (#11071) 2025-11-10 14:08:06 +13:00
Alexei Znamensky
0175d75a7c
dnsimple_info: minor improvements (#11052) 
* dnsimple_info: minor improvements

* add changelog frag

* typo

* Update plugins/modules/dnsimple_info.py

Co-authored-by: Felix Fontein <felix@fontein.de>

---------

Co-authored-by: Felix Fontein <felix@fontein.de>
 2025-11-09 18:02:29 +01:00
Alexei Znamensky
a9a4f89033
remove required=false from docs (#11055) 2025-11-09 08:27:06 +01:00
Alexei Znamensky
49c7253f24
zfs_facts: use check_rc (#11054) 
* zfs_facts: use check_rc

* add changelog frag
 2025-11-09 08:14:56 +01:00
Felix Fontein
396f467bbb
Improve Python code: address unused variables (#11049) 
* Address F841 (unused variable).

* Reformat.

* Add changelog fragment.

* More cleanup.

* Remove trailing whitespace.

* Readd removed code as a comment with TODO.
 2025-11-09 08:14:35 +01:00
Alexei Znamensky
0d8521c718
supervisorctl: investigate integration tests (#11057) 
* supervisorctl: investigate integration tests

* wait for supervisord to complete stop

* adjust in module
 2025-11-09 16:09:27 +13:00
Alexei Znamensky
ac4f657d43
opendj_backendprop: docs improvements (#11053) 2025-11-09 12:03:20 +13:00
Alexei Znamensky
ebf45260ce
remove conditional code for old snakes (#11048) 
* remove conditional code for old snakes

* remove conditional code for old snakes

* reformat

* add changelog frag
 2025-11-08 17:21:46 +01:00
Felix Fontein
3478863ef0
Address issues reported by ruff check (#11043) 
* Resolve E713 and E714 (not in/is tests).

* Address UP018 (unnecessary str call).

* UP045 requires Python 3.10+.

* Address UP007 (X | Y for type annotations).

* Address UP035 (import Callable from collections.abc).

* Address UP006 (t.Dict -> dict).

* Address UP009 (UTF-8 encoding comment).

* Address UP034 (extraneous parantheses).

* Address SIM910 (dict.get() with None default).

* Address F401 (unused import).

* Address UP020 (use builtin open).

* Address B009 and B010 (getattr/setattr with constant name).

* Address SIM300 (Yoda conditions).

* UP029 isn't in use anyway.

* Address FLY002 (static join).

* Address B034 (re.sub positional args).

* Address B020 (loop variable overrides input).

* Address B017 (assert raise Exception).

* Address SIM211 (if expression with false/true).

* Address SIM113 (enumerate for loop).

* Address UP036 (sys.version_info checks).

* Remove unnecessary UP039.

* Address SIM201 (not ==).

* Address SIM212 (if expr with twisted arms).

* Add changelog fragment.

* Reformat.
 2025-11-08 17:05:21 +13:00
jnaab
f5943201b9
filesystem: xfs resize: minimal required increment (#11033) 
Internally XFS uses allocation groups. Allocation groups have a maximum
size of 1 TiB - 1 block. For devices >= 4 TiB XFS uses max size
allocation groups. If a filesystem is extended and the last allocation
group is already at max size, a new allocation group is added. An
allocation group seems to require at least 64 4 KiB blocks.

For devices with integer TiB size (>4), this creates a filesystem that
has initially has 1 unused block per TiB size. The `resize` option
detects this unused space, and tries to resize the filesystem.  The
xfs_growfs call is successful (exit 0), but does not increase the file
system size. This is detected as repeated change in the task.

Test case:
```
- hosts: localhost
  tasks:
    - ansible.builtin.command:
        cmd: truncate -s 4T /media/xfs.img
        creates: /media/xfs.img
      notify: loopdev xfs

    - ansible.builtin.meta: flush_handlers

    - name: pickup xfs.img resize
      ansible.builtin.command:
        cmd: losetup -c /dev/loop0
      changed_when: false

    - community.general.filesystem:
        dev: "/dev/loop0"
        fstype: "xfs"

    - ansible.posix.mount:
        src: "/dev/loop0"
        fstype: "xfs"
        path: "/media/xfs"
        state: "mounted"

    # always shows a diff even for newly created filesystems
    - community.general.filesystem:
        dev: "/dev/loop0"
        fstype: "xfs"
        resizefs: true

  handlers:
    - name: loopdev xfs
      ansible.builtin.command:
        cmd: losetup /dev/loop0 /media/xfs.img
```

NB: If the last allocation group is not yet at max size, the filesystem
can be resized. Detecting this requires considering the XFS topology.
Other filesystems (at least ext4) also seem to require a minimum
increment after the initial device size, but seem to use the entire
device after initial creation.

Fun observation: creating a 64(+) TiB filesystem leaves a 64(+) block
gap at the end, that is allocated in a subsequent xfs_growfs call.

Co-authored-by: Johannes Naab <johannes.naab@hetzner-cloud.de>
 2025-11-07 21:27:50 +01:00