Alexei Znamensky
6ae47590cd
lxc_container: replace subprocess.Popen() with run_command() ( #11204 )
...
* lxc_container: replace subprocess.Popen() with run_command()
* Update plugins/modules/lxc_container.py
Co-authored-by: Felix Fontein <felix@fontein.de>
* add changelog frag
* retain Popen logic in module_utils
* Update plugins/module_utils/_lxc.py
Co-authored-by: Felix Fontein <felix@fontein.de>
---------
Co-authored-by: Felix Fontein <felix@fontein.de>
2025-12-29 11:47:26 +01:00
Alexei Znamensky
04d0a4daf3
lxc_container: rearrange docs notes ( #11325 )
...
* lxc_container: rearrange docs notes
* Update plugins/modules/lxc_container.py
* reformat docs
2025-12-25 08:22:03 +01:00
Alexei Znamensky
ec6b7bf91c
lxc_container: use tempfile.TemporaryDirectory ( #11323 )
...
* lxc_container: use tempfile.TemporaryDirectory
* add changelog frag
* typo
2025-12-25 08:18:19 +01:00
Alexei Znamensky
183aa6ed6b
fix markup ( #11147 )
...
* fix markup for common return values
* Apply suggestion from review
2025-11-13 23:47:08 +13:00
Alexei Znamensky
a9a4f89033
remove required=false from docs ( #11055 )
2025-11-09 08:27:06 +01:00
Felix Fontein
3478863ef0
Address issues reported by ruff check ( #11043 )
...
* Resolve E713 and E714 (not in/is tests).
* Address UP018 (unnecessary str call).
* UP045 requires Python 3.10+.
* Address UP007 (X | Y for type annotations).
* Address UP035 (import Callable from collections.abc).
* Address UP006 (t.Dict -> dict).
* Address UP009 (UTF-8 encoding comment).
* Address UP034 (extraneous parantheses).
* Address SIM910 (dict.get() with None default).
* Address F401 (unused import).
* Address UP020 (use builtin open).
* Address B009 and B010 (getattr/setattr with constant name).
* Address SIM300 (Yoda conditions).
* UP029 isn't in use anyway.
* Address FLY002 (static join).
* Address B034 (re.sub positional args).
* Address B020 (loop variable overrides input).
* Address B017 (assert raise Exception).
* Address SIM211 (if expression with false/true).
* Address SIM113 (enumerate for loop).
* Address UP036 (sys.version_info checks).
* Remove unnecessary UP039.
* Address SIM201 (not ==).
* Address SIM212 (if expr with twisted arms).
* Add changelog fragment.
* Reformat.
2025-11-08 17:05:21 +13:00
Felix Fontein
340ff8586d
Reformat everything.
2025-11-01 13:46:53 +01:00
Felix Fontein
0c5466de47
Cleanup: remove unicode prefix, remove explicit inheritance from object ( #11015 )
...
* Address UP025: remove unicode literals from strings.
* Address UP004: class inherits from 'object'.
2025-10-30 20:17:10 +01:00
Alexei Znamensky
b527e80307
modules [lm]*: use f-strings ( #10971 )
...
* modules [lm]*: use f-strings
* add changelog frag
2025-10-26 07:57:24 +01:00
Felix Fontein
8f8a0e1d7c
Fix __future__ imports, __metaclass__ = type, and remove explicit UTF-8 encoding statement for Python files ( #10886 )
...
* Adjust all __future__ imports:
for i in $(grep -REl "__future__.*absolute_import" plugins/ tests/); do
sed -e 's/from __future__ import .*/from __future__ import annotations/g' -i $i;
done
* Remove all UTF-8 encoding specifications for Python source files:
for i in $(grep -REl '[-][*]- coding: utf-8 -[*]-' plugins/ tests/); do
sed -e '/^# -\*- coding: utf-8 -\*-/d' -i $i;
done
* Remove __metaclass__ = type:
for i in $(grep -REl '__metaclass__ = type' plugins/ tests/); do
sed -e '/^__metaclass__ = type/d' -i $i;
done
2025-10-10 19:52:04 +02:00
Alexei Znamensky
69d479f06c
doc style adjustments: modules [lm]* ( #10433 )
...
* doc style adjustments: modules l*
* doc style adjustments: modules m*
* Apply suggestions from code review
Co-authored-by: Felix Fontein <felix@fontein.de>
* Update plugins/modules/logstash_plugin.py
Co-authored-by: Felix Fontein <felix@fontein.de>
---------
Co-authored-by: Felix Fontein <felix@fontein.de>
2025-07-21 22:09:09 +02:00
Alexei Znamensky
838cdaab42
lmn*: style adjustments ( #9528 )
...
* lmn*: style adjustments
* Apply suggestions from code review
* Apply suggestions from code review
Co-authored-by: Felix Fontein <felix@fontein.de>
---------
Co-authored-by: Felix Fontein <felix@fontein.de>
2025-01-07 06:28:00 +01:00
Alexei Znamensky
5f47127ef7
adjust doc style - batch 2 ( #9447 )
2024-12-29 13:42:22 +01:00
Felix Fontein
ec585392e5
Docs: fix its vs. it's ( #9442 )
...
* Fix its vs. it's.
* Improvements from review.
Co-authored-by: Alexei Znamensky <103110+russoz@users.noreply.github.com>
* Improve formulations.
Co-authored-by: Alexei Znamensky <103110+russoz@users.noreply.github.com>
---------
Co-authored-by: Alexei Znamensky <103110+russoz@users.noreply.github.com>
2024-12-29 13:29:58 +01:00
Alexei Znamensky
cea6eeef37
l*.py: normalize docs ( #9390 )
2024-12-26 09:12:05 +01:00
Alexei Znamensky
7e978c77b4
use dict comprehension in plugins, part 2 ( #8822 )
...
* use dict comprehension in plugins
* add changelog frag
2024-09-05 21:47:28 +02:00
Felix Fontein
2b62826082
Fix more typos ( #7439 )
...
* Fix more typos in plugins/.
* Fix typos in tests/unit/.
* Fix typos in tests/integration/.
* Fix more typos.
Co-authored-by: Sebastian Gumprich <rndmh3ro@users.noreply.github.com>
---------
Co-authored-by: Sebastian Gumprich <rndmh3ro@users.noreply.github.com>
2023-10-29 18:04:44 +01:00
Felix Fontein
13e9e4b196
Add more semantic markup ( #6744 )
...
Add more semantic markup.
2023-06-20 08:14:02 +02:00
Felix Fontein
c694abbdf9
Use semantic markup (modules k-l) ( #6678 )
...
* Use semantic markup.
* Use option instead of alias.
2023-06-15 15:47:13 +02:00
Felix Fontein
0ef805699d
Add attributes to more modules (1/4) ( #5965 )
...
* Add attributes to more modules.
* Apply suggestions from code review.
Co-authored-by: Kristian Heljas <11139388+kristianheljas@users.noreply.github.com>
---------
Co-authored-by: Kristian Heljas <11139388+kristianheljas@users.noreply.github.com>
2023-02-20 17:29:14 +01:00
Felix Fontein
2b8ac3c629
Remove unneccessary imports ( #5940 )
...
* Remove unneccessary imports.
* Keep unnecessary imports in module_utils - for now.
* Make older sanity tests shut up.
* Also make flake8 happier.
2023-02-12 19:48:39 +01:00
Alexander Couzens
af53271c41
lxc_container: fix lxc argument when executing lxc command ( #5659 )
...
lxc_container fails when executing the lxc command (e.g. when creating
a new container) because PR#5358 broke the module argument
parsing. The resulting argument dict contained only the module argument name
and the argument flag but not the value. E.g.
```
- lxc_container:
template: debian
```
would result in lxc command arguments `lxc template --template` instead of
`lxc --template debian`.
Fixes: 6f88426cf1#5358 )")
Fixes #5578
Signed-off-by: Alexander Couzens <lynxis@fe80.eu>
Signed-off-by: Alexander Couzens <lynxis@fe80.eu>
2022-12-17 12:10:23 +01:00
Felix Fontein
b531ecdc9b
Unflatmap community.general ( #5461 )
...
* Move files.
* Update imports and references.
* Move wrongly placed files.
* Reverse redirects, deprecate long → short name redirects.
* Simplify contribution guidelines for new modules.
* Rewrite BOTMETA.
* Add changelog fragment.
* Fix ignore.txt files.
2022-11-02 20:42:29 +00:00
Felix Fontein
7743ecd776
Replace symlinks with meta/runtime.yml redirects. ( #4562 )
2022-04-26 20:33:13 +02:00
Brian Coca
8f90360d49
make collection usable with current ansible vers ( #9 )
2020-03-11 14:10:38 +00:00
