ansible/community.general
1
0
Fork 0
mirror of https://github.com/ansible-collections/community.general.git synced 2026-02-04 07:51:50 +00:00
Code Activity
3975 commits 14 branches 222 tags 315 MiB
Commit graph

486 commits

Author SHA1 Message Date
Alexei Znamensky
1c678f5c07
fix ruff case UP030 (#11189) 
* fix ruff case UP030

* add changelog frag

* formatting

* suggestion from review
 2025-11-23 08:37:41 +01:00
Alexei Znamensky
79b16d9ca5
fix return value exception (#11149) 
* fix return value `exception`

* add changelog frag

* adjustments after review

* typo

* adjust changelog frag

* vmadm: send rc, stdout, and stderr to fail_json()

* rundeck: pass tracebacks

* Update changelogs/fragments/11149-rv-exception.yml

Co-authored-by: Felix Fontein <felix@fontein.de>

* Update changelogs/fragments/11149-rv-exception.yml

Co-authored-by: Felix Fontein <felix@fontein.de>

---------

Co-authored-by: Felix Fontein <felix@fontein.de>
 2025-11-18 20:07:26 +13:00
Alexei Znamensky
f5c2c8b9a2
replace redundant to_native()/to_text() occurrences, batch 7 (#11112) 
* replace redundant to_native()/to_text() occurrences, batch 7

* add changelog frag

* made changes per review
 2025-11-13 10:38:29 +13:00
Alexei Znamensky
2dfb46a4a6
remove ignore lines for Python 2 (#11122) 
* remove ignore lines for Python 2

* use yield from

* add changelog frag

* Update changelogs/fragments/11122-yield-from-ignore.yml

Co-authored-by: Felix Fontein <felix@fontein.de>

---------

Co-authored-by: Felix Fontein <felix@fontein.de>
 2025-11-12 21:14:51 +01:00
Alexei Znamensky
41923e43bd
fix ruff case SIM103 (#11119) 
* fix ruff case SIM103

* add changelog frag
 2025-11-12 21:12:47 +01:00
Alexei Znamensky
58bb1e7c04
fix ruff case B007 (#11115) 
* fix ruff case B007

* rollback inventory/iocage

* re-do the fix in inventory/iocage

* add cases in tests/unit/plugins

* rollback plugins/module_utils/memset.py

* rollback extraneous changes in plugins/modules/xcc_redfish_command.py

* add changelog frag
 2025-11-12 21:06:14 +01:00
Felix Fontein
40aea793ee
Use raise from in modules (#11097) 
* Use raise from.

* Add changelog fragment.

* Add comment.
 2025-11-12 21:00:17 +01:00
Felix Fontein
396f467bbb
Improve Python code: address unused variables (#11049) 
* Address F841 (unused variable).

* Reformat.

* Add changelog fragment.

* More cleanup.

* Remove trailing whitespace.

* Readd removed code as a comment with TODO.
 2025-11-09 08:14:35 +01:00
Alexei Znamensky
ebf45260ce
remove conditional code for old snakes (#11048) 
* remove conditional code for old snakes

* remove conditional code for old snakes

* reformat

* add changelog frag
 2025-11-08 17:21:46 +01:00
Felix Fontein
3478863ef0
Address issues reported by ruff check (#11043) 
* Resolve E713 and E714 (not in/is tests).

* Address UP018 (unnecessary str call).

* UP045 requires Python 3.10+.

* Address UP007 (X | Y for type annotations).

* Address UP035 (import Callable from collections.abc).

* Address UP006 (t.Dict -> dict).

* Address UP009 (UTF-8 encoding comment).

* Address UP034 (extraneous parantheses).

* Address SIM910 (dict.get() with None default).

* Address F401 (unused import).

* Address UP020 (use builtin open).

* Address B009 and B010 (getattr/setattr with constant name).

* Address SIM300 (Yoda conditions).

* UP029 isn't in use anyway.

* Address FLY002 (static join).

* Address B034 (re.sub positional args).

* Address B020 (loop variable overrides input).

* Address B017 (assert raise Exception).

* Address SIM211 (if expression with false/true).

* Address SIM113 (enumerate for loop).

* Address UP036 (sys.version_info checks).

* Remove unnecessary UP039.

* Address SIM201 (not ==).

* Address SIM212 (if expr with twisted arms).

* Add changelog fragment.

* Reformat.
 2025-11-08 17:05:21 +13:00
Felix Fontein
340ff8586d Reformat everything. 2025-11-01 13:46:53 +01:00
Felix Fontein
3f2213791a
Cleanup: use f-strings instead of str.format() (#11017) 
Address UP032: use f-strings instead of str.format().
 2025-11-01 12:04:33 +01:00
Marius Bertram
5d5392786c
Add Keycloak module to send execute-actions email to users (#10950) 
* Add Keycloak module to send execute-actions email to users

Signed-off-by: Marius Bertram <marius@brtrm.de>

* Fix Example Typo

Signed-off-by: Marius Bertram <marius@brtrm.de>

* Break if argument_speck() is broken

Signed-off-by: Marius Bertram <marius@brtrm.de>

* Adjust to new tests in main.

* Remove unnecessary version_added.

---------

Signed-off-by: Marius Bertram <marius@brtrm.de>
Co-authored-by: Felix Fontein <felix@fontein.de>
 2025-10-30 20:55:31 +01:00
Felix Fontein
74c2c804e5
Cleanup: use super() instead of super(__class__, self) (#11016) 
* Address UP008: Use super() instead of super(__class__, self).

* Linting.
 2025-10-30 20:17:26 +01:00
Felix Fontein
0c5466de47
Cleanup: remove unicode prefix, remove explicit inheritance from object (#11015) 
* Address UP025: remove unicode literals from strings.

* Address UP004: class inherits from 'object'.
 2025-10-30 20:17:10 +01:00
Felix Fontein
6088b0cff5
CI: add type checking (#10997) 
* Set up type checking with mypy.

* Make mypy pass.

* Use list() instead of sorted().
 2025-10-29 17:13:38 +00:00
Alexei Znamensky
c889a4cb6d
deprecate oneandone modules (#10994) 
* deprecate oneandone modules

* add mod util to runtime.yml

* add changelog frag

* change deprecation version to 13.0.0

* change deprecation version to 13.0.0 in readme.yml as well

* Update changelogs/fragments/10994-oneandone-deprecation.yml

Co-authored-by: Felix Fontein <felix@fontein.de>

---------

Co-authored-by: Felix Fontein <felix@fontein.de>
 2025-10-29 08:13:55 +13:00
Alexei Znamensky
6829a064a5
dimensiondata: deprecation (#10986) 
* dimensiondata: deprecation

* add changelog frag

* typo

* Update changelogs/fragments/10986-deprecation-dimensiondata.yml

Co-authored-by: Felix Fontein <felix@fontein.de>

---------

Co-authored-by: Felix Fontein <felix@fontein.de>
 2025-10-28 10:50:56 +13:00
Alexei Znamensky
032d398c0a
module utils: use f-strings (#10979) 
* module utils: use f-strings

* add changelog frag
 2025-10-26 08:01:38 +01:00
Alexei Znamensky
d86340b9d3
modules a*: use f-strings (#10942) 
* modules a*: use f-strings

* add changelog frag

* add changelog frag

* rename chglof frag file
 2025-10-23 06:50:32 +02:00
Alexei Znamensky
0feabaa7da
keycloak: use f-strings (#10941) 
* keycloak: use f-strings

* remove nested f-str

* add changelog frag
 2025-10-22 23:17:06 +02:00
Alexei Znamensky
728856f611
redfish_utils module utils: use f-strings (#10939) 
* redfish_utils: use f-strings

* add changelog frag

* remove nested f-str
 2025-10-22 23:15:41 +02:00
Marius Bertram
c850e209ab
Add support for client auth in Keycloak cllient secrets module (#10933) 
* keycloak: add client authentication support for client_secret

Signed-off-by: Marius Bertram <marius@brtrm.de>

* readd ['token', 'auth_realm']

Signed-off-by: Marius Bertram <marius@brtrm.de>

---------

Signed-off-by: Marius Bertram <marius@brtrm.de>
 2025-10-19 21:12:41 +02:00
Alexei Znamensky
d4dfc217d8
xenserver: use f-strings (#10940) 
* xenserver: use f-strings

* add changelog frag
 2025-10-19 17:40:28 +02:00
Felix Fontein
9dedd77459
Add __init__.py to work around ansible-test/pylint bug (#10926) 
Add __init__.py to work around ansible-test/pylint bug.
 2025-10-15 21:42:55 +02:00
Alexei Znamensky
07cfd6c4b4
update code to python3 (#10903) 
* update code to python3

* add changelog frag

* rollback adjustment for plugins/lookup/lmdb_kv.py

* accept PR suggestion for plugins/module_utils/utm_utils.py

* accept PR suggestion for plugins/module_utils/vexata.py

* Apply suggestions from code review

* Update changelogs/fragments/10903-2to3.yml

* Update changelogs/fragments/10903-2to3.yml
 2025-10-12 11:05:57 +02:00
Alexei Znamensky
85053728ce
linode module utils: update import to recent Ansible level (#10906) 
* linode module utils: update import to recent Ansible level

* add changelog frag
 2025-10-11 13:42:19 +02:00
Alexei Znamensky
cc83188594
module utils: update code to python3 (#10907) 
* module utils: update code to python3

* add changelog frag
 2025-10-11 13:42:11 +02:00
Alexei Znamensky
b85e263466
use f-strings in module utils (#10901) 
* use f-strings in module utils

* Apply suggestions from code review

Co-authored-by: Felix Fontein <felix@fontein.de>

* remove unused imports

---------

Co-authored-by: Felix Fontein <felix@fontein.de>
 2025-10-11 11:43:43 +02:00
Felix Fontein
a8977afb04
Remove all usage of ansible.module_utils.six from main branch (#10888) 
* Get rid of all six.moves imports.

* Get rid of iteritems.

* Get rid of *_type(s) aliases.

* Replace StringIO import.

* Get rid of PY2/PY3 constants.

* Get rid of raise_from.

* Get rid of python_2_unicode_compatible.

* Clean up global six imports.

* Remove all usage of ansible.module_utils.six.

* Linting.

* Fix xml module.

* Docs adjustments.
 2025-10-11 08:21:57 +02:00
Felix Fontein
8f8a0e1d7c
Fix __future__ imports, __metaclass__ = type, and remove explicit UTF-8 encoding statement for Python files (#10886) 
* Adjust all __future__ imports:

for i in $(grep -REl "__future__.*absolute_import" plugins/ tests/); do
  sed -e 's/from __future__ import .*/from __future__ import annotations/g' -i $i;
done

* Remove all UTF-8 encoding specifications for Python source files:

for i in $(grep -REl '[-][*]- coding: utf-8 -[*]-' plugins/ tests/); do
  sed -e '/^# -\*- coding: utf-8 -\*-/d' -i $i;
done

* Remove __metaclass__ = type:

for i in $(grep -REl '__metaclass__ = type' plugins/ tests/); do
  sed -e '/^__metaclass__ = type/d' -i $i;
done
 2025-10-10 19:52:04 +02:00
Alexei Znamensky
633bd6133a
remove Python2 some constructs/docs/comments (#10892) 
* remove Python2 some constructs/docs/comments

* add changelog frag
 2025-10-10 19:15:01 +02:00
Alexei Znamensky
5f471b8e5b
refactor dict from literal list (#10891) 
* refactor dict from literal list

* add changelog frag
 2025-10-10 19:09:10 +02:00
Felix Fontein
0b72737cab
Bump version of main to 12.0.0; execute announced deprecations (#10883) 
* Bump version to 12.0.0.

* Remove deprecated modules and plugins.

* state is now required.

* Change default of prepend_hash from auto to never.

* Remove support for force=''.

* Always delegate 'debug'.

* Remove ignore_value_none and ctx_ignore_none parameters.

* Remove parameters on_success and on_failure.

* Update BOTMETA.

* Adjust docs reference.

* Forgot required=True.

* Fix changelog fragment.

* Adjust unit tests.

* Fix changelog.

Co-authored-by: Alexei Znamensky <103110+russoz@users.noreply.github.com>

---------

Co-authored-by: Alexei Znamensky <103110+russoz@users.noreply.github.com>
 2025-10-09 13:50:07 +02:00
Alexei Znamensky
750adb431a
pipx: adjustments for pipx 1.8.0 (#10874) 
* pipx: adjustments for pipx 1.8.0

* add changelog frag

* typo
 2025-10-05 07:06:01 +02:00
Jakub Danek
b865bf5751
Fix keycloak sub-group search (#10840) 
* fix bug in missing realm argument when searching for groups

* MR change fragment

* 39+1=40
 2025-09-21 20:27:42 +02:00
David Phillips
7a231a248e
gitlab_*_variable: add description option (#10812) 2025-09-18 21:55:28 +02:00
David Phillips
3574b3fa93
gitlab_*_variable: support masked-and-hidden variables (#10787) 
* gitlab_*_variable: support masked-and-hidden variables

Support masking and hiding GitLab project and group variables. In the
GitLab API, variables that are hidden are also masked by implication.
Note gitlab_instance_variable is unmodified since instance variables
cannot be hidden.

* gitlab_*_variable: add `hidden` to legacy `vars` syntax

* gitlab_*_variable: address review comments in doc
 2025-09-08 18:40:35 +02:00
Dexter
3baa13a3e4
pacemaker_resource: Add cloning support for resources and groups (#10665) 
* add clone state for pacemaker_resource

* add changelog fragment

* Additional description entry for comment header

* Apply suggestions from code review

Co-authored-by: Felix Fontein <felix@fontein.de>

* Update plugins/modules/pacemaker_resource.py

Co-authored-by: Felix Fontein <felix@fontein.de>

* fix formatting for yamllint

* Apply code review suggestions

* refactor state name to cloned

* Update plugins/modules/pacemaker_resource.py

Co-authored-by: Felix Fontein <felix@fontein.de>

* Apply suggestions from code review

Co-authored-by: Alexei Znamensky <103110+russoz@users.noreply.github.com>

* Apply suggestions from code review

---------

Co-authored-by: Felix Fontein <felix@fontein.de>
Co-authored-by: Alexei Znamensky <103110+russoz@users.noreply.github.com>
 2025-09-07 21:24:01 +02:00
Alexei Znamensky
d0123a1038
django_dumpdata, django_loaddata: new modules (#10726) 
* django module, module_utils: adjustments

* more fixes

* more fixes

* further simplification

* django_dumpdata/django_loaddata: new modules

* Update plugins/modules/django_dumpdata.py

Co-authored-by: Felix Fontein <felix@fontein.de>

* add note about idempotency

---------

Co-authored-by: Felix Fontein <felix@fontein.de>
 2025-09-03 21:49:11 +02:00
Alexei Znamensky
e6502a8e51
xenserver: remove required=false from arg spec (#10769) 
* xenserver: remove required=false from arg spec

* add changelog frag
 2025-08-31 11:49:09 +02:00
Dexter
6332175493
pacemaker: Add regex checking for maintenance-mode (#10707) 
* Add regex checking for maintenance-mode

* Add changelog fragment

* Apply suggestions from code review

Co-authored-by: Felix Fontein <felix@fontein.de>
Co-authored-by: Alexei Znamensky <103110+russoz@users.noreply.github.com>

---------

Co-authored-by: Felix Fontein <felix@fontein.de>
Co-authored-by: Alexei Znamensky <103110+russoz@users.noreply.github.com>
 2025-08-27 22:01:47 +02:00
Alexei Znamensky
ded43714d3
django module, module_utils: adjustments (#10684) 
* django module, module_utils: adjustments

* fix name

* more fixes

* more fixes

* further simplification

* add changelog frag
 2025-08-27 21:53:20 +02:00
Alexei Znamensky
cb84fa740a
remove extra brackets when params are a given by a comprehension (#10712) 
* remove extra brackets when function params are a given by a comprehension

* add changelog frag
 2025-08-23 19:14:39 +02:00
Dexter
e43735659a
pacemaker_stonith: new module (#10195) 
* feat(initial): Add pacemaker_stonith module and unit tests

* feat(initial): Add working changes to pacemaker_stonith

* refactor(review): Apply code review suggestions

* Apply suggestions from code review

Co-authored-by: Felix Fontein <felix@fontein.de>
Co-authored-by: Alexei Znamensky <103110+russoz@users.noreply.github.com>

* refactor(review): Additional code review items

* bug(cli_action): Add missing runner arguments

* Apply code review suggestions

* Apply suggestions from code review

Co-authored-by: Felix Fontein <felix@fontein.de>

* Apply suggestions from code review

Co-authored-by: Alexei Znamensky <103110+russoz@users.noreply.github.com>

* WIP

* Apply doc changes to pacemaker stonith

* Update plugins/modules/pacemaker_stonith.py

---------

Co-authored-by: Felix Fontein <felix@fontein.de>
Co-authored-by: Alexei Znamensky <103110+russoz@users.noreply.github.com>
 2025-08-23 18:36:32 +02:00
Alexei Znamensky
9e86d239d2
oci/oracle: deprecation (#10652) 
* oci/oracle: deprecation

* add changelog frag

* add doc frags to changelog frag

* Update changelogs/fragments/10652-oracle-deprecation.yml

Co-authored-by: Felix Fontein <felix@fontein.de>

---------

Co-authored-by: Felix Fontein <felix@fontein.de>
 2025-08-23 18:35:37 +02:00
Dexter
b9385d7fe8
pacemaker_resource: Fix resource_type parameter (#10663) 
* Ensure resource standard, provider, and name are proper format

* Add changelog fragment

* Update changelogs/fragments/10663-pacemaker-resource-fix-resource-type.yml

Co-authored-by: Felix Fontein <felix@fontein.de>

---------

Co-authored-by: Felix Fontein <felix@fontein.de>
 2025-08-18 20:15:20 +02:00
Felix Fontein
47e8a3c193
ansible-core 2.20: avoid deprecated functionality (#10687) 
Avoid deprecated functionality.
 2025-08-18 06:25:23 +02:00
Alexei Znamensky
89b6717888
oneview module utils: remove unused import of "os" package (#10644) 
* oneview module utils: remove unused import of "os" package

* add changelog frag

* Update changelogs/fragments/10644-oneview-os.yml

Co-authored-by: Felix Fontein <felix@fontein.de>

---------

Co-authored-by: Felix Fontein <felix@fontein.de>
 2025-08-11 23:21:40 +02:00
Alexei Znamensky
1518b43b85
django module utils: remove deprecated function arg ignore_value_none (#10574) 
* django module utils: remove deprecated function arg ignore_value_none

* fix argument order in call from _DjangoRunner to superclass

* add changelog frag
 2025-08-04 20:02:10 +02:00