ansible/community.general
1
0
Fork 0
mirror of https://github.com/ansible-collections/community.general.git synced 2026-06-11 10:35:34 +00:00
Code Activity

jenkins_plugin: use latest version's real version number for dependency comparisons

Browse source 
you'd think that a user requesting "latest" and getting "latest" would skip any kind of checks, but the opposite is the case:
user requests "latest", module looks up what's installed on jenkins, resulting in a real version number. "latest" will never match this, so plugins are always re-downloaded, which is obnoxiously slow.

the "latest" logic is still needed because only plugin installations where the absolute latest version is compatible are
This commit is contained in:
Willy Hille 2026-06-10 17:24:27 +02:00
parent 87b02145c7
commit ff6dea0e19
1 changed files with 8 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

11
plugins/modules/jenkins_plugin.py
View file

@ -709,7 +709,7 @@ class JenkinsPlugin:
return self.plugin_versions_data
def _get_latest_compatible_plugin_version(self, plugin_name=None):
def _get_latest_compatible_plugin_version(self, plugin_name=None, resolve_latest_to_version=False):
if not hasattr(self, "jenkins_version"):
self.module.params["force_basic_auth"] = True
resp, info = fetch_url(self.module, self.url)
@ -727,7 +727,12 @@ class JenkinsPlugin:
for idx, (version_title, version_info) in enumerate(sorted_versions):
required_core = version_info.get("requiredCore", "0.0")
if self.parse_version(required_core) <= self.jenkins_version:
return "latest" if idx == 0 else version_title
# "latest" means both "the user doesn't care about the version"
# and "latest == latest compatible" (allows using plugin manager).
# let the caller decide which interpretation they need
if idx == 0 and not resolve_latest_to_version:
return "latest"
return version_title
self.module.warn(f"No compatible version found for plugin '{name}'. Installing latest version.")
return "latest"
@ -753,7 +758,7 @@ class JenkinsPlugin:
plugin_data = self._download_updates()["dependencies"]
dependencies_info = {
dep["name"]: self._get_latest_compatible_plugin_version(dep["name"])
dep["name"]: self._get_latest_compatible_plugin_version(dep["name"], resolve_latest_to_version=True)
for dep in plugin_data
if not dep.get("optional", False)
}