ansible/community.general
1
0
Fork 0
mirror of https://github.com/ansible-collections/community.general.git synced 2026-03-27 07:27:33 +00:00
Code Activity

Stop re-defining the argument spec in unit tests (#11235)

Browse source 
* Stop re-defining the argument spec in unit tests.

* Shut up linter.
This commit is contained in:
Felix Fontein 2025-12-01 06:59:23 +01:00 • committed by GitHub
parent 6365b5a981
commit fb2f34ba85
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
6 changed files with 35 additions and 274 deletions
Download patch file Download diff file Expand all files Collapse all files

91
tests/unit/plugins/modules/test_java_keystore.py
View file

@ -13,25 +13,8 @@ from ansible_collections.community.internal_test_tools.tests.unit.plugins.module
ModuleTestCase,
set_module_args,
)
from ansible.module_utils.basic import AnsibleModule
from ansible_collections.community.general.plugins.modules.java_keystore import JavaKeystore
module_argument_spec = dict(
name=dict(type="str", required=True),
dest=dict(type="path", required=True),
certificate=dict(type="str", no_log=True),
certificate_path=dict(type="path"),
private_key=dict(type="str", no_log=True),
private_key_path=dict(type="path", no_log=False),
private_key_passphrase=dict(type="str", no_log=True),
password=dict(type="str", required=True, no_log=True),
ssl_backend=dict(type="str", default="openssl", choices=["openssl", "cryptography"]),
keystore_type=dict(type="str", choices=["jks", "pkcs12"]),
force=dict(type="bool", default=False),
)
module_supports_check_mode = True
module_choose_between = (["certificate", "certificate_path"], ["private_key", "private_key_path"])
from ansible.module_utils.basic import AnsibleModule # noqa: F401 # pylint: disable=unused-import
from ansible_collections.community.general.plugins.modules.java_keystore import JavaKeystore, create_module
class TestCreateJavaKeystore(ModuleTestCase):
@ -96,12 +79,7 @@ class TestCreateJavaKeystore(ModuleTestCase):
password="changeit",
)
):
module = AnsibleModule(
argument_spec=module_argument_spec,
supports_check_mode=module_supports_check_mode,
mutually_exclusive=module_choose_between,
required_one_of=module_choose_between,
)
module = create_module()
with patch("os.remove", return_value=True):
self.create_path.side_effect = ["/tmp/tmpgrzm2ah7"]
@ -139,12 +117,7 @@ class TestCreateJavaKeystore(ModuleTestCase):
password="changeit",
)
):
module = AnsibleModule(
argument_spec=module_argument_spec,
supports_check_mode=module_supports_check_mode,
mutually_exclusive=module_choose_between,
required_one_of=module_choose_between,
)
module = create_module()
module.exit_json = Mock()
module.fail_json = Mock()
@ -189,12 +162,7 @@ class TestCreateJavaKeystore(ModuleTestCase):
password="changeit",
)
):
module = AnsibleModule(
argument_spec=module_argument_spec,
supports_check_mode=module_supports_check_mode,
mutually_exclusive=module_choose_between,
required_one_of=module_choose_between,
)
module = create_module()
module.exit_json = Mock()
module.fail_json = Mock()
@ -237,12 +205,7 @@ class TestCreateJavaKeystore(ModuleTestCase):
password="changeit",
)
):
module = AnsibleModule(
argument_spec=module_argument_spec,
supports_check_mode=module_supports_check_mode,
mutually_exclusive=module_choose_between,
required_one_of=module_choose_between,
)
module = create_module()
module.exit_json = Mock()
module.fail_json = Mock()
@ -315,12 +278,7 @@ class TestCertChanged(ModuleTestCase):
password="changeit",
)
):
module = AnsibleModule(
argument_spec=module_argument_spec,
supports_check_mode=module_supports_check_mode,
mutually_exclusive=module_choose_between,
required_one_of=module_choose_between,
)
module = create_module()
with patch("os.remove", return_value=True):
self.create_file.side_effect = ["/tmp/placeholder", ""]
@ -341,12 +299,7 @@ class TestCertChanged(ModuleTestCase):
password="changeit",
)
):
module = AnsibleModule(
argument_spec=module_argument_spec,
supports_check_mode=module_supports_check_mode,
mutually_exclusive=module_choose_between,
required_one_of=module_choose_between,
)
module = create_module()
with patch("os.remove", return_value=True):
self.create_file.side_effect = ["/tmp/placeholder", ""]
@ -367,12 +320,7 @@ class TestCertChanged(ModuleTestCase):
password="changeit",
)
):
module = AnsibleModule(
argument_spec=module_argument_spec,
supports_check_mode=module_supports_check_mode,
mutually_exclusive=module_choose_between,
required_one_of=module_choose_between,
)
module = create_module()
with patch("os.remove", return_value=True):
self.create_file.side_effect = ["/tmp/placeholder", ""]
@ -395,12 +343,7 @@ class TestCertChanged(ModuleTestCase):
password="changeit",
)
):
module = AnsibleModule(
argument_spec=module_argument_spec,
supports_check_mode=module_supports_check_mode,
mutually_exclusive=module_choose_between,
required_one_of=module_choose_between,
)
module = create_module()
with patch("os.remove", return_value=True):
self.create_file.side_effect = ["/tmp/placeholder", ""]
@ -423,12 +366,7 @@ class TestCertChanged(ModuleTestCase):
password="changeit",
)
):
module = AnsibleModule(
argument_spec=module_argument_spec,
supports_check_mode=module_supports_check_mode,
mutually_exclusive=module_choose_between,
required_one_of=module_choose_between,
)
module = create_module()
module.exit_json = Mock()
module.fail_json = Mock()
@ -457,12 +395,7 @@ class TestCertChanged(ModuleTestCase):
password="changeit",
)
):
module = AnsibleModule(
argument_spec=module_argument_spec,
supports_check_mode=module_supports_check_mode,
mutually_exclusive=module_choose_between,
required_one_of=module_choose_between,
)
module = create_module()
module.exit_json = Mock()
module.fail_json = Mock(return_value=True)