ansible/community.general
1
0
Fork 0
mirror of https://github.com/ansible-collections/community.general.git synced 2026-06-18 05:43:10 +00:00
Code Activity

java_cert: detect silent keytool failures by verifying import outcome (#12238)

Browse source 
* fix(java_cert): detect silent keytool failures by verifying import outcome

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

* test(java_cert): add integration tests for silent keytool failure detection

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

* changelog: add fragment for PR 12238

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

* dummy

---------

Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
This commit is contained in:
Alexei Znamensky 2026-06-14 18:18:31 +12:00 • committed by GitHub
parent ebb813680e
commit f4339d8c0d
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
3 changed files with 51 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

14
plugins/modules/java_cert.py
View file

@ -411,6 +411,14 @@ def import_pkcs12_path(
if import_rc != 0 or not os.path.exists(keystore_path):
module.fail_json(msg=import_out, rc=import_rc, cmd=import_cmd, error=import_err)
check_alias = keystore_alias or pkcs12_alias
if check_alias:
alias_exists, dummy = _check_cert_present(
module, executable, keystore_path, keystore_pass, check_alias, keystore_type
)
if not alias_exists:
module.fail_json(msg=import_out, rc=import_rc, cmd=import_cmd, error=import_err)
return dict(
changed=True, msg=import_out, rc=import_rc, cmd=import_cmd, stdout=import_out, error=import_err, diff=diff
)
@ -431,7 +439,11 @@ def import_cert_path(module, executable, path, keystore_path, keystore_pass, ali
)
diff = {"before": "\n", "after": f"{alias}\n"}
if import_rc != 0:
if import_rc != 0 or not os.path.exists(keystore_path):
module.fail_json(msg=import_out, rc=import_rc, cmd=import_cmd, error=import_err)
alias_exists, dummy = _check_cert_present(module, executable, keystore_path, keystore_pass, alias, keystore_type)
if not alias_exists:
module.fail_json(msg=import_out, rc=import_rc, cmd=import_cmd, error=import_err)
return dict(