From e6502a8e510d85316dd14a4a7c98967287c8fc79 Mon Sep 17 00:00:00 2001 From: Alexei Znamensky <103110+russoz@users.noreply.github.com> Date: Sun, 31 Aug 2025 21:49:09 +1200 Subject: [PATCH] xenserver: remove required=false from arg spec (#10769) * xenserver: remove required=false from arg spec * add changelog frag --- changelogs/fragments/10769-xenserver-rf.yml | 2 ++ plugins/module_utils/xenserver.py | 4 ---- 2 files changed, 2 insertions(+), 4 deletions(-) create mode 100644 changelogs/fragments/10769-xenserver-rf.yml diff --git a/changelogs/fragments/10769-xenserver-rf.yml b/changelogs/fragments/10769-xenserver-rf.yml new file mode 100644 index 0000000000..2c31edf886 --- /dev/null +++ b/changelogs/fragments/10769-xenserver-rf.yml @@ -0,0 +1,2 @@ +minor_changes: + - xenserver module utils - remove redundant constructs from argument specs (https://github.com/ansible-collections/community.general/pull/10769). diff --git a/plugins/module_utils/xenserver.py b/plugins/module_utils/xenserver.py index 3176b56289..bb4e18fba4 100644 --- a/plugins/module_utils/xenserver.py +++ b/plugins/module_utils/xenserver.py @@ -28,22 +28,18 @@ def xenserver_common_argument_spec(): return dict( hostname=dict(type='str', aliases=['host', 'pool'], - required=False, default='localhost', fallback=(env_fallback, ['XENSERVER_HOST']), ), username=dict(type='str', aliases=['user', 'admin'], - required=False, default='root', fallback=(env_fallback, ['XENSERVER_USER'])), password=dict(type='str', aliases=['pass', 'pwd'], - required=False, no_log=True, fallback=(env_fallback, ['XENSERVER_PASSWORD'])), validate_certs=dict(type='bool', - required=False, default=True, fallback=(env_fallback, ['XENSERVER_VALIDATE_CERTS'])), )