ansible/community.general
1
0
Fork 0
mirror of https://github.com/ansible-collections/community.general.git synced 2026-05-06 18:15:54 +00:00
Code Activity

odbc: fetch rows before commit to fix HY010 function sequence error (#11972)

Browse source 
* fix(odbc): fetch rows before committing to fix HY010 function sequence error

Fixes #5395

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

* chore(odbc): add changelog fragment for PR #11972

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

---------

Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
This commit is contained in:
Alexei Znamensky 2026-05-03 12:47:49 +12:00 • committed by GitHub
parent 2e29b3204d
commit d7f248fb01
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 4 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

2
changelogs/fragments/11972-odbc-fix-commit-fetch-order.yml Normal file
View file

@ -0,0 +1,2 @@
bugfixes:
- odbc - fetch rows before committing to fix ``HY010`` function sequence error (https://github.com/ansible-collections/community.general/issues/5395, https://github.com/ansible-collections/community.general/pull/11972).

4
plugins/modules/odbc.py
View file

@ -132,8 +132,6 @@ def main():
cursor.execute(query, params)
else:
cursor.execute(query)
if commit:
cursor.commit()
try:
# Get the rows out into an 2d array
for row in cursor.fetchall():
@ -158,6 +156,8 @@ def main():
except Exception as e:
module.fail_json(msg=f"Exception while reading rows: {e}")
if commit:
cursor.commit()
cursor.close()
except Exception as e:
module.fail_json(msg=f"Failed to execute query: {e}")