ansible/community.general
1
0
Fork 0
mirror of https://github.com/ansible-collections/community.general.git synced 2026-02-04 07:51:50 +00:00
Code Activity

Fix no-assert sanity errors, use Literal type for value_type, use exception kwarg

Browse source 
- Replace assert with t.cast() for mypy type narrowing (no-assert sanity)
- Use t.Literal for TomlParams.value_type instead of str
- Use exception= instead of traceback= in fail_json calls

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This commit is contained in:
Jose Drowne 2026-01-27 19:45:47 -05:00
parent e06e86db64
commit c24ef4988e
1 changed files with 13 additions and 10 deletions
Download patch file Download diff file Expand all files Collapse all files

23
plugins/modules/toml_file.py
View file

@ -312,7 +312,11 @@ class TomlParams:
table: str | None
key: str | None
value: t.Any
value_type: str
value_type: t.Literal[
"auto", "string", "literal_string", "multiline_string", "multiline_literal_string",
"integer", "hex_integer", "octal_integer", "binary_integer",
"float", "boolean", "datetime", "date", "time", "array", "inline_table",
]
state: str
backup: bool
create: bool
@ -603,8 +607,7 @@ def _navigate_aot(aot: AoT, index: int | str | None, is_last: bool, ctx: NavCont
return _get_aot_default(aot, ctx, i)
if index == "append":
return _handle_aot_append(aot, is_last, ctx, i)
assert isinstance(index, int)
return _get_aot_at_index(aot, index, ctx, i)
return _get_aot_at_index(aot, t.cast(int, index), ctx, i)
def _navigate_existing_segment(
@ -752,16 +755,16 @@ def _remove_aot_entry(aot: AoT, index: int | str) -> bool:
"""Remove an entry from an array of tables."""
if index == "append":
raise TomlFileError("Cannot use [append] with state=absent; use [-1] to remove the last entry")
assert isinstance(index, int)
if index == -1:
int_index = t.cast(int, index)
if int_index == -1:
if len(aot) > 0:
del aot[-1]
return True
return False
if 0 <= index < len(aot):
del aot[index]
if 0 <= int_index < len(aot):
del aot[int_index]
return True
raise TomlFileError(f"Array of tables index {index} out of range")
raise TomlFileError(f"Array of tables index {int_index} out of range")
# =============================================================================
@ -839,13 +842,13 @@ def _write_if_changed(
with os.fdopen(tmpfd, "wb") as f:
f.write(encoded_content)
except OSError:
module.fail_json(msg="Unable to create temporary file", traceback=traceback.format_exc())
module.fail_json(msg="Unable to create temporary file", exception=traceback.format_exc())
try:
module.atomic_move(tmpfile, os.path.abspath(target_path))
except OSError:
module.fail_json(
msg=f"Unable to move temporary file {tmpfile} to {target_path}", traceback=traceback.format_exc()
msg=f"Unable to move temporary file {tmpfile} to {target_path}", exception=traceback.format_exc()
)
return backup_file