Move modules and module_utils unit tests to correct place (#81)

* Move modules and module_utils unit tests to correct place.

* Update ignore.txt

* Fix imports.

* Fix typos.

* Fix more typos.

tests/unit/plugins/modules/network/check_point/test_checkpoint_access_rule.py

@@ -0,0 +1,105 @@
+# Copyright (c) 2018 Red Hat
+#
+# This file is part of Ansible
+#
+# Ansible is free software: you can redistribute it and/or modify
+# it under the terms of the GNU General Public License as published by
+# the Free Software Foundation, either version 3 of the License, or
+# (at your option) any later version.
+#
+# Ansible is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with Ansible.  If not, see <http://www.gnu.org/licenses/>.
+#
+
+from __future__ import absolute_import
+
+import pytest
+from ansible_collections.community.general.tests.unit.plugins.modules.utils import set_module_args, exit_json, fail_json, AnsibleFailJson, AnsibleExitJson
+
+from ansible.module_utils import basic
+from ansible_collections.community.general.plugins.modules.network.check_point import checkpoint_access_rule
+
+OBJECT = {'layer': 'foo', 'position': 'bar', 'name': 'baz',
+          'source': [{'name': 'lol'}], 'destination': [{'name': 'Any'}],
+          'action': {'name': 'drop'}, 'enabled': True}
+PAYLOAD = {'layer': 'foo', 'position': 'bar', 'name': 'baz'}
+
+
+class TestCheckpointAccessRule(object):
+    module = checkpoint_access_rule
+
+    @pytest.fixture(autouse=True)
+    def module_mock(self, mocker):
+        return mocker.patch.multiple(basic.AnsibleModule, exit_json=exit_json, fail_json=fail_json)
+
+    @pytest.fixture
+    def connection_mock(self, mocker):
+        connection_class_mock = mocker.patch('ansible_collections.community.general.plugins.modules.network.check_point.checkpoint_access_rule.Connection')
+        return connection_class_mock.return_value
+
+    @pytest.fixture
+    def get_access_rule_200(self, mocker):
+        mock_function = mocker.patch('ansible_collections.community.general.plugins.modules.network.check_point.checkpoint_access_rule.get_access_rule')
+        mock_function.return_value = (200, OBJECT)
+        return mock_function.return_value
+
+    @pytest.fixture
+    def get_access_rule_404(self, mocker):
+        mock_function = mocker.patch('ansible_collections.community.general.plugins.modules.network.check_point.checkpoint_access_rule.get_access_rule')
+        mock_function.return_value = (404, 'Object not found')
+        return mock_function.return_value
+
+    def test_create(self, get_access_rule_404, connection_mock):
+        connection_mock.send_request.return_value = (200, OBJECT)
+        result = self._run_module(PAYLOAD)
+
+        assert result['changed']
+        assert 'checkpoint_access_rules' in result
+
+    def test_create_idempotent(self, get_access_rule_200, connection_mock):
+        connection_mock.send_request.return_value = (200, PAYLOAD)
+        result = self._run_module(PAYLOAD)
+
+        assert not result['changed']
+
+    def test_update(self, get_access_rule_200, connection_mock):
+        payload_for_update = {'enabled': False}
+        payload_for_update.update(PAYLOAD)
+        connection_mock.send_request.return_value = (200, payload_for_update)
+        result = self._run_module(payload_for_update)
+
+        assert result['changed']
+        assert not result['checkpoint_access_rules']['enabled']
+
+    def test_delete(self, get_access_rule_200, connection_mock):
+        connection_mock.send_request.return_value = (200, OBJECT)
+        payload_for_delete = {'state': 'absent'}
+        payload_for_delete.update(PAYLOAD)
+        result = self._run_module(payload_for_delete)
+
+        assert result['changed']
+
+    def test_delete_idempotent(self, get_access_rule_404, connection_mock):
+        payload = {'name': 'baz', 'state': 'absent'}
+        connection_mock.send_request.return_value = (200, OBJECT)
+        result = self._run_module(payload)
+
+        assert not result['changed']
+
+    def _run_module(self, module_args):
+        set_module_args(module_args)
+        with pytest.raises(AnsibleExitJson) as ex:
+            self.module.main()
+        return ex.value.args[0]
+
+    def _run_module_with_fail_json(self, module_args):
+        set_module_args(module_args)
+        with pytest.raises(AnsibleFailJson) as exc:
+            self.module.main()
+        result = exc.value.args[0]
+        return result

tests/unit/plugins/modules/network/check_point/test_checkpoint_host.py

@@ -0,0 +1,99 @@
+# Copyright (c) 2018 Red Hat
+#
+# This file is part of Ansible
+#
+# Ansible is free software: you can redistribute it and/or modify
+# it under the terms of the GNU General Public License as published by
+# the Free Software Foundation, either version 3 of the License, or
+# (at your option) any later version.
+#
+# Ansible is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with Ansible.  If not, see <http://www.gnu.org/licenses/>.
+#
+
+from __future__ import absolute_import
+
+import pytest
+from ansible_collections.community.general.tests.unit.plugins.modules.utils import set_module_args, exit_json, fail_json, AnsibleFailJson, AnsibleExitJson
+
+from ansible.module_utils import basic
+from ansible_collections.community.general.plugins.modules.network.check_point import checkpoint_host
+
+OBJECT = {'name': 'foo', 'ipv4-address': '192.168.0.15'}
+CREATE_PAYLOAD = {'name': 'foo', 'ip_address': '192.168.0.15'}
+UPDATE_PAYLOAD = {'name': 'foo', 'ip_address': '192.168.0.16'}
+DELETE_PAYLOAD = {'name': 'foo', 'state': 'absent'}
+
+
+class TestCheckpointHost(object):
+    module = checkpoint_host
+
+    @pytest.fixture(autouse=True)
+    def module_mock(self, mocker):
+        return mocker.patch.multiple(basic.AnsibleModule, exit_json=exit_json, fail_json=fail_json)
+
+    @pytest.fixture
+    def connection_mock(self, mocker):
+        connection_class_mock = mocker.patch('ansible_collections.community.general.plugins.modules.network.check_point.checkpoint_host.Connection')
+        return connection_class_mock.return_value
+
+    @pytest.fixture
+    def get_host_200(self, mocker):
+        mock_function = mocker.patch('ansible_collections.community.general.plugins.modules.network.check_point.checkpoint_host.get_host')
+        mock_function.return_value = (200, OBJECT)
+        return mock_function.return_value
+
+    @pytest.fixture
+    def get_host_404(self, mocker):
+        mock_function = mocker.patch('ansible_collections.community.general.plugins.modules.network.check_point.checkpoint_host.get_host')
+        mock_function.return_value = (404, 'Object not found')
+        return mock_function.return_value
+
+    def test_create(self, get_host_404, connection_mock):
+        connection_mock.send_request.return_value = (200, OBJECT)
+        result = self._run_module(CREATE_PAYLOAD)
+
+        assert result['changed']
+        assert 'checkpoint_hosts' in result
+
+    def test_create_idempotent(self, get_host_200, connection_mock):
+        connection_mock.send_request.return_value = (200, OBJECT)
+        result = self._run_module(CREATE_PAYLOAD)
+
+        assert not result['changed']
+
+    def test_update(self, get_host_200, connection_mock):
+        connection_mock.send_request.return_value = (200, OBJECT)
+        result = self._run_module(UPDATE_PAYLOAD)
+
+        assert result['changed']
+
+    def test_delete(self, get_host_200, connection_mock):
+        connection_mock.send_request.return_value = (200, OBJECT)
+        result = self._run_module(DELETE_PAYLOAD)
+
+        assert result['changed']
+
+    def test_delete_idempotent(self, get_host_404, connection_mock):
+        connection_mock.send_request.return_value = (200, OBJECT)
+        result = self._run_module(DELETE_PAYLOAD)
+
+        assert not result['changed']
+
+    def _run_module(self, module_args):
+        set_module_args(module_args)
+        with pytest.raises(AnsibleExitJson) as ex:
+            self.module.main()
+        return ex.value.args[0]
+
+    def _run_module_with_fail_json(self, module_args):
+        set_module_args(module_args)
+        with pytest.raises(AnsibleFailJson) as exc:
+            self.module.main()
+        result = exc.value.args[0]
+        return result

tests/unit/plugins/modules/network/check_point/test_checkpoint_session.py

@@ -0,0 +1,67 @@
+# Copyright (c) 2018 Red Hat
+#
+# This file is part of Ansible
+#
+# Ansible is free software: you can redistribute it and/or modify
+# it under the terms of the GNU General Public License as published by
+# the Free Software Foundation, either version 3 of the License, or
+# (at your option) any later version.
+#
+# Ansible is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with Ansible.  If not, see <http://www.gnu.org/licenses/>.
+#
+
+from __future__ import absolute_import
+
+import pytest
+from ansible_collections.community.general.tests.unit.plugins.modules.utils import set_module_args, exit_json, fail_json, AnsibleFailJson, AnsibleExitJson
+
+from ansible.module_utils import basic
+from ansible_collections.community.general.plugins.modules.network.check_point import checkpoint_session
+
+OBJECT = {'uid': '1234'}
+PAYLOAD = {}
+
+
+class TestCheckpointAccessRule(object):
+    module = checkpoint_session
+
+    @pytest.fixture(autouse=True)
+    def module_mock(self, mocker):
+        return mocker.patch.multiple(basic.AnsibleModule, exit_json=exit_json, fail_json=fail_json)
+
+    @pytest.fixture
+    def connection_mock(self, mocker):
+        connection_class_mock = mocker.patch('ansible_collections.community.general.plugins.modules.network.check_point.checkpoint_session.Connection')
+        return connection_class_mock.return_value
+
+    @pytest.fixture
+    def get_session_200(self, mocker):
+        mock_function = mocker.patch('ansible_collections.community.general.plugins.modules.network.check_point.checkpoint_session.get_session')
+        mock_function.return_value = (200, OBJECT)
+        return mock_function.return_value
+
+    def test_publish(self, get_session_200, connection_mock):
+        connection_mock.send_request.return_value = (200, OBJECT)
+        result = self._run_module(PAYLOAD)
+
+        assert result['changed']
+        assert 'checkpoint_session' in result
+
+    def _run_module(self, module_args):
+        set_module_args(module_args)
+        with pytest.raises(AnsibleExitJson) as ex:
+            self.module.main()
+        return ex.value.args[0]
+
+    def _run_module_with_fail_json(self, module_args):
+        set_module_args(module_args)
+        with pytest.raises(AnsibleFailJson) as exc:
+            self.module.main()
+        result = exc.value.args[0]
+        return result

tests/unit/plugins/modules/network/check_point/test_checkpoint_task_facts.py

@@ -0,0 +1,99 @@
+# Copyright (c) 2018 Red Hat
+#
+# This file is part of Ansible
+#
+# Ansible is free software: you can redistribute it and/or modify
+# it under the terms of the GNU General Public License as published by
+# the Free Software Foundation, either version 3 of the License, or
+# (at your option) any later version.
+#
+# Ansible is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with Ansible.  If not, see <http://www.gnu.org/licenses/>.
+#
+
+from __future__ import absolute_import
+
+import pytest
+from ansible_collections.community.general.tests.unit.plugins.modules.utils import set_module_args, exit_json, fail_json, AnsibleFailJson, AnsibleExitJson
+
+from ansible.module_utils import basic
+from ansible_collections.community.general.plugins.modules.network.check_point import checkpoint_host
+
+OBJECT = {'name': 'foo', 'ipv4-address': '192.168.0.15'}
+CREATE_PAYLOAD = {'name': 'foo', 'ip_address': '192.168.0.15'}
+UPDATE_PAYLOAD = {'name': 'foo', 'ip_address': '192.168.0.16'}
+DELETE_PAYLOAD = {'name': 'foo', 'state': 'absent'}
+
+
+class TestCheckpointHost(object):
+    module = checkpoint_host
+
+    @pytest.fixture(autouse=True)
+    def module_mock(self, mocker):
+        return mocker.patch.multiple(basic.AnsibleModule, exit_json=exit_json, fail_json=fail_json)
+
+    @pytest.fixture
+    def connection_mock(self, mocker):
+        connection_class_mock = mocker.patch('ansible_collections.community.general.plugins.modules.network.check_point.checkpoint_host.Connection')
+        return connection_class_mock.return_value
+
+    @pytest.fixture
+    def get_host_200(self, mocker):
+        mock_function = mocker.patch('ansible_collections.community.general.plugins.modules.network.check_point.checkpoint_host.get_host')
+        mock_function.return_value = (200, OBJECT)
+        return mock_function.return_value
+
+    @pytest.fixture
+    def get_host_404(self, mocker):
+        mock_function = mocker.patch('ansible_collections.community.general.plugins.modules.network.check_point.checkpoint_host.get_host')
+        mock_function.return_value = (404, 'Object not found')
+        return mock_function.return_value
+
+    def test_create(self, get_host_404, connection_mock):
+        connection_mock.send_request.return_value = (200, OBJECT)
+        result = self._run_module(CREATE_PAYLOAD)
+
+        assert result['changed']
+        assert 'checkpoint_hosts' in result
+
+    def test_create_idempotent(self, get_host_200, connection_mock):
+        connection_mock.send_request.return_value = (200, OBJECT)
+        result = self._run_module(CREATE_PAYLOAD)
+
+        assert not result['changed']
+
+    def test_update(self, get_host_200, connection_mock):
+        connection_mock.send_request.return_value = (200, OBJECT)
+        result = self._run_module(UPDATE_PAYLOAD)
+
+        assert result['changed']
+
+    def test_delete(self, get_host_200, connection_mock):
+        connection_mock.send_request.return_value = (200, OBJECT)
+        result = self._run_module(DELETE_PAYLOAD)
+
+        assert result['changed']
+
+    def test_delete_idempotent(self, get_host_404, connection_mock):
+        connection_mock.send_request.return_value = (200, OBJECT)
+        result = self._run_module(DELETE_PAYLOAD)
+
+        assert not result['changed']
+
+    def _run_module(self, module_args):
+        set_module_args(module_args)
+        with pytest.raises(AnsibleExitJson) as ex:
+            self.module.main()
+        return ex.value.args[0]
+
+    def _run_module_with_fail_json(self, module_args):
+        set_module_args(module_args)
+        with pytest.raises(AnsibleFailJson) as exc:
+            self.module.main()
+        result = exc.value.args[0]
+        return result