Move modules and module_utils unit tests to correct place (#81)

* Move modules and module_utils unit tests to correct place.

* Update ignore.txt

* Fix imports.

* Fix typos.

* Fix more typos.

tests/unit/plugins/modules/network/aireos/aireos_module.py

@@ -0,0 +1,87 @@
+# (c) 2016 Red Hat Inc.
+#
+# This file is part of Ansible
+#
+# Ansible is free software: you can redistribute it and/or modify
+# it under the terms of the GNU General Public License as published by
+# the Free Software Foundation, either version 3 of the License, or
+# (at your option) any later version.
+#
+# Ansible is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with Ansible.  If not, see <http://www.gnu.org/licenses/>.
+
+# Make coding more python3-ish
+from __future__ import (absolute_import, division, print_function)
+__metaclass__ = type
+
+import os
+import json
+
+from ansible_collections.community.general.tests.unit.plugins.modules.utils import AnsibleExitJson, AnsibleFailJson, ModuleTestCase
+
+fixture_path = os.path.join(os.path.dirname(__file__), 'fixtures')
+fixture_data = {}
+
+
+def load_fixture(name):
+    path = os.path.join(fixture_path, name)
+
+    if path in fixture_data:
+        return fixture_data[path]
+
+    with open(path) as f:
+        data = f.read()
+
+    try:
+        data = json.loads(data)
+    except Exception:
+        pass
+
+    fixture_data[path] = data
+    return data
+
+
+class TestCiscoWlcModule(ModuleTestCase):
+
+    def execute_module(self, failed=False, changed=False, commands=None, sort=True, defaults=False):
+
+        self.load_fixtures(commands)
+
+        if failed:
+            result = self.failed()
+            self.assertTrue(result['failed'], result)
+        else:
+            result = self.changed(changed)
+            self.assertEqual(result['changed'], changed, result)
+
+        if commands is not None:
+            if sort:
+                self.assertEqual(sorted(commands), sorted(result['commands']), result['commands'])
+            else:
+                self.assertEqual(commands, result['commands'], result['commands'])
+
+        return result
+
+    def failed(self):
+        with self.assertRaises(AnsibleFailJson) as exc:
+            self.module.main()
+
+        result = exc.exception.args[0]
+        self.assertTrue(result['failed'], result)
+        return result
+
+    def changed(self, changed=False):
+        with self.assertRaises(AnsibleExitJson) as exc:
+            self.module.main()
+
+        result = exc.exception.args[0]
+        self.assertEqual(result['changed'], changed, result)
+        return result
+
+    def load_fixtures(self, commands=None):
+        pass

tests/unit/plugins/modules/network/aireos/fixtures/aireos_config_config.cfg

@@ -0,0 +1,9 @@
+sysname router
+
+interface create mtc-1 1
+interface address dynamic-interface mtc-1 10.33.20.4 255.255.255.0 10.33.20.1
+interface vlan mtc-1 1
+
+interface create mtc-2 2
+interface address dynamic-interface mtc-2 10.33.26.4 255.255.255.0 10.33.26.1
+interface vlan mtc-2 2

tests/unit/plugins/modules/network/aireos/fixtures/aireos_config_src.cfg

@@ -0,0 +1,9 @@
+sysname foo
+
+interface create mtc-1 1
+interface address dynamic-interface mtc-1 10.33.20.4 255.255.255.0 10.33.20.2
+interface vlan mtc-1 1
+
+interface create mtc-2 2
+interface address dynamic-interface mtc-2 10.33.26.4 255.255.255.0 10.33.26.1
+interface vlan mtc-2 2

tests/unit/plugins/modules/network/aireos/fixtures/show_sysinfo

@@ -0,0 +1,43 @@
+Manufacturer's Name.............................. Cisco Systems Inc.
+Product Name..................................... Cisco Controller
+Product Version.................................. 8.2.110.0
+RTOS Version..................................... 8.2.110.0
+Bootloader Version............................... 8.0.100.0
+Emergency Image Version.......................... 8.0.100.0
+
+Build Type....................................... DATA + WPS
+
+System Name...................................... SOMEHOST
+System Location.................................. USA
+System Contact................................... SN:E228240;ASSET:LSMTCc1
+System ObjectID.................................. 1.3.6.1.4.1.9.1.1615
+Redundancy Mode.................................. Disabled
+IP Address....................................... 10.10.10.10
+IPv6 Address..................................... ::
+System Up Time................................... 328 days 7 hrs 54 mins 49 secs
+System Timezone Location......................... (GMT) London, Lisbon, Dublin, Edinburgh
+System Stats Realtime Interval................... 5
+System Stats Normal Interval..................... 180
+
+Configured Country............................... US  - United States
+Operating Environment............................ Commercial (10 to 35 C)
+Internal Temp Alarm Limits....................... 10 to 38 C
+Internal Temperature............................. +18 C
+Fan Status....................................... OK
+
+                                                    RAID Volume Status
+Drive 0.......................................... Good
+Drive 1.......................................... Good
+
+State of 802.11b Network......................... Enabled
+State of 802.11a Network......................... Enabled
+Number of WLANs.................................. 1
+Number of Active Clients......................... 0
+
+Burned-in MAC Address............................ AA:AA:AA:AA:AA:AA
+Power Supply 1................................... Present, OK
+Power Supply 2................................... Present, OK
+Maximum number of APs supported.................. 6000
+System Nas-Id....................................
+WLC MIC Certificate Types........................ SHA1/SHA2
+Licensing Type................................... RTU

tests/unit/plugins/modules/network/aireos/test_aireos_command.py

@@ -0,0 +1,122 @@
+# (c) 2016 Red Hat Inc.
+#
+# This file is part of Ansible
+#
+# Ansible is free software: you can redistribute it and/or modify
+# it under the terms of the GNU General Public License as published by
+# the Free Software Foundation, either version 3 of the License, or
+# (at your option) any later version.
+#
+# Ansible is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with Ansible.  If not, see <http://www.gnu.org/licenses/>.
+
+# Make coding more python3-ish
+from __future__ import (absolute_import, division, print_function)
+__metaclass__ = type
+
+import json
+
+from ansible_collections.community.general.tests.unit.compat.mock import patch
+from ansible_collections.community.general.plugins.modules.network.aireos import aireos_command
+from ansible_collections.community.general.tests.unit.plugins.modules.utils import set_module_args
+from .aireos_module import TestCiscoWlcModule, load_fixture
+from ansible.module_utils import six
+
+
+class TestCiscoWlcCommandModule(TestCiscoWlcModule):
+
+    module = aireos_command
+
+    def setUp(self):
+        super(TestCiscoWlcCommandModule, self).setUp()
+        self.mock_run_commands = patch('ansible_collections.community.general.plugins.modules.network.aireos.aireos_command.run_commands')
+        self.run_commands = self.mock_run_commands.start()
+
+    def tearDown(self):
+        super(TestCiscoWlcCommandModule, self).tearDown()
+        self.mock_run_commands.stop()
+
+    def load_fixtures(self, commands=None):
+
+        def load_from_file(*args, **kwargs):
+            module, commands = args
+            output = list()
+
+            for item in commands:
+                try:
+                    obj = json.loads(item['command'])
+                    command = obj['command']
+                except ValueError:
+                    command = item['command']
+                filename = str(command).replace(' ', '_')
+                output.append(load_fixture(filename))
+            return output
+
+        self.run_commands.side_effect = load_from_file
+
+    def test_aireos_command_simple(self):
+        set_module_args(dict(commands=['show sysinfo']))
+        result = self.execute_module()
+        self.assertEqual(len(result['stdout']), 1)
+        self.assertTrue(result['stdout'][0].startswith('Manufacturer\'s Name'))
+
+    def test_aireos_command_multiple(self):
+        set_module_args(dict(commands=['show sysinfo', 'show sysinfo']))
+        result = self.execute_module()
+        self.assertEqual(len(result['stdout']), 2)
+        self.assertTrue(result['stdout'][0].startswith('Manufacturer\'s Name'))
+
+    def test_aireos_command_wait_for(self):
+        wait_for = 'result[0] contains "Cisco Systems Inc"'
+        set_module_args(dict(commands=['show sysinfo'], wait_for=wait_for))
+        self.execute_module()
+
+    def test_aireos_command_wait_for_fails(self):
+        wait_for = 'result[0] contains "test string"'
+        set_module_args(dict(commands=['show sysinfo'], wait_for=wait_for))
+        self.execute_module(failed=True)
+        self.assertEqual(self.run_commands.call_count, 10)
+
+    def test_aireos_command_retries(self):
+        wait_for = 'result[0] contains "test string"'
+        set_module_args(dict(commands=['show sysinfo'], wait_for=wait_for, retries=2))
+        self.execute_module(failed=True)
+        self.assertEqual(self.run_commands.call_count, 2)
+
+    def test_aireos_command_match_any(self):
+        wait_for = ['result[0] contains "Cisco Systems Inc"',
+                    'result[0] contains "test string"']
+        set_module_args(dict(commands=['show sysinfo'], wait_for=wait_for, match='any'))
+        self.execute_module()
+
+    def test_aireos_command_match_all(self):
+        wait_for = ['result[0] contains "Cisco Systems Inc"',
+                    'result[0] contains "Cisco Controller"']
+        set_module_args(dict(commands=['show sysinfo'], wait_for=wait_for, match='all'))
+        self.execute_module()
+
+    def test_aireos_command_match_all_failure(self):
+        wait_for = ['result[0] contains "Cisco Systems Inc"',
+                    'result[0] contains "test string"']
+        commands = ['show sysinfo', 'show sysinfo']
+        set_module_args(dict(commands=commands, wait_for=wait_for, match='all'))
+        self.execute_module(failed=True)
+
+    def test_aireos_command_to_lines_non_ascii(self):
+        ''' Test data is one variation of the result of a `show run-config commands`
+        command on Cisco WLC version 8.8.120.0 '''
+        test_data = '''
+        wlan flexconnect learn-ipaddr 101 enable
+        `\xc8\x92\xef\xbf\xbdR\x7f`\xc8\x92\xef\xbf\xbdR\x7f`
+        wlan wgb broadcast-tagging disable 1
+        '''.strip()
+        test_string = six.u(test_data)
+        test_stdout = [test_string, ]
+        result = list(aireos_command.to_lines(test_stdout))
+        print(result[0])
+        self.assertEqual(len(result[0]), 3)

tests/unit/plugins/modules/network/aireos/test_aireos_config.py

@@ -0,0 +1,131 @@
+#
+# (c) 2016 Red Hat Inc.
+#
+# This file is part of Ansible
+#
+# Ansible is free software: you can redistribute it and/or modify
+# it under the terms of the GNU General Public License as published by
+# the Free Software Foundation, either version 3 of the License, or
+# (at your option) any later version.
+#
+# Ansible is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with Ansible.  If not, see <http://www.gnu.org/licenses/>.
+
+# Make coding more python3-ish
+from __future__ import (absolute_import, division, print_function)
+__metaclass__ = type
+
+from ansible_collections.community.general.tests.unit.compat.mock import patch
+from ansible_collections.community.general.plugins.modules.network.aireos import aireos_config
+from ansible_collections.community.general.tests.unit.plugins.modules.utils import set_module_args
+from .aireos_module import TestCiscoWlcModule, load_fixture
+
+
+class TestCiscoWlcConfigModule(TestCiscoWlcModule):
+
+    module = aireos_config
+
+    def setUp(self):
+        super(TestCiscoWlcConfigModule, self).setUp()
+
+        self.mock_get_config = patch('ansible_collections.community.general.plugins.modules.network.aireos.aireos_config.get_config')
+        self.get_config = self.mock_get_config.start()
+
+        self.mock_load_config = patch('ansible_collections.community.general.plugins.modules.network.aireos.aireos_config.load_config')
+        self.load_config = self.mock_load_config.start()
+
+        self.mock_run_commands = patch('ansible_collections.community.general.plugins.modules.network.aireos.aireos_config.run_commands')
+        self.run_commands = self.mock_run_commands.start()
+
+        self.mock_save_config = patch('ansible_collections.community.general.plugins.modules.network.aireos.aireos_config.save_config')
+        self.save_config = self.mock_save_config.start()
+
+    def tearDown(self):
+        super(TestCiscoWlcConfigModule, self).tearDown()
+        self.mock_get_config.stop()
+        self.mock_load_config.stop()
+        self.mock_run_commands.stop()
+
+    def load_fixtures(self, commands=None):
+        config_file = 'aireos_config_config.cfg'
+        self.get_config.return_value = load_fixture(config_file)
+        self.load_config.return_value = None
+
+    def test_aireos_config_unchanged(self):
+        src = load_fixture('aireos_config_config.cfg')
+        set_module_args(dict(src=src))
+        self.execute_module()
+
+    def test_aireos_config_src(self):
+        src = load_fixture('aireos_config_src.cfg')
+        set_module_args(dict(src=src))
+        commands = ['sysname foo', 'interface address dynamic-interface mtc-1 10.33.20.4 255.255.255.0 10.33.20.2']
+        self.execute_module(changed=True, commands=commands)
+
+    def test_aireos_config_backup(self):
+        set_module_args(dict(backup=True))
+        result = self.execute_module()
+        self.assertIn('__backup__', result)
+
+    def test_aireos_config_save(self):
+        set_module_args(dict(save=True))
+        self.execute_module()
+        self.assertEqual(self.save_config.call_count, 1)
+        self.assertEqual(self.get_config.call_count, 0)
+        self.assertEqual(self.load_config.call_count, 0)
+
+    def test_aireos_config_before(self):
+        set_module_args(dict(lines=['sysname foo'], before=['test1', 'test2']))
+        commands = ['test1', 'test2', 'sysname foo']
+        self.execute_module(changed=True, commands=commands, sort=False)
+
+    def test_aireos_config_after(self):
+        set_module_args(dict(lines=['sysname foo'], after=['test1', 'test2']))
+        commands = ['sysname foo', 'test1', 'test2']
+        self.execute_module(changed=True, commands=commands, sort=False)
+
+    def test_aireos_config_before_after_no_change(self):
+        set_module_args(dict(lines=['sysname router'],
+                             before=['test1', 'test2'],
+                             after=['test3', 'test4']))
+        self.execute_module()
+
+    def test_aireos_config_config(self):
+        config = 'sysname localhost'
+        set_module_args(dict(lines=['sysname router'], config=config))
+        commands = ['sysname router']
+        self.execute_module(changed=True, commands=commands)
+
+    def test_aireos_config_match_none(self):
+        lines = ['sysname router', 'interface create mtc-1 1']
+        set_module_args(dict(lines=lines, match='none'))
+        self.execute_module(changed=True, commands=lines, sort=False)
+
+    def test_nxos_config_save_always(self):
+        args = dict(save_when='always')
+        set_module_args(args)
+        self.execute_module()
+        self.assertEqual(self.save_config.call_count, 1)
+        self.assertEqual(self.get_config.call_count, 0)
+        self.assertEqual(self.load_config.call_count, 0)
+
+    def test_nxos_config_save_changed_true(self):
+        args = dict(save_when='changed', lines=['sysname foo', 'interface create mtc-3 3'])
+        set_module_args(args)
+        self.execute_module(changed=True)
+        self.assertEqual(self.save_config.call_count, 1)
+        self.assertEqual(self.get_config.call_count, 1)
+        self.assertEqual(self.load_config.call_count, 1)
+
+    def test_nxos_config_save_changed_false(self):
+        args = dict(save_when='changed')
+        set_module_args(args)
+        self.execute_module()
+        self.assertEqual(self.save_config.call_count, 0)
+        self.assertEqual(self.get_config.call_count, 0)
+        self.assertEqual(self.load_config.call_count, 0)