ansible/community.general
1
0
Fork 0
mirror of https://github.com/ansible-collections/community.general.git synced 2026-04-17 17:31:31 +00:00
Code Activity

nmcli: use get_best_parsable_locale() to support UTF-8 connection names (#11742)

Browse source 
* nmcli: start locale fix - normalize run_command environ to LANGUAGE=C, LC_ALL=C

Work in progress - issue #10384 (UTF-8 conn_name support) requires deeper
investigation beyond simple locale variable normalization.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

* nmcli: use get_best_parsable_locale() to support UTF-8 connection names

Fixes issue where UTF-8 connection names (e.g. Chinese characters) were
corrupted to '????' when LC_ALL=C forced ASCII encoding, causing
connection_exists() to always return False for non-ASCII names.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

* add changelog fragment for PR #11742

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

---------

Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
This commit is contained in:
Alexei Znamensky 2026-04-09 01:32:39 +12:00 • committed by GitHub
parent e59888dd7e
commit bdd3174563
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
3 changed files with 12 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

3
tests/unit/plugins/modules/test_nmcli.py
View file

@ -1652,6 +1652,9 @@ def mocker_set(
"""
Common mocker object
"""
mocker.patch(
"ansible_collections.community.general.plugins.modules.nmcli.get_best_parsable_locale", return_value="C"
)
get_bin_path = mocker.patch("ansible.module_utils.basic.AnsibleModule.get_bin_path")
get_bin_path.return_value = "/usr/bin/nmcli"
connection = mocker.patch.object(nmcli.Nmcli, "connection_exists")