ansible/community.general
1
0
Fork 0
mirror of https://github.com/ansible-collections/community.general.git synced 2026-05-04 09:23:02 +00:00
Code Activity

[PR #11954/89e0d070 backport][stable-12] puppet: fix TypeError when writing facts data (#11969)

Browse source 
puppet: fix `TypeError` when writing facts data (#11954)

* fix(puppet): remove erroneous encode() call in _write_structured_data()

Fixes #7932

* changelog: add fragment for puppet facts TypeError fix (#11954)

(cherry picked from commit 89e0d07071)

Co-authored-by: Alexei Znamensky <103110+russoz@users.noreply.github.com>
This commit is contained in:
patchback[bot] 2026-05-02 10:04:11 +02:00 • committed by GitHub
parent c2129d331b
commit b6e41311fd
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 3 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

2
changelogs/fragments/11954-puppet-facts-write-error.yml Normal file
View file

@ -0,0 +1,2 @@
bugfixes:
- puppet - fix ``TypeError`` when writing facts data (https://github.com/ansible-collections/community.general/issues/7932, https://github.com/ansible-collections/community.general/pull/11954).

2
plugins/modules/puppet.py
View file

@ -204,7 +204,7 @@ def _write_structured_data(basedir, basename, data):
# open the file with only u+rw set. Also, we use the stat constants
# because ansible still supports python 2.4 and the octal syntax changed
out_file = os.fdopen(os.open(file_path, os.O_CREAT | os.O_WRONLY, stat.S_IRUSR | stat.S_IWUSR), "w")
out_file.write(json.dumps(data).encode("utf8"))
out_file.write(json.dumps(data))
out_file.close()