ansible/community.general
1
0
Fork 0
mirror of https://github.com/ansible-collections/community.general.git synced 2026-05-06 10:05:54 +00:00
Code Activity

cisco_spark -> cisco_webex rename and message option fix (#457)

Browse source 
* This is a modified copy of the cisco_spark.py file. The name change is associated with the change of the product name from Cisco Spark to Cisco Webex Teams. In addition, the current version (cisco_spark) does not work due to a name collision with MESSAGE. I had to modify the name from "message" to "webexmsg" in many places in cisco_webex. It works fine in this version.

    The original author has been preserved and copied from cisco_spark to cisco_webex.
    @drew-russell

    The current version of cisco_spark module does not work due to a name collision with MESSAGE. I had to modify the name from "message" to "webexmsg" in many places in cisco_webex.py file. It works fine in this version.

    The name change is associated with the change of the product name from Cisco Spark to Cisco Webex Teams.

* cisco_spark rm

* suggested change

* aliases added to in def main funcitons

* sanity check corrections

* addess aliases type to msg_type

* felixfontein requested changes on this pull request.

* Return value change from msg to message.

* plugins/modules/notification/cisco_webex.py validate-modules:invalid-argument-name
added to tests/sanity/ignore-2.10.txt
This commit is contained in:
networkers.pl 2020-06-09 08:38:06 +02:00 • committed by GitHub
parent 423a7f122a
commit ab26dc8fa1
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
5 changed files with 193 additions and 192 deletions
Download patch file Download diff file Expand all files Collapse all files

6
tests/sanity/ignore-2.10.txt
View file

@ -1289,11 +1289,7 @@ plugins/modules/notification/campfire.py validate-modules:doc-missing-type
plugins/modules/notification/catapult.py validate-modules:doc-missing-type
plugins/modules/notification/catapult.py validate-modules:parameter-list-no-elements
plugins/modules/notification/catapult.py validate-modules:parameter-type-not-in-doc
plugins/modules/notification/cisco_spark.py validate-modules:doc-default-does-not-match-spec
plugins/modules/notification/cisco_spark.py validate-modules:doc-missing-type
plugins/modules/notification/cisco_spark.py validate-modules:invalid-argument-name
plugins/modules/notification/cisco_spark.py validate-modules:nonexistent-parameter-documented
plugins/modules/notification/cisco_spark.py validate-modules:undocumented-parameter
plugins/modules/notification/cisco_webex.py validate-modules:invalid-argument-name
plugins/modules/notification/flowdock.py validate-modules:doc-missing-type
plugins/modules/notification/grove.py validate-modules:invalid-argument-name
plugins/modules/notification/grove.py validate-modules:nonexistent-parameter-documented