ansible/community.general
1
0
Fork 0
mirror of https://github.com/ansible-collections/community.general.git synced 2026-03-22 05:09:12 +00:00
Code Activity

[PR #11589/d8bb637c backport][stable-12] nictagadm: don't call is_valid_mac when etherstub is true (#11618)

Browse source 
nictagadm: don't call is_valid_mac when etherstub is true (#11589)

* nictagadm: don't call is_valid_mac when etherstub is true

* Add changelog fragment

* update changelog fragment

* Shorten changelog fragement

* Update changelogs/fragments/nictagadm-etherstub-nonetype-bugfix.yml



---------


(cherry picked from commit d8bb637cba)

Co-authored-by: Adam D <44533090+emptyDir@users.noreply.github.com>
Co-authored-by: Felix Fontein <felix@fontein.de>
This commit is contained in:
patchback[bot] 2026-03-18 07:05:16 +01:00 • committed by GitHub
parent f06bcabeed
commit a882022280
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 4 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

3
changelogs/fragments/nictagadm-etherstub-nonetype-bugfix.yml Normal file
View file

@ -0,0 +1,3 @@
bugfixes:
- nictagadm - add a condition to the if statement so that ``is_valid_mac()`` does not get called if ``etherstub`` is false
(https://github.com/ansible-collections/community.general/pull/11589).

2
plugins/modules/nictagadm.py
View file

@ -193,7 +193,7 @@ def main():
state=nictag.state, state=nictag.state,
) )
if not nictag.is_valid_mac(): if not nictag.etherstub and not nictag.is_valid_mac():
module.fail_json(msg="Invalid MAC Address Value", name=nictag.name, mac=nictag.mac, etherstub=nictag.etherstub) module.fail_json(msg="Invalid MAC Address Value", name=nictag.name, mac=nictag.mac, etherstub=nictag.etherstub)
if nictag.state == "absent": if nictag.state == "absent":