From 9512a389f3e51682e615fd36e8b54e8c09f6bb09 Mon Sep 17 00:00:00 2001 From: "patchback[bot]" <45432694+patchback[bot]@users.noreply.github.com> Date: Thu, 5 May 2022 13:15:06 +0200 Subject: [PATCH] [opentelemetry][callback] fix hardcoded value for ansible_task_message (#4624) (#4632) * [opentelemetry][callback] fix hardcoded value for ansible_task_message * opentelemetry: add changelog fragment (cherry picked from commit 9f702946cdef908f114250f7d47601a77b85c7ff) Co-authored-by: Victor Martinez --- .../fragments/4624-opentelemetry_bug_fix_hardcoded_value.yml | 2 ++ plugins/callback/opentelemetry.py | 5 +++-- 2 files changed, 5 insertions(+), 2 deletions(-) create mode 100644 changelogs/fragments/4624-opentelemetry_bug_fix_hardcoded_value.yml diff --git a/changelogs/fragments/4624-opentelemetry_bug_fix_hardcoded_value.yml b/changelogs/fragments/4624-opentelemetry_bug_fix_hardcoded_value.yml new file mode 100644 index 0000000000..53d241eca8 --- /dev/null +++ b/changelogs/fragments/4624-opentelemetry_bug_fix_hardcoded_value.yml @@ -0,0 +1,2 @@ +bugfixes: + - opentelemetry callback plugin - fix task message attribute that is reported failed regardless of the task result (https://github.com/ansible-collections/community.general/pull/4624). diff --git a/plugins/callback/opentelemetry.py b/plugins/callback/opentelemetry.py index 9da5179399..1ea6e79622 100644 --- a/plugins/callback/opentelemetry.py +++ b/plugins/callback/opentelemetry.py @@ -258,8 +258,9 @@ class OpenTelemetrySource(object): else: res = host_data.result._result rc = res.get('rc', 0) - message = self.get_error_message(res) - enriched_error_message = self.enrich_error_message(res) + if host_data.status == 'failed': + message = self.get_error_message(res) + enriched_error_message = self.enrich_error_message(res) if host_data.status == 'failed': status = Status(status_code=StatusCode.ERROR, description=message)