ansible/community.general
1
0
Fork 0
mirror of https://github.com/ansible-collections/community.general.git synced 2026-06-11 02:25:36 +00:00
Code Activity

xenserver_guest_info: add VDI uuid and vdi_type to disk info (#12119)

Browse source 
* xenserver_guest_info: add VDI uuid and vdi_type to disk info

  Add uuid and vdi_type (VHD/QCOW2) fields to the disk information
  returned by xenserver_guest_info module.

  Fixes #11998

* changelog: add PR URL to changelog fragment

* xenserver_guest_info: add uuid and vdi_type to RETURN example output
This commit is contained in:
Shreyash 2026-05-30 23:13:30 +05:30 • committed by GitHub
parent d749cf7c85
commit 9208cbfd43
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
7 changed files with 24 additions and 7 deletions
Download patch file Download diff file Expand all files Collapse all files

2
changelogs/fragments/11998-xenserver-disk-uuid-vdi-type.yml Normal file
View file

@ -0,0 +1,2 @@
minor_changes:
- xenserver_guest_info - add VDI ``uuid`` and ``vdi_type`` (VHD/QCOW2) fields to disk info output (https://github.com/ansible-collections/community.general/issues/11998, https://github.com/ansible-collections/community.general/pull/12119).

2
plugins/module_utils/_xenserver.py
View file

@ -454,7 +454,9 @@ def gather_vm_facts(module: AnsibleModule, vm_params):
"sr": vm_disk_sr_params["name_label"],
"sr_uuid": vm_disk_sr_params["uuid"],
"os_device": vm_vbd_params["device"],
"uuid": vm_vbd_params["VDI"]["uuid"],
"vbd_userdevice": vm_vbd_params["userdevice"],
"vdi_type": vm_vbd_params["VDI"].get("sm_config", {}).get("vdi_type", ""),
}
vm_facts["disks"].append(vm_disk_params)

8
plugins/modules/xenserver_guest_info.py
View file

@ -76,7 +76,9 @@ instance:
"size": 42949672960,
"sr": "Local storage",
"sr_uuid": "0af1245e-bdb0-ba33-1446-57a962ec4075",
"vbd_userdevice": "0"
"uuid": "3f98b388-b2c0-4355-9a01-15c0e61b5a76",
"vbd_userdevice": "0",
"vdi_type": "vhd"
},
{
"name": "testvm_11-1",
@ -85,7 +87,9 @@ instance:
"size": 42949672960,
"sr": "Local storage",
"sr_uuid": "0af1245e-bdb0-ba33-1446-57a962ec4075",
"vbd_userdevice": "1"
"uuid": "a1b2c3d4-e5f6-7890-abcd-ef1234567890",
"vbd_userdevice": "1",
"vdi_type": "vhd"
}
],
"domid": "56",

4
tests/unit/plugins/module_utils/_xenserver/fixtures/ansible-test-vm-1-facts.json
View file

@ -11,7 +11,9 @@
"size": 42949672960,
"sr": "Ansible Test Storage 1",
"sr_uuid": "767b30e4-f8db-a83d-8ba7-f5e6e732e06f",
"vbd_userdevice": "0"
"uuid": "b807f67b-3f37-4a6e-ad6c-033f812ab093",
"vbd_userdevice": "0",
"vdi_type": "vhd"
}
],
"domid": "143",

8
tests/unit/plugins/module_utils/_xenserver/fixtures/ansible-test-vm-2-facts.json
View file

@ -11,7 +11,9 @@
"size": 10737418240,
"sr": "Ansible Test Storage 1",
"sr_uuid": "767b30e4-f8db-a83d-8ba7-f5e6e732e06f",
"vbd_userdevice": "0"
"uuid": "fa1202b8-326f-4235-802e-fafbed66b26b",
"vbd_userdevice": "0",
"vdi_type": "vhd"
},
{
"name": "ansible-test-vm-2-mysql",
@ -20,7 +22,9 @@
"size": 1073741824,
"sr": "Ansible Test Storage 1",
"sr_uuid": "767b30e4-f8db-a83d-8ba7-f5e6e732e06f",
"vbd_userdevice": "1"
"uuid": "ab3a4d72-f498-4687-86ce-ca937046db76",
"vbd_userdevice": "1",
"vdi_type": "vhd"
}
],
"domid": "140",

4
tests/unit/plugins/module_utils/_xenserver/fixtures/ansible-test-vm-3-facts.json
View file

@ -11,7 +11,9 @@
"size": 8589934592,
"sr": "Ansible Test Storage 1",
"sr_uuid": "767b30e4-f8db-a83d-8ba7-f5e6e732e06f",
"vbd_userdevice": "0"
"uuid": "bdd0baeb-5447-4963-9e71-a5ff6e85fa59",
"vbd_userdevice": "0",
"vdi_type": "qcow2"
}
],
"domid": "-1",

3
tests/unit/plugins/module_utils/_xenserver/fixtures/ansible-test-vm-3-params.json
View file

@ -138,7 +138,8 @@
"read_only": false,
"sharable": false,
"sm_config": {
"vdi_type": "vhd"
"image-format": "qcow2",
"vdi_type": "qcow2"
},
"snapshot_of": "OpaqueRef:NULL",
"snapshot_time": "19700101T00:00:00Z",