From c3b209c5fab9540de3d1335caf0fd226c4adbf1a Mon Sep 17 00:00:00 2001 From: Pascal GUINET Date: Mon, 2 Feb 2026 14:15:06 +0100 Subject: [PATCH] nsupdate: fix missing keyring initialization without TSIG auth --- changelogs/fragments/fix-nsupdate-keyring.yml | 2 ++ plugins/modules/nsupdate.py | 3 +++ 2 files changed, 5 insertions(+) create mode 100644 changelogs/fragments/fix-nsupdate-keyring.yml diff --git a/changelogs/fragments/fix-nsupdate-keyring.yml b/changelogs/fragments/fix-nsupdate-keyring.yml new file mode 100644 index 0000000000..ba97f9b86b --- /dev/null +++ b/changelogs/fragments/fix-nsupdate-keyring.yml @@ -0,0 +1,2 @@ +bugfixes: + - nsupdate - fix ``AttributeError`` when using the module without TSIG authentication (https://github.com/ansible-collections/community.general/issues/11460). diff --git a/plugins/modules/nsupdate.py b/plugins/modules/nsupdate.py index dc49e8e77d..76cb131bb3 100644 --- a/plugins/modules/nsupdate.py +++ b/plugins/modules/nsupdate.py @@ -248,6 +248,9 @@ class RecordManager: module.fail_json(msg="Missing key_secret") except binascii_error as e: module.fail_json(msg=f"TSIG key error: {e}") + else: + self.keyring = None + self.keyname = None if module.params["zone"] is None: if module.params["record"][-1] != ".":