ansible/community.general
1
0
Fork 0
mirror of https://github.com/ansible-collections/community.general.git synced 2026-04-25 13:12:46 +00:00
Code Activity

[PR #11049/396f467b backport][stable-12] Improve Python code: address unused variables (#11058)

Browse source 
Improve Python code: address unused variables (#11049)

* Address F841 (unused variable).

* Reformat.

* Add changelog fragment.

* More cleanup.

* Remove trailing whitespace.

* Readd removed code as a comment with TODO.

(cherry picked from commit 396f467bbb)

Co-authored-by: Felix Fontein <felix@fontein.de>
This commit is contained in:
patchback[bot] 2025-11-09 09:59:42 +01:00 • committed by GitHub
parent 1eca76969a
commit 8cd80d94a0
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
90 changed files with 232 additions and 235 deletions
Download patch file Download diff file Expand all files Collapse all files

16
tests/unit/plugins/modules/test_statsd.py
View file

@ -47,21 +47,21 @@ class TestStatsDModule(ModuleTestCase):
def test_udp_without_parameters(self):
"""Test udp without parameters"""
with self.patch_udp_statsd_client(side_effect=FakeStatsD) as fake_statsd:
with self.assertRaises(AnsibleFailJson) as result:
with self.patch_udp_statsd_client(side_effect=FakeStatsD):
with self.assertRaises(AnsibleFailJson):
with set_module_args({}):
self.module.main()
def test_tcp_without_parameters(self):
"""Test tcp without parameters"""
with self.patch_tcp_statsd_client(side_effect=FakeStatsD) as fake_statsd:
with self.assertRaises(AnsibleFailJson) as result:
with self.patch_tcp_statsd_client(side_effect=FakeStatsD):
with self.assertRaises(AnsibleFailJson):
with set_module_args({}):
self.module.main()
def test_udp_with_parameters(self):
"""Test udp with parameters"""
with self.patch_udp_statsd_client(side_effect=FakeStatsD) as fake_statsd:
with self.patch_udp_statsd_client(side_effect=FakeStatsD):
with self.assertRaises(AnsibleExitJson) as result:
with set_module_args(
{
@ -73,7 +73,7 @@ class TestStatsDModule(ModuleTestCase):
self.module.main()
self.assertEqual(result.exception.args[0]["msg"], "Sent counter my_counter -> 1 to StatsD")
self.assertEqual(result.exception.args[0]["changed"], True)
with self.patch_udp_statsd_client(side_effect=FakeStatsD) as fake_statsd:
with self.patch_udp_statsd_client(side_effect=FakeStatsD):
with self.assertRaises(AnsibleExitJson) as result:
with set_module_args(
{
@ -88,7 +88,7 @@ class TestStatsDModule(ModuleTestCase):
def test_tcp_with_parameters(self):
"""Test tcp with parameters"""
with self.patch_tcp_statsd_client(side_effect=FakeStatsD) as fake_statsd:
with self.patch_tcp_statsd_client(side_effect=FakeStatsD):
with self.assertRaises(AnsibleExitJson) as result:
with set_module_args(
{
@ -101,7 +101,7 @@ class TestStatsDModule(ModuleTestCase):
self.module.main()
self.assertEqual(result.exception.args[0]["msg"], "Sent counter my_counter -> 1 to StatsD")
self.assertEqual(result.exception.args[0]["changed"], True)
with self.patch_tcp_statsd_client(side_effect=FakeStatsD) as fake_statsd:
with self.patch_tcp_statsd_client(side_effect=FakeStatsD):
with self.assertRaises(AnsibleExitJson) as result:
with set_module_args(
{