From 89105559832fb48ba9871960dd90f17dad98ef5b Mon Sep 17 00:00:00 2001 From: Alexei Znamensky <103110+russoz@users.noreply.github.com> Date: Sat, 19 Apr 2025 19:26:59 +1200 Subject: [PATCH] puppet: use better CmdRunner param formatting (#10014) * puppet: use better CmdRunner param formatting * ignore none * add changelog frag --- changelogs/fragments/10014-puppet-improve-param.yml | 2 ++ plugins/module_utils/puppet.py | 5 +---- 2 files changed, 3 insertions(+), 4 deletions(-) create mode 100644 changelogs/fragments/10014-puppet-improve-param.yml diff --git a/changelogs/fragments/10014-puppet-improve-param.yml b/changelogs/fragments/10014-puppet-improve-param.yml new file mode 100644 index 0000000000..5d888523b7 --- /dev/null +++ b/changelogs/fragments/10014-puppet-improve-param.yml @@ -0,0 +1,2 @@ +minor_changes: + - puppet - improve parameter formatting, no impact to user (https://github.com/ansible-collections/community.general/pull/10014). diff --git a/plugins/module_utils/puppet.py b/plugins/module_utils/puppet.py index e06683b3ee..251d5618d3 100644 --- a/plugins/module_utils/puppet.py +++ b/plugins/module_utils/puppet.py @@ -95,10 +95,7 @@ def puppet_runner(module): skip_tags=cmd_runner_fmt.as_func(lambda v: ["--skip_tags", ",".join(v)]), certname=cmd_runner_fmt.as_opt_eq_val("--certname"), noop=cmd_runner_fmt.as_func(noop_func), - use_srv_records=cmd_runner_fmt.as_map({ - True: "--usr_srv_records", - False: "--no-usr_srv_records", - }), + use_srv_records=cmd_runner_fmt.as_bool("--usr_srv_records", "--no-usr_srv_records", ignore_none=True), logdest=cmd_runner_fmt.as_map(_logdest_map, default=[]), modulepath=cmd_runner_fmt.as_opt_eq_val("--modulepath"), _execute=cmd_runner_fmt.as_func(execute_func),