1
0
Fork 0
mirror of https://github.com/ansible-collections/community.general.git synced 2026-02-04 07:51:50 +00:00

Avoid six in plugin code (#10873)

Avoid six in plugin code.
This commit is contained in:
Felix Fontein 2025-10-05 06:56:32 +02:00 committed by GitHub
parent 9d0150b2c3
commit 6cd4665412
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
34 changed files with 70 additions and 120 deletions

View file

@ -112,7 +112,8 @@ _raw:
type: dict
"""
from ansible.module_utils.six.moves.urllib.parse import urlparse
from urllib.parse import urlparse
from ansible.errors import AnsibleError, AnsibleAssertionError
from ansible.plugins.lookup import LookupBase
from ansible.module_utils.common.text.converters import to_text

View file

@ -122,7 +122,6 @@ _list:
from ansible.errors import AnsibleLookupError
from collections.abc import Mapping, Sequence
from ansible.module_utils.six import string_types
from ansible.plugins.lookup import LookupBase
from ansible.template import Templar
@ -215,7 +214,7 @@ class LookupModule(LookupBase):
raise AnsibleLookupError(
f'The variable {k!r} appears more than once')
vars_so_far.add(k)
if isinstance(v, string_types):
if isinstance(v, str):
data.append((k, v, None))
elif isinstance(v, (Sequence, Mapping)):
data.append((k, None, v))

View file

@ -37,7 +37,6 @@ _raw:
type: list
"""
from ansible.errors import AnsibleError
from ansible.module_utils.six import string_types
from ansible.plugins.lookup import LookupBase
from ansible.utils.listify import listify_lookup_plugin_terms
@ -65,7 +64,7 @@ class LookupModule(LookupBase):
# ignore undefined items
break
if isinstance(term, string_types):
if isinstance(term, str):
# convert a variable to a list
term2 = listify_lookup_plugin_terms(term, templar=self._templar)
# but avoid converting a plain string to a list of one string

View file

@ -89,8 +89,9 @@ except ImportError:
import time
import json
from urllib.error import HTTPError
from ansible.module_utils.urls import open_url
from ansible.module_utils.six.moves.urllib.error import HTTPError
from ansible.errors import AnsibleError, AnsibleOptionsError
from ansible.plugins.lookup import LookupBase
from ansible.utils.display import Display

View file

@ -85,7 +85,6 @@ from ansible.plugins.lookup import LookupBase
from ansible.errors import AnsibleLookupError, AnsibleOptionsError
from ansible.module_utils.common.process import get_bin_path
from ansible.module_utils.common.text.converters import to_bytes, to_text
from ansible.module_utils.six import with_metaclass
from ansible_collections.community.general.plugins.module_utils.onepassword import OnePasswordConfig
@ -98,7 +97,7 @@ def _lower_if_possible(value):
return value
class OnePassCLIBase(with_metaclass(abc.ABCMeta, object)):
class OnePassCLIBase(object, metaclass=abc.ABCMeta):
bin = "op"
def __init__(

View file

@ -66,7 +66,6 @@ EXAMPLES = r"""
from ansible.plugins.lookup import LookupBase
from ansible.utils.display import Display
from ansible.errors import AnsibleError
from ansible.module_utils.six import raise_from
try:
from pam.revbits_ansible.server import SecretServer
@ -87,10 +86,7 @@ class LookupModule(LookupBase):
def run(self, terms, variables, **kwargs):
if ANOTHER_LIBRARY_IMPORT_ERROR:
raise_from(
AnsibleError('revbits_ansible must be installed to use this plugin'),
ANOTHER_LIBRARY_IMPORT_ERROR
)
raise AnsibleError('revbits_ansible must be installed to use this plugin') from ANOTHER_LIBRARY_IMPORT_ERROR
self.set_options(var_options=variables, direct=kwargs)
secret_server = LookupModule.Client(
{

View file

@ -258,7 +258,6 @@ EXAMPLES = r"""
import abc
import os
from ansible.errors import AnsibleError, AnsibleOptionsError
from ansible.module_utils import six
from ansible.plugins.lookup import LookupBase
from ansible.utils.display import Display
@ -289,8 +288,7 @@ except ImportError:
display = Display()
@six.add_metaclass(abc.ABCMeta)
class TSSClient(object):
class TSSClient(object, metaclass=abc.ABCMeta):
def __init__(self):
self._client = None