From 502e5ceb79d9ce33ff65071d3081eef1c2b48d47 Mon Sep 17 00:00:00 2001 From: "patchback[bot]" <45432694+patchback[bot]@users.noreply.github.com> Date: Thu, 17 Sep 2020 19:41:00 +0200 Subject: [PATCH] Fix for error trying to install cask with '@' in the name (#763) (#910) * Fix for casks with @ in the name * Add changelog fragment * Update changelogs/fragments/homebrew-cask-at-symbol-fix.yaml Period required at the end of changelog entry Co-authored-by: Andrew Klychkov * Use double backticks Co-authored-by: Andrew Klychkov (cherry picked from commit 8f2b2d9dc6d62ebf3cdcba3eb150b6fb4ecf2e64) Co-authored-by: Brandon Boles --- changelogs/fragments/homebrew-cask-at-symbol-fix.yaml | 2 ++ plugins/modules/packaging/os/homebrew_cask.py | 1 + 2 files changed, 3 insertions(+) create mode 100644 changelogs/fragments/homebrew-cask-at-symbol-fix.yaml diff --git a/changelogs/fragments/homebrew-cask-at-symbol-fix.yaml b/changelogs/fragments/homebrew-cask-at-symbol-fix.yaml new file mode 100644 index 0000000000..2b7d51bc52 --- /dev/null +++ b/changelogs/fragments/homebrew-cask-at-symbol-fix.yaml @@ -0,0 +1,2 @@ +bugfixes: + - homebrew_cask - fixed issue where a cask with ``@`` in the name is incorrectly reported as invalid (https://github.com/ansible-collections/community.general/issues/733). diff --git a/plugins/modules/packaging/os/homebrew_cask.py b/plugins/modules/packaging/os/homebrew_cask.py index d254e14ae6..d23fdc56fa 100644 --- a/plugins/modules/packaging/os/homebrew_cask.py +++ b/plugins/modules/packaging/os/homebrew_cask.py @@ -186,6 +186,7 @@ class HomebrewCask(object): . # dots / # slash (for taps) - # dashes + @ # at symbol ''' INVALID_PATH_REGEX = _create_regex_group(VALID_PATH_CHARS)