Adjust booleans in cloud modules. (#5155) (#5176)

(cherry picked from commit 3a08903e1c)

Co-authored-by: Felix Fontein <felix@fontein.de>

plugins/modules/cloud/rackspace/rax.py

@@ -22,15 +22,15 @@ options:
         created servers. Only applicable when used with the I(group) attribute
         or meta key.
     type: bool
-    default: 'yes'
+    default: true
   boot_from_volume:
     description:
       - Whether or not to boot the instance from a Cloud Block Storage volume.
-        If C(yes) and I(image) is specified a new volume will be created at
+        If C(true) and I(image) is specified a new volume will be created at
         boot time. I(boot_volume_size) is required with I(image) to create a
         new volume at boot time.
     type: bool
-    default: 'no'
+    default: false
   boot_volume:
     type: str
     description:
@@ -47,12 +47,12 @@ options:
       - Whether the I(boot_volume) or newly created volume from I(image) will
         be terminated when the server is terminated
     type: bool
-    default: 'no'
+    default: false
   config_drive:
     description:
       - Attach read-only configuration drive to server as label config-2
     type: bool
-    default: 'no'
+    default: false
   count:
     type: int
     description:
@@ -74,12 +74,12 @@ options:
   exact_count:
     description:
       - Explicitly ensure an exact count of instances, used with
-        state=active/present. If specified as C(yes) and I(count) is less than
+        state=active/present. If specified as C(true) and I(count) is less than
         the servers matched, servers will be deleted to match the count. If
         the number of matched servers is fewer than specified in I(count)
         additional servers will be added.
     type: bool
-    default: 'no'
+    default: false
   extra_client_args:
     type: dict
     description:
@@ -157,7 +157,7 @@ options:
     description:
       - wait for the instance to be in state 'running' before returning
     type: bool
-    default: 'no'
+    default: false
   wait_timeout:
     type: int
     description:
@@ -191,7 +191,7 @@ EXAMPLES = '''
         key_name: my_rackspace_key
         files:
           /root/test.txt: /home/localuser/test.txt
-        wait: yes
+        wait: true
         state: present
         networks:
           - private
@@ -212,9 +212,9 @@ EXAMPLES = '''
         state: present
         count: 10
         count_offset: 10
-        exact_count: yes
+        exact_count: true
         group: test
-        wait: yes
+        wait: true
       register: rax
 '''
 

plugins/modules/cloud/rackspace/rax_cbs.py

@@ -62,7 +62,7 @@ options:
     description:
       - wait for the volume to be in state 'available' before returning
     type: bool
-    default: 'no'
+    default: false
   wait_timeout:
     type: int
     description:
@@ -91,7 +91,7 @@ EXAMPLES = '''
         volume_type: SSD
         size: 150
         region: DFW
-        wait: yes
+        wait: true
         state: present
         meta:
           app: my-cool-app

plugins/modules/cloud/rackspace/rax_cbs_attachments.py

@@ -42,7 +42,7 @@ options:
     description:
       - wait for the volume to be in 'in-use'/'available' state before returning
     type: bool
-    default: 'no'
+    default: false
   wait_timeout:
     type: int
     description:
@@ -70,7 +70,7 @@ EXAMPLES = '''
         server: my-server
         device: /dev/xvdd
         region: DFW
-        wait: yes
+        wait: true
         state: present
       register: my_volume
 '''

plugins/modules/cloud/rackspace/rax_cdb.py

@@ -21,7 +21,7 @@ options:
     type: str
     description:
       - Name of the databases server instance
-    required: yes
+    required: true
   flavor:
     type: int
     description:
@@ -55,7 +55,7 @@ options:
     description:
       - wait for the instance to be in state 'running' before returning
     type: bool
-    default: 'no'
+    default: false
   wait_timeout:
     type: int
     description:
@@ -82,7 +82,7 @@ EXAMPLES = '''
         volume: 2
         cdb_type: MySQL
         cdb_version: 5.6
-        wait: yes
+        wait: true
         state: present
       register: rax_db_server
 '''

plugins/modules/cloud/rackspace/rax_cdb_database.py

@@ -18,12 +18,12 @@ options:
     type: str
     description:
       - The databases server UUID
-    required: yes
+    required: true
   name:
     type: str
     description:
       - Name to give to the database
-    required: yes
+    required: true
   character_set:
     type: str
     description:

plugins/modules/cloud/rackspace/rax_cdb_user.py

@@ -19,17 +19,17 @@ options:
     type: str
     description:
       - The databases server UUID
-    required: yes
+    required: true
   db_username:
     type: str
     description:
       - Name of the database user
-    required: yes
+    required: true
   db_password:
     type: str
     description:
       - Database user password
-    required: yes
+    required: true
   databases:
     type: list
     elements: str

plugins/modules/cloud/rackspace/rax_clb.py

@@ -34,7 +34,7 @@ options:
     type: str
     description:
       - Name to give the load balancer
-    required: yes
+    required: true
   port:
     type: int
     description:
@@ -94,7 +94,7 @@ options:
     description:
       - wait for the balancer to be in state 'running' before returning
     type: bool
-    default: 'no'
+    default: false
   wait_timeout:
     type: int
     description:
@@ -125,7 +125,7 @@ EXAMPLES = '''
         type: SERVICENET
         timeout: 30
         region: DFW
-        wait: yes
+        wait: true
         state: present
         meta:
           app: my-cool-app

plugins/modules/cloud/rackspace/rax_clb_nodes.py

@@ -64,7 +64,7 @@ options:
       - Type of node
   wait:
     required: false
-    default: "no"
+    default: false
     type: bool
     description:
       - Wait for the load balancer to become active before returning
@@ -99,7 +99,7 @@ EXAMPLES = '''
     port: 80
     condition: enabled
     type: primary
-    wait: yes
+    wait: true
     credentials: /path/to/credentials
 
 - name: Drain connections from a node
@@ -108,7 +108,7 @@ EXAMPLES = '''
     load_balancer_id: 71
     node_id: 410
     condition: draining
-    wait: yes
+    wait: true
     credentials: /path/to/credentials
 
 - name: Remove a node from the load balancer
@@ -117,7 +117,7 @@ EXAMPLES = '''
     load_balancer_id: 71
     node_id: 410
     state: absent
-    wait: yes
+    wait: true
     credentials: /path/to/credentials
 '''
 

plugins/modules/cloud/rackspace/rax_files.py

@@ -20,7 +20,7 @@ options:
       - Optionally clear existing metadata when applying metadata to existing containers.
         Selecting this option is only appropriate when setting type=meta
     type: bool
-    default: "no"
+    default: false
   container:
     type: str
     description:
@@ -82,7 +82,7 @@ extends_documentation_fragment:
 EXAMPLES = '''
 - name: "Test Cloud Files Containers"
   hosts: local
-  gather_facts: no
+  gather_facts: false
   tasks:
     - name: "List all containers"
       community.general.rax_files:
@@ -112,22 +112,22 @@ EXAMPLES = '''
     - name: "Make container public"
       community.general.rax_files:
         container: mycontainer
-        public: yes
+        public: true
 
     - name: "Make container public with a 24 hour TTL"
       community.general.rax_files:
         container: mycontainer
-        public: yes
+        public: true
         ttl: 86400
 
     - name: "Make container private"
       community.general.rax_files:
         container: mycontainer
-        private: yes
+        private: true
 
 - name: "Test Cloud Files Containers Metadata Storage"
   hosts: local
-  gather_facts: no
+  gather_facts: false
   tasks:
     - name: "Get mycontainer2 metadata"
       community.general.rax_files:

plugins/modules/cloud/rackspace/rax_files_objects.py

@@ -63,7 +63,7 @@ options:
         from Cloud Files.  Setting to false downloads the contents of a container to a single,
         flat directory
     type: bool
-    default: 'yes'
+    default: true
   type:
     type: str
     description:
@@ -153,14 +153,14 @@ EXAMPLES = '''
         method: get
         src: FileThatDoesNotExist.jpg
         dest: ~/Downloads/testcont
-      ignore_errors: yes
+      ignore_errors: true
 
     - name: "Attempt to delete remote object that does not exist"
       community.general.rax_files_objects:
         container: testcont
         method: delete
         dest: FileThatDoesNotExist.jpg
-      ignore_errors: yes
+      ignore_errors: true
 
 - name: "Test Cloud Files Objects Metadata"
   hosts: local

plugins/modules/cloud/rackspace/rax_mon_check.py

@@ -93,7 +93,7 @@ options:
       256 items.
   disabled:
     description:
-    - If "yes", ensure the check is created, but don't actually use it yet.
+    - If C(true), ensure the check is created, but don't actually use it yet.
     type: bool
     default: false
   metadata:

plugins/modules/cloud/rackspace/rax_network.py

@@ -27,7 +27,7 @@ options:
     type: str
     description:
       - Label (name) to give the network
-    required: yes
+    required: true
   cidr:
     type: str
     description:

plugins/modules/cloud/rackspace/rax_scaling_group.py

@@ -19,7 +19,7 @@ options:
     description:
       - Attach read-only configuration drive to server as label config-2
     type: bool
-    default: 'no'
+    default: false
   cooldown:
     type: int
     description:
@@ -112,7 +112,7 @@ options:
       - wait for the scaling group to finish provisioning the minimum amount of
         servers
     type: bool
-    default: 'no'
+    default: false
   wait_timeout:
     type: int
     description: