ansible/community.general
1
0
Fork 0
mirror of https://github.com/ansible-collections/community.general.git synced 2026-04-02 10:26:22 +00:00
Code Activity

Improve Python code: address unused variables (#11049)

Browse source 
* Address F841 (unused variable).

* Reformat.

* Add changelog fragment.

* More cleanup.

* Remove trailing whitespace.

* Readd removed code as a comment with TODO.
This commit is contained in:
Felix Fontein 2025-11-09 08:14:35 +01:00 • committed by GitHub
parent 0d8521c718
commit 396f467bbb
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
90 changed files with 232 additions and 235 deletions
Download patch file Download diff file Expand all files Collapse all files

26
tests/unit/plugins/modules/test_pritunl_org.py
View file

@ -73,8 +73,8 @@ class TestPritunlOrg(ModuleTestCase):
)
):
# Test creation
with self.patch_get_pritunl_organizations(side_effect=PritunlListOrganizationMock) as mock_get:
with self.patch_add_pritunl_organization(side_effect=PritunlPostOrganizationMock) as mock_add:
with self.patch_get_pritunl_organizations(side_effect=PritunlListOrganizationMock):
with self.patch_add_pritunl_organization(side_effect=PritunlPostOrganizationMock):
with self.assertRaises(AnsibleExitJson) as create_result:
self.module.main()
@ -85,8 +85,8 @@ class TestPritunlOrg(ModuleTestCase):
self.assertEqual(create_exc["response"]["user_count"], 0)
# Test module idempotency
with self.patch_get_pritunl_organizations(side_effect=PritunlListOrganizationAfterPostMock) as mock_get:
with self.patch_add_pritunl_organization(side_effect=PritunlPostOrganizationMock) as mock_add:
with self.patch_get_pritunl_organizations(side_effect=PritunlListOrganizationAfterPostMock):
with self.patch_add_pritunl_organization(side_effect=PritunlPostOrganizationMock):
with self.assertRaises(AnsibleExitJson) as idempotent_result:
self.module.main()
@ -115,8 +115,8 @@ class TestPritunlOrg(ModuleTestCase):
)
):
# Test deletion
with self.patch_get_pritunl_organizations(side_effect=PritunlListOrganizationAfterPostMock) as mock_get:
with self.patch_delete_pritunl_organization(side_effect=PritunlDeleteOrganizationMock) as mock_delete:
with self.patch_get_pritunl_organizations(side_effect=PritunlListOrganizationAfterPostMock):
with self.patch_delete_pritunl_organization(side_effect=PritunlDeleteOrganizationMock):
with self.assertRaises(AnsibleExitJson) as delete_result:
self.module.main()
@ -126,8 +126,8 @@ class TestPritunlOrg(ModuleTestCase):
self.assertEqual(delete_exc["response"], {})
# Test module idempotency
with self.patch_get_pritunl_organizations(side_effect=PritunlListOrganizationMock) as mock_get:
with self.patch_delete_pritunl_organization(side_effect=PritunlDeleteOrganizationMock) as mock_add:
with self.patch_get_pritunl_organizations(side_effect=PritunlListOrganizationMock):
with self.patch_delete_pritunl_organization(side_effect=PritunlDeleteOrganizationMock):
with self.assertRaises(AnsibleExitJson) as idempotent_result:
self.module.main()
@ -149,8 +149,8 @@ class TestPritunlOrg(ModuleTestCase):
}
with set_module_args(module_args):
# Test deletion
with self.patch_get_pritunl_organizations(side_effect=PritunlListOrganizationMock) as mock_get:
with self.patch_delete_pritunl_organization(side_effect=PritunlDeleteOrganizationMock) as mock_delete:
with self.patch_get_pritunl_organizations(side_effect=PritunlListOrganizationMock):
with self.patch_delete_pritunl_organization(side_effect=PritunlDeleteOrganizationMock):
with self.assertRaises(AnsibleFailJson) as failure_result:
self.module.main()
@ -160,10 +160,8 @@ class TestPritunlOrg(ModuleTestCase):
# Switch force=True which should run successfully
with set_module_args(dict_merge(module_args, {"force": True})):
with self.patch_get_pritunl_organizations(side_effect=PritunlListOrganizationMock) as mock_get:
with self.patch_delete_pritunl_organization(
side_effect=PritunlDeleteOrganizationMock
) as mock_delete:
with self.patch_get_pritunl_organizations(side_effect=PritunlListOrganizationMock):
with self.patch_delete_pritunl_organization(side_effect=PritunlDeleteOrganizationMock):
with self.assertRaises(AnsibleExitJson) as delete_result:
self.module.main()