mirror of
https://github.com/ansible-collections/community.general.git
synced 2026-04-09 13:37:15 +00:00
Address issues reported by ruff check (#11043)
* Resolve E713 and E714 (not in/is tests). * Address UP018 (unnecessary str call). * UP045 requires Python 3.10+. * Address UP007 (X | Y for type annotations). * Address UP035 (import Callable from collections.abc). * Address UP006 (t.Dict -> dict). * Address UP009 (UTF-8 encoding comment). * Address UP034 (extraneous parantheses). * Address SIM910 (dict.get() with None default). * Address F401 (unused import). * Address UP020 (use builtin open). * Address B009 and B010 (getattr/setattr with constant name). * Address SIM300 (Yoda conditions). * UP029 isn't in use anyway. * Address FLY002 (static join). * Address B034 (re.sub positional args). * Address B020 (loop variable overrides input). * Address B017 (assert raise Exception). * Address SIM211 (if expression with false/true). * Address SIM113 (enumerate for loop). * Address UP036 (sys.version_info checks). * Remove unnecessary UP039. * Address SIM201 (not ==). * Address SIM212 (if expr with twisted arms). * Add changelog fragment. * Reformat.
This commit is contained in:
parent
f5943201b9
commit
3478863ef0
77 changed files with 196 additions and 222 deletions
|
|
@ -4,7 +4,6 @@
|
|||
|
||||
from __future__ import annotations
|
||||
|
||||
import sys
|
||||
import unittest
|
||||
|
||||
from ansible_collections.community.general.plugins.module_utils.hwc_utils import HwcModuleException, navigate_value
|
||||
|
|
@ -14,10 +13,6 @@ class HwcUtilsTestCase(unittest.TestCase):
|
|||
def setUp(self):
|
||||
super().setUp()
|
||||
|
||||
# Add backward compatibility
|
||||
if sys.version_info < (3, 0):
|
||||
self.assertRaisesRegex = self.assertRaisesRegexp
|
||||
|
||||
def test_navigate_value(self):
|
||||
value = {
|
||||
"foo": {
|
||||
|
|
|
|||
|
|
@ -44,7 +44,7 @@ def test_cause_changes_deco(deco_args, expect_exception, expect_changed):
|
|||
|
||||
mh = MockMH()
|
||||
if expect_exception:
|
||||
with pytest.raises(Exception):
|
||||
with pytest.raises(ZeroDivisionError):
|
||||
mh.div_(1, 0)
|
||||
else:
|
||||
mh.div_(9, 3)
|
||||
|
|
|
|||
|
|
@ -32,7 +32,7 @@ def test_op_config(mocker, os_expanduser):
|
|||
mocker.patch("os.path.exists", side_effect=[False, True])
|
||||
op_config = OnePasswordConfig()
|
||||
|
||||
assert "/home/testuser/.config/op/config" == op_config.config_file_path
|
||||
assert op_config.config_file_path == "/home/testuser/.config/op/config"
|
||||
|
||||
|
||||
def test_op_no_config(mocker, os_expanduser):
|
||||
|
|
|
|||
Loading…
Add table
Add a link
Reference in a new issue