mirror of
https://github.com/ansible-collections/community.general.git
synced 2026-04-22 19:59:07 +00:00
Reformat everything.
This commit is contained in:
Felix Fontein
parent
3f2213791a
commit
340ff8586d
1008 changed files with 61301 additions and 58309 deletions
|
|
@ -13,9 +13,9 @@ import yaml
|
|||
from .oneview_module_loader import EthernetNetworkModule
|
||||
from .hpe_test_utils import OneViewBaseTestCase
|
||||
|
||||
FAKE_MSG_ERROR = 'Fake message error'
|
||||
DEFAULT_ETHERNET_NAME = 'Test Ethernet Network'
|
||||
RENAMED_ETHERNET = 'Renamed Ethernet Network'
|
||||
FAKE_MSG_ERROR = "Fake message error"
|
||||
DEFAULT_ETHERNET_NAME = "Test Ethernet Network"
|
||||
RENAMED_ETHERNET = "Renamed Ethernet Network"
|
||||
|
||||
DEFAULT_ENET_TEMPLATE = dict(
|
||||
name=DEFAULT_ETHERNET_NAME,
|
||||
|
|
@ -24,20 +24,13 @@ DEFAULT_ENET_TEMPLATE = dict(
|
|||
purpose="General",
|
||||
smartLink=False,
|
||||
privateNetwork=False,
|
||||
connectionTemplateUri=None
|
||||
connectionTemplateUri=None,
|
||||
)
|
||||
|
||||
PARAMS_FOR_PRESENT = dict(
|
||||
config='config.json',
|
||||
state='present',
|
||||
data=dict(name=DEFAULT_ETHERNET_NAME)
|
||||
)
|
||||
PARAMS_FOR_PRESENT = dict(config="config.json", state="present", data=dict(name=DEFAULT_ETHERNET_NAME))
|
||||
|
||||
PARAMS_TO_RENAME = dict(
|
||||
config='config.json',
|
||||
state='present',
|
||||
data=dict(name=DEFAULT_ETHERNET_NAME,
|
||||
newName=RENAMED_ETHERNET)
|
||||
config="config.json", state="present", data=dict(name=DEFAULT_ETHERNET_NAME, newName=RENAMED_ETHERNET)
|
||||
)
|
||||
|
||||
YAML_PARAMS_WITH_CHANGES = """
|
||||
|
|
@ -59,37 +52,26 @@ YAML_RESET_CONNECTION_TEMPLATE = """
|
|||
name: 'network name'
|
||||
"""
|
||||
|
||||
PARAMS_FOR_SCOPES_SET = dict(
|
||||
config='config.json',
|
||||
state='present',
|
||||
data=dict(name=DEFAULT_ETHERNET_NAME)
|
||||
)
|
||||
PARAMS_FOR_SCOPES_SET = dict(config="config.json", state="present", data=dict(name=DEFAULT_ETHERNET_NAME))
|
||||
|
||||
PARAMS_FOR_ABSENT = dict(
|
||||
config='config.json',
|
||||
state='absent',
|
||||
data=dict(name=DEFAULT_ETHERNET_NAME)
|
||||
)
|
||||
PARAMS_FOR_ABSENT = dict(config="config.json", state="absent", data=dict(name=DEFAULT_ETHERNET_NAME))
|
||||
|
||||
PARAMS_FOR_BULK_CREATED = dict(
|
||||
config='config.json',
|
||||
state='present',
|
||||
data=dict(namePrefix="TestNetwork", vlanIdRange="1-2,5,9-10")
|
||||
config="config.json", state="present", data=dict(namePrefix="TestNetwork", vlanIdRange="1-2,5,9-10")
|
||||
)
|
||||
|
||||
DEFAULT_BULK_ENET_TEMPLATE = [
|
||||
{'name': 'TestNetwork_1', 'vlanId': 1},
|
||||
{'name': 'TestNetwork_2', 'vlanId': 2},
|
||||
{'name': 'TestNetwork_5', 'vlanId': 5},
|
||||
{'name': 'TestNetwork_9', 'vlanId': 9},
|
||||
{'name': 'TestNetwork_10', 'vlanId': 10},
|
||||
{"name": "TestNetwork_1", "vlanId": 1},
|
||||
{"name": "TestNetwork_2", "vlanId": 2},
|
||||
{"name": "TestNetwork_5", "vlanId": 5},
|
||||
{"name": "TestNetwork_9", "vlanId": 9},
|
||||
{"name": "TestNetwork_10", "vlanId": 10},
|
||||
]
|
||||
|
||||
DICT_PARAMS_WITH_CHANGES = yaml.safe_load(YAML_PARAMS_WITH_CHANGES)["data"]
|
||||
|
||||
|
||||
class EthernetNetworkModuleSpec(unittest.TestCase,
|
||||
OneViewBaseTestCase):
|
||||
class EthernetNetworkModuleSpec(unittest.TestCase, OneViewBaseTestCase):
|
||||
"""
|
||||
OneViewBaseTestCase provides the mocks used in this test case
|
||||
"""
|
||||
|
|
@ -109,7 +91,7 @@ class EthernetNetworkModuleSpec(unittest.TestCase,
|
|||
self.mock_ansible_module.exit_json.assert_called_once_with(
|
||||
changed=True,
|
||||
msg=EthernetNetworkModule.MSG_CREATED,
|
||||
ansible_facts=dict(ethernet_network=DEFAULT_ENET_TEMPLATE)
|
||||
ansible_facts=dict(ethernet_network=DEFAULT_ENET_TEMPLATE),
|
||||
)
|
||||
|
||||
def test_should_not_update_when_data_is_equals(self):
|
||||
|
|
@ -122,12 +104,12 @@ class EthernetNetworkModuleSpec(unittest.TestCase,
|
|||
self.mock_ansible_module.exit_json.assert_called_once_with(
|
||||
changed=False,
|
||||
msg=EthernetNetworkModule.MSG_ALREADY_PRESENT,
|
||||
ansible_facts=dict(ethernet_network=DEFAULT_ENET_TEMPLATE)
|
||||
ansible_facts=dict(ethernet_network=DEFAULT_ENET_TEMPLATE),
|
||||
)
|
||||
|
||||
def test_update_when_data_has_modified_attributes(self):
|
||||
data_merged = DEFAULT_ENET_TEMPLATE.copy()
|
||||
data_merged['purpose'] = 'Management'
|
||||
data_merged["purpose"] = "Management"
|
||||
|
||||
self.resource.get_by.return_value = [DEFAULT_ENET_TEMPLATE]
|
||||
self.resource.update.return_value = data_merged
|
||||
|
|
@ -138,9 +120,7 @@ class EthernetNetworkModuleSpec(unittest.TestCase,
|
|||
EthernetNetworkModule().run()
|
||||
|
||||
self.mock_ansible_module.exit_json.assert_called_once_with(
|
||||
changed=True,
|
||||
msg=EthernetNetworkModule.MSG_UPDATED,
|
||||
ansible_facts=dict(ethernet_network=data_merged)
|
||||
changed=True, msg=EthernetNetworkModule.MSG_UPDATED, ansible_facts=dict(ethernet_network=data_merged)
|
||||
)
|
||||
|
||||
def test_update_when_only_bandwidth_has_modified_attributes(self):
|
||||
|
|
@ -154,31 +134,28 @@ class EthernetNetworkModuleSpec(unittest.TestCase,
|
|||
self.mock_ansible_module.exit_json.assert_called_once_with(
|
||||
changed=True,
|
||||
msg=EthernetNetworkModule.MSG_UPDATED,
|
||||
ansible_facts=dict(ethernet_network=DICT_PARAMS_WITH_CHANGES)
|
||||
ansible_facts=dict(ethernet_network=DICT_PARAMS_WITH_CHANGES),
|
||||
)
|
||||
|
||||
def test_update_when_data_has_modified_attributes_but_bandwidth_is_equal(self):
|
||||
data_merged = DEFAULT_ENET_TEMPLATE.copy()
|
||||
data_merged['purpose'] = 'Management'
|
||||
data_merged["purpose"] = "Management"
|
||||
|
||||
self.resource.get_by.return_value = [DEFAULT_ENET_TEMPLATE]
|
||||
self.resource.update.return_value = data_merged
|
||||
self.mock_ov_client.connection_templates.get.return_value = {
|
||||
"bandwidth": DICT_PARAMS_WITH_CHANGES['bandwidth']}
|
||||
self.mock_ov_client.connection_templates.get.return_value = {"bandwidth": DICT_PARAMS_WITH_CHANGES["bandwidth"]}
|
||||
|
||||
self.mock_ansible_module.params = yaml.safe_load(YAML_PARAMS_WITH_CHANGES)
|
||||
|
||||
EthernetNetworkModule().run()
|
||||
|
||||
self.mock_ansible_module.exit_json.assert_called_once_with(
|
||||
changed=True,
|
||||
msg=EthernetNetworkModule.MSG_UPDATED,
|
||||
ansible_facts=dict(ethernet_network=data_merged)
|
||||
changed=True, msg=EthernetNetworkModule.MSG_UPDATED, ansible_facts=dict(ethernet_network=data_merged)
|
||||
)
|
||||
|
||||
def test_update_successfully_even_when_connection_template_uri_not_exists(self):
|
||||
data_merged = DEFAULT_ENET_TEMPLATE.copy()
|
||||
del data_merged['connectionTemplateUri']
|
||||
del data_merged["connectionTemplateUri"]
|
||||
|
||||
self.resource.get_by.return_value = [DEFAULT_ENET_TEMPLATE]
|
||||
self.resource.update.return_value = data_merged
|
||||
|
|
@ -188,14 +165,12 @@ class EthernetNetworkModuleSpec(unittest.TestCase,
|
|||
EthernetNetworkModule().run()
|
||||
|
||||
self.mock_ansible_module.exit_json.assert_called_once_with(
|
||||
changed=True,
|
||||
msg=EthernetNetworkModule.MSG_UPDATED,
|
||||
ansible_facts=dict(ethernet_network=data_merged)
|
||||
changed=True, msg=EthernetNetworkModule.MSG_UPDATED, ansible_facts=dict(ethernet_network=data_merged)
|
||||
)
|
||||
|
||||
def test_rename_when_resource_exists(self):
|
||||
data_merged = DEFAULT_ENET_TEMPLATE.copy()
|
||||
data_merged['name'] = RENAMED_ETHERNET
|
||||
data_merged["name"] = RENAMED_ETHERNET
|
||||
params_to_rename = PARAMS_TO_RENAME.copy()
|
||||
|
||||
self.resource.get_by.return_value = [DEFAULT_ENET_TEMPLATE]
|
||||
|
|
@ -209,7 +184,7 @@ class EthernetNetworkModuleSpec(unittest.TestCase,
|
|||
|
||||
def test_create_with_new_name_when_resource_not_exists(self):
|
||||
data_merged = DEFAULT_ENET_TEMPLATE.copy()
|
||||
data_merged['name'] = RENAMED_ETHERNET
|
||||
data_merged["name"] = RENAMED_ETHERNET
|
||||
params_to_rename = PARAMS_TO_RENAME.copy()
|
||||
|
||||
self.resource.get_by.return_value = []
|
||||
|
|
@ -219,7 +194,7 @@ class EthernetNetworkModuleSpec(unittest.TestCase,
|
|||
|
||||
EthernetNetworkModule().run()
|
||||
|
||||
self.resource.create.assert_called_once_with(PARAMS_TO_RENAME['data'])
|
||||
self.resource.create.assert_called_once_with(PARAMS_TO_RENAME["data"])
|
||||
|
||||
def test_should_remove_ethernet_network(self):
|
||||
self.resource.get_by.return_value = [DEFAULT_ENET_TEMPLATE]
|
||||
|
|
@ -228,10 +203,7 @@ class EthernetNetworkModuleSpec(unittest.TestCase,
|
|||
|
||||
EthernetNetworkModule().run()
|
||||
|
||||
self.mock_ansible_module.exit_json.assert_called_once_with(
|
||||
changed=True,
|
||||
msg=EthernetNetworkModule.MSG_DELETED
|
||||
)
|
||||
self.mock_ansible_module.exit_json.assert_called_once_with(changed=True, msg=EthernetNetworkModule.MSG_DELETED)
|
||||
|
||||
def test_should_do_nothing_when_ethernet_network_not_exist(self):
|
||||
self.resource.get_by.return_value = []
|
||||
|
|
@ -241,8 +213,7 @@ class EthernetNetworkModuleSpec(unittest.TestCase,
|
|||
EthernetNetworkModule().run()
|
||||
|
||||
self.mock_ansible_module.exit_json.assert_called_once_with(
|
||||
changed=False,
|
||||
msg=EthernetNetworkModule.MSG_ALREADY_ABSENT
|
||||
changed=False, msg=EthernetNetworkModule.MSG_ALREADY_ABSENT
|
||||
)
|
||||
|
||||
def test_should_create_all_ethernet_networks(self):
|
||||
|
|
@ -253,17 +224,17 @@ class EthernetNetworkModuleSpec(unittest.TestCase,
|
|||
|
||||
EthernetNetworkModule().run()
|
||||
|
||||
self.resource.create_bulk.assert_called_once_with(
|
||||
dict(namePrefix="TestNetwork", vlanIdRange="1-2,5,9-10"))
|
||||
self.resource.create_bulk.assert_called_once_with(dict(namePrefix="TestNetwork", vlanIdRange="1-2,5,9-10"))
|
||||
self.mock_ansible_module.exit_json.assert_called_once_with(
|
||||
changed=True,
|
||||
msg=EthernetNetworkModule.MSG_BULK_CREATED,
|
||||
ansible_facts=dict(ethernet_network_bulk=DEFAULT_BULK_ENET_TEMPLATE))
|
||||
ansible_facts=dict(ethernet_network_bulk=DEFAULT_BULK_ENET_TEMPLATE),
|
||||
)
|
||||
|
||||
def test_should_create_missing_ethernet_networks(self):
|
||||
enet_get_range_return = [
|
||||
{'name': 'TestNetwork_1', 'vlanId': 1},
|
||||
{'name': 'TestNetwork_2', 'vlanId': 2},
|
||||
{"name": "TestNetwork_1", "vlanId": 1},
|
||||
{"name": "TestNetwork_2", "vlanId": 2},
|
||||
]
|
||||
|
||||
self.resource.get_range.side_effect = [enet_get_range_return, DEFAULT_BULK_ENET_TEMPLATE]
|
||||
|
|
@ -273,16 +244,17 @@ class EthernetNetworkModuleSpec(unittest.TestCase,
|
|||
|
||||
EthernetNetworkModule().run()
|
||||
|
||||
self.resource.create_bulk.assert_called_once_with(
|
||||
dict(namePrefix="TestNetwork", vlanIdRange="5,9,10"))
|
||||
self.resource.create_bulk.assert_called_once_with(dict(namePrefix="TestNetwork", vlanIdRange="5,9,10"))
|
||||
self.mock_ansible_module.exit_json.assert_called_once_with(
|
||||
changed=True, msg=EthernetNetworkModule.MSG_MISSING_BULK_CREATED,
|
||||
ansible_facts=dict(ethernet_network_bulk=DEFAULT_BULK_ENET_TEMPLATE))
|
||||
changed=True,
|
||||
msg=EthernetNetworkModule.MSG_MISSING_BULK_CREATED,
|
||||
ansible_facts=dict(ethernet_network_bulk=DEFAULT_BULK_ENET_TEMPLATE),
|
||||
)
|
||||
|
||||
def test_should_create_missing_ethernet_networks_with_just_one_difference(self):
|
||||
enet_get_range_return = [
|
||||
{'name': 'TestNetwork_1', 'vlanId': 1},
|
||||
{'name': 'TestNetwork_2', 'vlanId': 2},
|
||||
{"name": "TestNetwork_1", "vlanId": 1},
|
||||
{"name": "TestNetwork_2", "vlanId": 2},
|
||||
]
|
||||
|
||||
self.resource.get_range.side_effect = [enet_get_range_return, DEFAULT_BULK_ENET_TEMPLATE]
|
||||
|
|
@ -292,12 +264,13 @@ class EthernetNetworkModuleSpec(unittest.TestCase,
|
|||
|
||||
EthernetNetworkModule().run()
|
||||
|
||||
self.resource.create_bulk.assert_called_once_with({'vlanIdRange': '5-5', 'namePrefix': 'TestNetwork'})
|
||||
self.resource.create_bulk.assert_called_once_with({"vlanIdRange": "5-5", "namePrefix": "TestNetwork"})
|
||||
|
||||
self.mock_ansible_module.exit_json.assert_called_once_with(
|
||||
changed=True,
|
||||
msg=EthernetNetworkModule.MSG_MISSING_BULK_CREATED,
|
||||
ansible_facts=dict(ethernet_network_bulk=DEFAULT_BULK_ENET_TEMPLATE))
|
||||
ansible_facts=dict(ethernet_network_bulk=DEFAULT_BULK_ENET_TEMPLATE),
|
||||
)
|
||||
|
||||
def test_should_do_nothing_when_ethernet_networks_already_exist(self):
|
||||
self.resource.get_range.return_value = DEFAULT_BULK_ENET_TEMPLATE
|
||||
|
|
@ -308,26 +281,27 @@ class EthernetNetworkModuleSpec(unittest.TestCase,
|
|||
EthernetNetworkModule().run()
|
||||
|
||||
self.mock_ansible_module.exit_json.assert_called_once_with(
|
||||
changed=False, msg=EthernetNetworkModule.MSG_BULK_ALREADY_EXIST,
|
||||
ansible_facts=dict(ethernet_network_bulk=DEFAULT_BULK_ENET_TEMPLATE))
|
||||
changed=False,
|
||||
msg=EthernetNetworkModule.MSG_BULK_ALREADY_EXIST,
|
||||
ansible_facts=dict(ethernet_network_bulk=DEFAULT_BULK_ENET_TEMPLATE),
|
||||
)
|
||||
|
||||
def test_reset_successfully(self):
|
||||
self.resource.get_by.return_value = [DICT_PARAMS_WITH_CHANGES]
|
||||
self.mock_ov_client.connection_templates.update.return_value = {'result': 'success'}
|
||||
self.mock_ov_client.connection_templates.get.return_value = {
|
||||
"bandwidth": DICT_PARAMS_WITH_CHANGES['bandwidth']}
|
||||
self.mock_ov_client.connection_templates.update.return_value = {"result": "success"}
|
||||
self.mock_ov_client.connection_templates.get.return_value = {"bandwidth": DICT_PARAMS_WITH_CHANGES["bandwidth"]}
|
||||
|
||||
self.mock_ov_client.connection_templates.get_default.return_value = {"bandwidth": {
|
||||
"max": 1
|
||||
}}
|
||||
self.mock_ov_client.connection_templates.get_default.return_value = {"bandwidth": {"max": 1}}
|
||||
|
||||
self.mock_ansible_module.params = yaml.safe_load(YAML_RESET_CONNECTION_TEMPLATE)
|
||||
|
||||
EthernetNetworkModule().run()
|
||||
|
||||
self.mock_ansible_module.exit_json.assert_called_once_with(
|
||||
changed=True, msg=EthernetNetworkModule.MSG_CONNECTION_TEMPLATE_RESET,
|
||||
ansible_facts=dict(ethernet_network_connection_template={'result': 'success'}))
|
||||
changed=True,
|
||||
msg=EthernetNetworkModule.MSG_CONNECTION_TEMPLATE_RESET,
|
||||
ansible_facts=dict(ethernet_network_connection_template={"result": "success"}),
|
||||
)
|
||||
|
||||
def test_should_fail_when_reset_not_existing_ethernet_network(self):
|
||||
self.resource.get_by.return_value = [None]
|
||||
|
|
@ -337,44 +311,40 @@ class EthernetNetworkModuleSpec(unittest.TestCase,
|
|||
EthernetNetworkModule().run()
|
||||
|
||||
self.mock_ansible_module.fail_json.assert_called_once_with(
|
||||
exception=mock.ANY,
|
||||
msg=EthernetNetworkModule.MSG_ETHERNET_NETWORK_NOT_FOUND
|
||||
exception=mock.ANY, msg=EthernetNetworkModule.MSG_ETHERNET_NETWORK_NOT_FOUND
|
||||
)
|
||||
|
||||
def test_update_scopes_when_different(self):
|
||||
params_to_scope = PARAMS_FOR_PRESENT.copy()
|
||||
params_to_scope['data']['scopeUris'] = ['test']
|
||||
params_to_scope["data"]["scopeUris"] = ["test"]
|
||||
self.mock_ansible_module.params = params_to_scope
|
||||
|
||||
resource_data = DEFAULT_ENET_TEMPLATE.copy()
|
||||
resource_data['scopeUris'] = ['fake']
|
||||
resource_data['uri'] = 'rest/ethernet/fake'
|
||||
resource_data["scopeUris"] = ["fake"]
|
||||
resource_data["uri"] = "rest/ethernet/fake"
|
||||
self.resource.get_by.return_value = [resource_data]
|
||||
|
||||
patch_return = resource_data.copy()
|
||||
patch_return['scopeUris'] = ['test']
|
||||
patch_return["scopeUris"] = ["test"]
|
||||
self.resource.patch.return_value = patch_return
|
||||
|
||||
EthernetNetworkModule().run()
|
||||
|
||||
self.resource.patch.assert_called_once_with('rest/ethernet/fake',
|
||||
operation='replace',
|
||||
path='/scopeUris',
|
||||
value=['test'])
|
||||
self.resource.patch.assert_called_once_with(
|
||||
"rest/ethernet/fake", operation="replace", path="/scopeUris", value=["test"]
|
||||
)
|
||||
|
||||
self.mock_ansible_module.exit_json.assert_called_once_with(
|
||||
changed=True,
|
||||
ansible_facts=dict(ethernet_network=patch_return),
|
||||
msg=EthernetNetworkModule.MSG_UPDATED
|
||||
changed=True, ansible_facts=dict(ethernet_network=patch_return), msg=EthernetNetworkModule.MSG_UPDATED
|
||||
)
|
||||
|
||||
def test_should_do_nothing_when_scopes_are_the_same(self):
|
||||
params_to_scope = PARAMS_FOR_PRESENT.copy()
|
||||
params_to_scope['data']['scopeUris'] = ['test']
|
||||
params_to_scope["data"]["scopeUris"] = ["test"]
|
||||
self.mock_ansible_module.params = params_to_scope
|
||||
|
||||
resource_data = DEFAULT_ENET_TEMPLATE.copy()
|
||||
resource_data['scopeUris'] = ['test']
|
||||
resource_data["scopeUris"] = ["test"]
|
||||
self.resource.get_by.return_value = [resource_data]
|
||||
|
||||
EthernetNetworkModule().run()
|
||||
|
|
@ -384,9 +354,9 @@ class EthernetNetworkModuleSpec(unittest.TestCase,
|
|||
self.mock_ansible_module.exit_json.assert_called_once_with(
|
||||
changed=False,
|
||||
ansible_facts=dict(ethernet_network=resource_data),
|
||||
msg=EthernetNetworkModule.MSG_ALREADY_PRESENT
|
||||
msg=EthernetNetworkModule.MSG_ALREADY_PRESENT,
|
||||
)
|
||||
|
||||
|
||||
if __name__ == '__main__':
|
||||
if __name__ == "__main__":
|
||||
unittest.main()
|
||||
|
|
|
|||
Loading…
Add table
Add a link
Reference in a new issue