Remove deprecated features, bump version to 6.0.0 (#5326)

* Bump version to 6.0.0.

* sender option is now required.

* Default of want_proxmox_nodes_ansible_host changed from true to false.

* username is now an alias of user, and no longer of workspace.

* Remove deprecated return values in favor of end_state.

* Remove debug option.

* Change default of ignore_volatile_options from true to false.

* gitlab_group must now always contain the full path.

* Change default of norc from false to ture.

* Remove deprecated property.

* Add PR URL.

* Adjust bitbucket unit tests.

* Adjust module_helper integration test.

plugins/modules/identity/keycloak/keycloak_authentication.py

@@ -173,39 +173,6 @@ msg:
     returned: always
     type: str
 
-flow:
-    description:
-      - JSON representation for the authentication.
-      - Deprecated return value, it will be removed in community.general 6.0.0. Please use the return value I(end_state) instead.
-    returned: on success
-    type: dict
-    sample: {
-      "alias": "Copy of first broker login",
-      "authenticationExecutions": [
-        {
-          "alias": "review profile config",
-          "authenticationConfig": {
-            "alias": "review profile config",
-            "config": { "update.profile.on.first.login": "missing" },
-            "id": "6f09e4fb-aad4-496a-b873-7fa9779df6d7"
-          },
-          "configurable": true,
-          "displayName": "Review Profile",
-          "id": "8f77dab8-2008-416f-989e-88b09ccf0b4c",
-          "index": 0,
-          "level": 0,
-          "providerId": "idp-review-profile",
-          "requirement": "REQUIRED",
-          "requirementChoices": [ "REQUIRED", "ALTERNATIVE", "DISABLED" ]
-        }
-      ],
-      "builtIn": false,
-      "description": "Actions taken after first broker login with identity provider account, which is not yet linked to any Keycloak account",
-      "id": "bc228863-5887-4297-b898-4d988f8eaa5c",
-      "providerId": "basic-flow",
-      "topLevel": true
-    }
-
 end_state:
     description: Representation of the authentication after module execution.
     returned: on success
@@ -407,7 +374,6 @@ def main():
                 result['diff'] = dict(before='', after='')
             result['changed'] = False
             result['end_state'] = {}
-            result['flow'] = result['end_state']
             result['msg'] = new_auth_repr["alias"] + ' absent'
             module.exit_json(**result)
 
@@ -440,7 +406,6 @@ def main():
             if exec_repr is not None:
                 auth_repr["authenticationExecutions"] = exec_repr
             result['end_state'] = auth_repr
-            result['flow'] = result['end_state']
 
     else:
         if state == 'present':
@@ -478,7 +443,6 @@ def main():
             if exec_repr is not None:
                 auth_repr["authenticationExecutions"] = exec_repr
             result['end_state'] = auth_repr
-            result['flow'] = result['end_state']
 
         else:
             # Process a deletion (because state was not 'present')

plugins/modules/identity/keycloak/keycloak_group.py

@@ -214,59 +214,6 @@ end_state:
                 manage: true
                 manageMembership: true
                 view: true
-
-group:
-  description:
-    - Representation of the group after module execution.
-    - Deprecated return value, it will be removed in community.general 6.0.0. Please use the return value I(end_state) instead.
-  returned: always
-  type: complex
-  contains:
-    id:
-      description: GUID that identifies the group.
-      type: str
-      returned: always
-      sample: 23f38145-3195-462c-97e7-97041ccea73e
-    name:
-      description: Name of the group.
-      type: str
-      returned: always
-      sample: grp-test-123
-    attributes:
-      description: Attributes applied to this group.
-      type: dict
-      returned: always
-      sample:
-        attr1: ["val1", "val2", "val3"]
-    path:
-      description: URI path to the group.
-      type: str
-      returned: always
-      sample: /grp-test-123
-    realmRoles:
-      description: An array of the realm-level roles granted to this group.
-      type: list
-      returned: always
-      sample: []
-    subGroups:
-      description: A list of groups that are children of this group. These groups will have the same parameters as
-                   documented here.
-      type: list
-      returned: always
-    clientRoles:
-      description: A list of client-level roles granted to this group.
-      type: list
-      returned: always
-      sample: []
-    access:
-      description: A dict describing the accesses you have to this group based on the credentials used.
-      type: dict
-      returned: always
-      sample:
-        manage: true
-        manageMembership: true
-        view: true
-
 '''
 
 from ansible_collections.community.general.plugins.module_utils.identity.keycloak.keycloak import KeycloakAPI, camel, \
@@ -356,7 +303,6 @@ def main():
                 result['diff'] = dict(before='', after='')
             result['changed'] = False
             result['end_state'] = {}
-            result['group'] = result['end_state']
             result['msg'] = 'Group does not exist; doing nothing.'
             module.exit_json(**result)
 
@@ -377,7 +323,6 @@ def main():
         after_group = kc.get_group_by_name(name, realm)
 
         result['end_state'] = after_group
-        result['group'] = result['end_state']
 
         result['msg'] = 'Group {name} has been created with ID {id}'.format(name=after_group['name'],
                                                                             id=after_group['id'])
@@ -391,7 +336,6 @@ def main():
             if desired_group == before_group:
                 result['changed'] = False
                 result['end_state'] = desired_group
-                result['group'] = result['end_state']
                 result['msg'] = "No changes required to group {name}.".format(name=before_group['name'])
                 module.exit_json(**result)
 
@@ -410,7 +354,6 @@ def main():
             after_group = kc.get_group_by_groupid(desired_group['id'], realm=realm)
 
             result['end_state'] = after_group
-            result['group'] = result['end_state']
 
             result['msg'] = "Group {id} has been updated".format(id=after_group['id'])
             module.exit_json(**result)
@@ -430,7 +373,6 @@ def main():
             kc.delete_group(groupid=gid, realm=realm)
 
             result['end_state'] = {}
-            result['group'] = result['end_state']
 
             result['msg'] = "Group {name} has been deleted".format(name=before_group['name'])