Remove deprecated features, bump version to 6.0.0 (#5326)

* Bump version to 6.0.0.

* sender option is now required.

* Default of want_proxmox_nodes_ansible_host changed from true to false.

* username is now an alias of user, and no longer of workspace.

* Remove deprecated return values in favor of end_state.

* Remove debug option.

* Change default of ignore_volatile_options from true to false.

* gitlab_group must now always contain the full path.

* Change default of norc from false to ture.

* Remove deprecated property.

* Add PR URL.

* Adjust bitbucket unit tests.

* Adjust module_helper integration test.

plugins/modules/cloud/lxd/lxd_container.py

@@ -50,10 +50,10 @@ options:
           - If set to C(true), options starting with C(volatile.) are ignored. As a result,
             they are reapplied for each execution.
           - This default behavior can be changed by setting this option to C(false).
-          - The current default value C(true) is deprecated since community.general 4.0.0,
-            and will change to C(false) in community.general 6.0.0.
+          - The default value changed from C(true) to C(false) in community.general 6.0.0.
         type: bool
         required: false
+        default: false
         version_added: 3.7.0
     profiles:
         description:
@@ -769,6 +769,7 @@ def main():
             ),
             ignore_volatile_options=dict(
                 type='bool',
+                default=False,
             ),
             devices=dict(
                 type='dict',
@@ -832,16 +833,6 @@ def main():
         supports_check_mode=False,
     )
 
-    if module.params['ignore_volatile_options'] is None:
-        module.params['ignore_volatile_options'] = True
-        module.deprecate(
-            'If the keyword "volatile" is used in a playbook in the config'
-            'section, a "changed" message will appear with every run, even without a change'
-            'to the playbook.'
-            'This will change in the future. Please test your scripts'
-            'by "ignore_volatile_options: false". To keep the old behavior, set that option explicitly to "true"',
-            version='6.0.0', collection_name='community.general')
-
     lxd_manage = LXDContainerManagement(module=module)
     lxd_manage.run()
 

plugins/modules/cloud/smartos/vmadm.py

@@ -552,7 +552,7 @@ def create_payload(module, uuid):
     # Create the JSON payload (vmdef) and return the filename.
 
     # Filter out the few options that are not valid VM properties.
-    module_options = ['debug', 'force', 'state']
+    module_options = ['force', 'state']
     # @TODO make this a simple {} comprehension as soon as py2 is ditched
     # @TODO {k: v for k, v in p.items() if k not in module_options}
     vmdef = dict([(k, v) for k, v in module.params.items() if k not in module_options and v])
@@ -689,7 +689,6 @@ def main():
         nics=dict(type='list', elements='dict'),
         resolvers=dict(type='list', elements='str'),
         filesystems=dict(type='list', elements='dict'),
-        debug=dict(type='bool', removed_in_version='6.0.0', removed_from_collection='community.general'),
     )
 
     # Add our 'simple' options to options dict.