ansible/community.general
1
0
Fork 0
mirror of https://github.com/ansible-collections/community.general.git synced 2026-05-03 08:52:55 +00:00
Code Activity

[PR #11043/3478863e backport][stable-12] Address issues reported by ruff check (#11047)

Browse source 
Address issues reported by ruff check (#11043)

* Resolve E713 and E714 (not in/is tests).

* Address UP018 (unnecessary str call).

* UP045 requires Python 3.10+.

* Address UP007 (X | Y for type annotations).

* Address UP035 (import Callable from collections.abc).

* Address UP006 (t.Dict -> dict).

* Address UP009 (UTF-8 encoding comment).

* Address UP034 (extraneous parantheses).

* Address SIM910 (dict.get() with None default).

* Address F401 (unused import).

* Address UP020 (use builtin open).

* Address B009 and B010 (getattr/setattr with constant name).

* Address SIM300 (Yoda conditions).

* UP029 isn't in use anyway.

* Address FLY002 (static join).

* Address B034 (re.sub positional args).

* Address B020 (loop variable overrides input).

* Address B017 (assert raise Exception).

* Address SIM211 (if expression with false/true).

* Address SIM113 (enumerate for loop).

* Address UP036 (sys.version_info checks).

* Remove unnecessary UP039.

* Address SIM201 (not ==).

* Address SIM212 (if expr with twisted arms).

* Add changelog fragment.

* Reformat.

(cherry picked from commit 3478863ef0)

Co-authored-by: Felix Fontein <felix@fontein.de>
This commit is contained in:
patchback[bot] 2025-11-08 09:49:52 +01:00 • committed by GitHub
parent 11b802372b
commit 16f1d07509
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
77 changed files with 196 additions and 222 deletions
Download patch file Download diff file Expand all files Collapse all files

6
plugins/modules/one_image.py
View file

@ -466,10 +466,10 @@ class ImageModule(OpenNebulaModule):
return None
def get_image_by_name(self, image_name):
return self.get_image(lambda image: (image.NAME == image_name))
return self.get_image(lambda image: (image_name == image.NAME))
def get_image_by_id(self, image_id):
return self.get_image(lambda image: (image.ID == image_id))
return self.get_image(lambda image: (image_id == image.ID))
def get_image_instance(self, requested_id, requested_name):
# Using 'if requested_id:' doesn't work properly when requested_id=0
@ -589,7 +589,7 @@ class ImageModule(OpenNebulaModule):
result["changed"] = False
return result
if image.STATE == IMAGE_STATES.index("DISABLED"):
if IMAGE_STATES.index("DISABLED") == image.STATE:
self.module.fail_json(msg="Cannot clone DISABLED image")
if not self.module.check_mode: